Skip to content

using correct tool mode for run-make-support crate - #127677

Merged
bors merged 2 commits into
rust-lang:masterfrom
onur-ozkan:use-correct-modes
Jul 14, 2024
Merged

using correct tool mode for run-make-support crate#127677
bors merged 2 commits into
rust-lang:masterfrom
onur-ozkan:use-correct-modes

Conversation

@onur-ozkan

@onur-ozkanonur-ozkan commented Jul 13, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

We don't need to ensure std (and rustc) for testing run-make-support's unit tests. Using stage 0 compiler is already enough and speeds up x test run-make-support invocations on a clean build.

@rustbot

rustbot commented Jul 13, 2024

Copy link
Copy Markdown
Collaborator

r? @Kobzol

rustbot has assigned @Kobzol.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jul 13, 2024
onur-ozkan
onur-ozkan commented Jul 13, 2024
View reviewed changes
Comment threadsrc/bootstrap/src/core/build_steps/test.rs
@Kobzol

Kobzol commented Jul 13, 2024

Copy link
Copy Markdown
Member

It seems like compiletest uses some internal features of libtest, and it could perhaps cause issues when libtest is changed? 🤔 #79001 (comment)

@onur-ozkan
use ModeToolBootstrap for run-make-support's crate tests
fc0d1dc
We don't need to ensure std (and rustc) for testing run-make-support's
unit tests. Using stage 0 compiler is already enough and speeds up
`x test run-make-support` invocations on a clean build.
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan

onur-ozkan commented Jul 13, 2024

Copy link
Copy Markdown
ContributorAuthor

It seems like compiletest uses some internal features of libtest, and it could perhaps cause issues when libtest is changed? 🤔 #79001 (comment)

Right, that's true. Thanks!

@onur-ozkanonur-ozkan changed the title using correct tool mode for compiletest and run-make-support cratesusing correct tool mode for run-make-support crateJul 13, 2024
@Kobzol

Kobzol commented Jul 13, 2024

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Jul 13, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit fc0d1dc has been approved by Kobzol

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 13, 2024
@onur-ozkan
explain why we use in-tree std for compiletest
41070bd
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan

onur-ozkan commented Jul 13, 2024

Copy link
Copy Markdown
ContributorAuthor

@bors r-

I added explanation comment for compiletest's std usage.

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 13, 2024
@onur-ozkan

onur-ozkan commented Jul 13, 2024

Copy link
Copy Markdown
ContributorAuthor

@rustbot ready

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 13, 2024
@Kobzol

Kobzol commented Jul 13, 2024

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Jul 13, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit 41070bd has been approved by Kobzol

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 13, 2024
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jul 13, 2024
@workingjubilee
Rollup merge ofrust-lang#127677- onur-ozkan:use-correct-modes, r=Ko…
a02a776
…bzol
using correct tool mode for `run-make-support` crate
We don't need to ensure std (and rustc) for testing run-make-support's unit tests. Using stage 0 compiler is already enough and speeds up `x test run-make-support` invocations on a clean build.
@workingjubileeworkingjubilee mentioned this pull request Jul 13, 2024
Closed
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jul 13, 2024
@workingjubilee
Rollup merge ofrust-lang#127677- onur-ozkan:use-correct-modes, r=Ko…
dc0c76f
…bzol
using correct tool mode for `run-make-support` crate
We don't need to ensure std (and rustc) for testing run-make-support's unit tests. Using stage 0 compiler is already enough and speeds up `x test run-make-support` invocations on a clean build.
@workingjubileeworkingjubilee mentioned this pull request Jul 13, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 13, 2024
@bors
Auto merge ofrust-lang#127696- workingjubilee:rollup-5c951qn, r=wor…
b45624a
…kingjubilee
Rollup of 8 pull requests
Successful merges:
- rust-lang#122300 (Add FileCheck annotations to mir-opt/dest-prop tests)
- rust-lang#126967 (Promote the `wasm32-wasip2` target to Tier 2)
- rust-lang#127370 (Windows: Add experimental support for linking std-required system DLLs using raw-dylib)
- rust-lang#127434 (use "bootstrap" instead of "rustbuild" in comments and docs)
- rust-lang#127477 (Clear `inner_attr_ranges` regularly.)
- rust-lang#127558 (More attribute cleanups)
- rust-lang#127659 (Use ManuallyDrop in BufWriter::into_parts)
- rust-lang#127677 (using correct tool mode for `run-make-support` crate)
r? `@ghost`
`@rustbot` modify labels: rollup
jhpratt added a commit to jhpratt/rust that referenced this pull request Jul 13, 2024
@jhpratt
Rollup merge ofrust-lang#127677- onur-ozkan:use-correct-modes, r=Ko…
7a165e5
…bzol
using correct tool mode for `run-make-support` crate
We don't need to ensure std (and rustc) for testing run-make-support's unit tests. Using stage 0 compiler is already enough and speeds up `x test run-make-support` invocations on a clean build.
@jhprattjhpratt mentioned this pull request Jul 13, 2024
Closed
@workingjubilee

workingjubilee commented Jul 13, 2024

Copy link
Copy Markdown
Member

There was a failure in #127696 (comment) but it's not clear which PR failed it. Marking all target-specific and CI-related PRs from that rollup as iffy for now.

@bors rollup=iffy

bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 14, 2024
@bors
Auto merge ofrust-lang#127701- jhpratt:rollup-n50bfva, r=jhpratt
79b4b57
Rollup of 7 pull requests
Successful merges:
- rust-lang#122300 (Add FileCheck annotations to mir-opt/dest-prop tests)
- rust-lang#127153 (Initial implementation of anonymous_pipe API)
- rust-lang#127434 (use "bootstrap" instead of "rustbuild" in comments and docs)
- rust-lang#127477 (Clear `inner_attr_ranges` regularly.)
- rust-lang#127659 (Use ManuallyDrop in BufWriter::into_parts)
- rust-lang#127671 (rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 8))
- rust-lang#127677 (using correct tool mode for `run-make-support` crate)
r? `@ghost`
`@rustbot` modify labels: rollup
@workingjubileeworkingjubilee mentioned this pull request Jul 14, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 14, 2024
@bors
Auto merge ofrust-lang#127705- workingjubilee:rollup-sjlzycu, r=wor…
4cd8dc6
…kingjubilee
Rollup of 3 pull requests
Successful merges:
- rust-lang#127370 (Windows: Add experimental support for linking std-required system DLLs using raw-dylib)
- rust-lang#127446 (Remove memory leaks in doctests in `core`, `alloc`, and `std`)
- rust-lang#127677 (using correct tool mode for `run-make-support` crate)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 9201f18 into rust-lang:masterJul 14, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jul 14, 2024
@rust-timer
Unrolled build forrust-lang#127677
671452d
Rollup merge of rust-lang#127677 - onur-ozkan:use-correct-modes, r=Kobzol
using correct tool mode for `run-make-support` crate
We don't need to ensure std (and rustc) for testing run-make-support's unit tests. Using stage 0 compiler is already enough and speeds up `x test run-make-support` invocations on a clean build.
@rustbotrustbot added this to the 1.81.0 milestone Jul 14, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@KobzolKobzol

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Milestone

1.81.0

Development

Successfully merging this pull request may close these issues.

5 participants

@onur-ozkan@rustbot@Kobzol@bors@workingjubilee