Uh oh!
There was an error while loading. Please reload this page.
Miscellaneous improvements to struct tail normalization - #128703
Conversation
compiler-errors
commented
Aug 7, 2024
TODO: Rename struct_tail_erasing_regions |
8b7fadf to
ed9d69bComparerustbot
commented
Aug 8, 2024
Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri Some changes occurred in compiler/rustc_codegen_cranelift cc @bjorn3 |
This comment has been minimized.
This comment has been minimized.
ed9d69b to
b916431Comparerustbot
commented
Aug 8, 2024
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
lcnr
commented
Aug 9, 2024
@bors r+ rollup |
bors
commented
Aug 9, 2024
lcnr
commented
Aug 9, 2024
@bors rollup=iffy |
bors
commented
Aug 9, 2024
bors
commented
Aug 9, 2024
☀️ Test successful - checks-actions |
rust-timer
commented
Aug 9, 2024
Finished benchmarking commit (899eb03): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (secondary 4.1%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary 2.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 762.519s -> 759.636s (-0.38%) |
…=lcnr Miscellaneous improvements to struct tail normalization 1. Make checks for foreign tails more accurate by normalizing the struct tail. I didn't write a test for this one. 2. Normalize when computing struct tail for `offset_of` for slice/str. This fixes the new solver only. 3. Normalizing when computing tails for disaligned reference check. This fixes both solvers. r? lcnr
Upgrades toolchain to 08/28 Culprit upstream changes: 1. rust-lang/rust#128812 2. rust-lang/rust#128703 3. rust-lang/rust#127679 4. rust-lang/rust-clippy#12993 5. rust-lang/cargo#14370 6. rust-lang/rust#128806Resolves#3429 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.
offset_offor slice/str. This fixes the new solver only.r? lcnr