Uh oh!
There was an error while loading. Please reload this page.
Use more slice patterns inside the compiler - #128762
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
fmeaseforce-pushed
the
use-more-slice-pats
branch
from
August 7, 2024 01:47
0257ce3 to
8868f91Comparefmease
marked this pull request as ready for review
August 7, 2024 01:49
rustbot
commented
Aug 7, 2024
Collaborator
Some changes occurred in match checking cc @Nadrieril Some changes occurred in coverage instrumentation. cc @Zalathar Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt These commits modify compiler targets. |
fmease
commented
Aug 7, 2024
MemberAuthor
r? compiler |
This comment has been minimized.
This comment has been minimized.
| // A slice/array pattern `[P]` can be reparsed as `[T]`, an unsized array, | ||
| // when `P` can be reparsed as a type `T`. | ||
| PatKind::Slice(pats) if pats.len() == 1 => pats[0].to_ty().map(TyKind::Slice)?, | ||
| PatKind::Slice(pats) if let [pat] = &**pats => pat.to_ty().map(TyKind::Slice)?, |
Contributor
There was a problem hiding this comment.
I would kinda prefer we spell this as pats.as_slice() or &pats[..].
&** is kinda an eyesore, and the implicit autoderef of either strategies makes it less annoying if we change around the underlying type reprs.
| let attrs = tcx.hir().attrs(expr.hir_id); | ||
| if attrs.iter().any(|a| a.name_or_empty() == sym::rustc_box) { | ||
| if attrs.len() != 1 { | ||
| if let [attr] = attrs { |
Contributor
There was a problem hiding this comment.
You need to invert this check.
| ); | ||
| if fields.len() == 1 { | ||
| let src_ty = fields.raw[0].ty(self.body, self.tcx); | ||
| if let [field] = &*fields.raw { |
Contributor
There was a problem hiding this comment.
:( this is kinda annoying to have to do, but I guess at least equally annoying as fields.raw[0].
fmeaseforce-pushed
the
use-more-slice-pats
branch
from
August 7, 2024 10:29
8868f91 to
b6070a0Comparefmease
marked this pull request as draft
August 7, 2024 10:31
fmeaseforce-pushed
the
use-more-slice-pats
branch
from
August 7, 2024 10:54
b6070a0 to
a3e3ecaComparefmease
marked this pull request as ready for review
August 7, 2024 11:00
This comment has been minimized.
This comment has been minimized.
fmease
marked this pull request as draft
August 7, 2024 11:31
fmeaseforce-pushed
the
use-more-slice-pats
branch
from
August 7, 2024 11:38
a3e3eca to
c4c518dComparefmease
marked this pull request as ready for review
August 7, 2024 12:47
compiler-errors
approved these changes
Aug 10, 2024
compiler-errors
commented
Aug 10, 2024
Contributor
@bors r+ |
bors
commented
Aug 10, 2024
Collaborator
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 11, 2024
…iler-errors Use more slice patterns inside the compiler Nothing super noteworthy. Just replacing the common 'fragile' pattern of "length check followed by indexing or unwrap" with slice patterns for legibility and 'robustness'. r? ghost
This was referenced Aug 11, 2024
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 11, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#120314 (core: optimise Debug impl for ascii::Char) - rust-lang#128536 (Preliminary cleanup of `WitnessPat` hoisting/printing) - rust-lang#128592 (Promote aarch64-apple-darwin to Tier 1) - rust-lang#128762 (Use more slice patterns inside the compiler) - rust-lang#128875 (rm `import.used`) - rust-lang#128882 (make LocalWaker::will_wake consistent with Waker::will_wake) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 11, 2024
Rollup merge of rust-lang#128762 - fmease:use-more-slice-pats, r=compiler-errors Use more slice patterns inside the compiler Nothing super noteworthy. Just replacing the common 'fragile' pattern of "length check followed by indexing or unwrap" with slice patterns for legibility and 'robustness'. r? ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nothing super noteworthy. Just replacing the common 'fragile' pattern of "length check followed by indexing or unwrap" with slice patterns for legibility and 'robustness'.
r? ghost