Uh oh!
There was an error while loading. Please reload this page.
docs: begin a "low-level & unsafe code" guide. - #12887
Merged
Merged
Conversation
huonw
commented
Mar 14, 2014
ContributorAuthor
Member
There was a problem hiding this comment.
Could this show some example usage with an assert! that it's correct?
alexcrichton
commented
Mar 14, 2014
Member
This is pretty awesome, nice job! |
ContributorAuthor
There was a problem hiding this comment.
Nope, hyphen is valid (and seems to be the conventional one too, ~3x more google results for x86-64 than x86_64): http://en.wikipedia.org/wiki/X86-64
flaper87
commented
Mar 14, 2014
Contributor
Excellent work. Loving it so far! |
huonw
commented
Mar 15, 2014
ContributorAuthor
Addressed the review (mostly). |
alexcrichton
commented
Mar 15, 2014
Member
r=me with my comment plus a squash |
liigo
commented
Mar 15, 2014
Contributor
looks great to me |
This aims to cover the basics of writing safe unsafe code. At the moment it is just designed to be a better place for the `asm!()` docs than the detailed release notes wiki page, and I took the time to write up some other things. More examples are needed, especially of things that can subtly go wrong; and vast areas of `unsafe`-ty aren't covered, e.g. `static mut`s and thread-safety in general.
bors added a commit
that referenced
this pull request
Mar 15, 2014
docs: begin a "low-level & unsafe code" guide. This aims to cover the basics of writing safe unsafe code. At the moment it is just designed to be a better place for the `asm!()` docs than the detailed release notes wiki page, and I took the time to write up some other things. More examples are needed, especially of things that can subtly go wrong; and vast areas of `unsafe`-ty aren't covered, e.g. `static mut`s and thread-safety in general.
This was referenced Mar 15, 2014
Merged
matthiaskrgr pushed a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 2, 2022
fix: Honor ref expressions for compute_ref_match completions Fixesrust-lang/rust-analyzer#8357
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs: begin a "low-level & unsafe code" guide.
This aims to cover the basics of writing safe unsafe code. At the moment
it is just designed to be a better place for the
asm!()docs than thedetailed release notes wiki page, and I took the time to write up some
other things.
More examples are needed, especially of things that can subtly go wrong;
and vast areas of
unsafe-ty aren't covered, e.g.static muts andthread-safety in general.