Skip to content

stabilize std::path::Path::file_prefix - #129114

Closed
mbhall88 wants to merge 3 commits into
rust-lang:masterfrom
mbhall88:stabilize-file_prefix
Closed

stabilize std::path::Path::file_prefix#129114
mbhall88 wants to merge 3 commits into
rust-lang:masterfrom
mbhall88:stabilize-file_prefix

Conversation

@mbhall88

Copy link
Copy Markdown
Contributor

This PR proposes to stabilize std::path::Path::file_prefix.

I believe the first step is actually starting an FCP, but it was mentioned that the easiest way to achieve this was to open this stabilization PR first.

@rustbot

Copy link
Copy Markdown
Collaborator

r? @Amanieu

rustbot has assigned @Amanieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 15, 2024
@rustbot

Copy link
Copy Markdown
Collaborator

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

@mbhall88

Copy link
Copy Markdown
ContributorAuthor

@rustbot modify labels: +T-libs-api

@rustbotrustbot added the T-libs-api [DEPRECATED; DO NOT USE] label Aug 15, 2024
@rust-log-analyzer

This comment has been minimized.

@rustbot

Copy link
Copy Markdown
Collaborator

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@mbhall88mbhall88 changed the title stabilize std::path::file_prefixstabilize std::path::Path::file_prefixAug 15, 2024
Comment threadlibrary/std/src/path.rs Outdated
Co-authored-by: Slanterns <slanterns.w@gmail.com>
@slanterns

Copy link
Copy Markdown
Contributor

You should ask T-libs-api for FCP and merge, not me :)

@jieyouxujieyouxu added the needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. label Aug 22, 2024
@tgross35

Copy link
Copy Markdown
Member

Note that I suggested creating this PR as a way to get it on the radar, but I am of the opinion that the iterator API proposed at #86319 (comment) may be a preferable alternative. They are not mutually exclusive, however.

@AmanieuAmanieu added S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 20, 2024
@jieyouxu

Copy link
Copy Markdown
Member

Triage: the FCP seems to have completed but I think there are still outstanding concerns. No idea what the status of that FCP actually is...

@rustbot label: -S-waiting-on-fcp +S-waiting-on-review

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. labels May 2, 2025
@bors

bors commented Aug 13, 2025

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #145334) made this pull request unmergeable. Please resolve the merge conflicts.

@mbhall88

Copy link
Copy Markdown
ContributorAuthor

closing in favour of #144870

@rustbotrustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 15, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-run-makeArea: port run-make Makefiles to rmake.rsneeds-fcpThis change is insta-stable, or significant enough to need a team FCP to proceed.T-libsRelevant to the library team, which will review and decide on the PR/issue.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@mbhall88@rustbot@rust-log-analyzer@slanterns@tgross35@jieyouxu@bors@Amanieu