Re-enable `dump-ice-to-disk` for Windows by jieyouxu · Pull Request #129115 · rust-lang/rust

jieyouxu · 2024-08-15T05:25:06Z

This test was previously flakey on i686-mingw (reason unknown), but since some modifications (quarantining each ICE test in separate tmp dirs, adding/removing RUSTC_ICE env vars as suitable to prevent any kind of environmental influence), I could no longer make it fail on i686-mingw.

I tried running this test (without the ignore-windows of course) a bunch of times via i686-mingw try jobs and it refused to fail (see #128958). I was also never able to reproduce the failure locally.

In any case, if this turns out to be still flakey on i686-mingw, we can revert the removal of ignore-windows but this time we'll have way more context for why the test failed.

Running the i686-mingw alongside some Windows jobs for basic santiy check. But the try jobs succeeding is insufficient to guarantee reproducibility.

cc #129115 for backlink.

try-job: x86_64-msvc
try-job: x86_64-mingw
try-job: i686-msvc
try-job: i686-mingw

This test was previously flakey on `i686-mingw`, but since some modifications I could no longer make it fail on `i686-mingw`. See <rust-lang#128958> for multiple try job runs.

rustbot · 2024-08-15T05:25:14Z

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

jieyouxu · 2024-08-15T05:29:55Z

@bors try

jieyouxu · 2024-08-15T05:30:06Z

@rustbot author

Re-enable `dump-ice-to-disk` for Windows This test was previously flakey on `i686-mingw`, but since some modifications (quarantining each ICE test in separate tmp dirs, adding/removing `RUSTC_ICE` env vars as suitable to prevent any kind of environmental influence), I could no longer make it fail on `i686-mingw`. I tried running this test (without the `ignore-windows` of course) a bunch of times via `i686-mingw` try jobs and it refused to fail (see rust-lang#128958). In any case, if this turns out to be still flakey on `i686-mingw`, we can revert the removal of `ignore-windows` but this time we'll have way more context for why the test failed. Running the `i686-mingw` alongside some Windows jobs for basic santiy check. But the try jobs succeeding is insufficient to guarantee reproducibility. cc rust-lang#129115 for backlink. try-job: x86_64-msvc try-job: x86_64-mingw try-job: i686-msvc try-job: i686-mingw

bors · 2024-08-15T05:31:06Z

⌛ Trying commit 35785ef with merge 552ddf4...

bors · 2024-08-15T07:42:41Z

☀️ Try build successful - checks-actions
Build commit: 552ddf4 (552ddf4287f12edc2eec61798594491922128c79)

jieyouxu · 2024-08-15T07:49:26Z

@rustbot ready

estebank · 2024-08-16T17:35:27Z

@bors r+

bors · 2024-08-16T17:35:30Z

📌 Commit 35785ef has been approved by estebank

It is now in the queue for this repository.

…bank Re-enable `dump-ice-to-disk` for Windows This test was previously flakey on `i686-mingw` (reason unknown), but since some modifications (quarantining each ICE test in separate tmp dirs, adding/removing `RUSTC_ICE` env vars as suitable to prevent any kind of environmental influence), I could no longer make it fail on `i686-mingw`. I tried running this test (without the `ignore-windows` of course) a bunch of times via `i686-mingw` try jobs and it refused to fail (see rust-lang#128958). I was also never able to reproduce the failure locally. In any case, if this turns out to be still flakey on `i686-mingw`, we can revert the removal of `ignore-windows` but this time we'll have way more context for why the test failed. Running the `i686-mingw` alongside some Windows jobs for basic santiy check. But the try jobs succeeding is insufficient to guarantee reproducibility. cc rust-lang#129115 for backlink. try-job: x86_64-msvc try-job: x86_64-mingw try-job: i686-msvc try-job: i686-mingw

Rollup of 9 pull requests Successful merges: - rust-lang#128786 (Detect multiple crate versions on method not found) - rust-lang#128982 (Re-enable more debuginfo tests on Windows) - rust-lang#128989 (Emit an error for invalid use of the linkage attribute) - rust-lang#129115 (Re-enable `dump-ice-to-disk` for Windows) - rust-lang#129164 (Use `ar_archive_writer` for writing COFF import libs on all backends) - rust-lang#129167 (mir/pretty: use `Option` instead of `Either<Once, Empty>`) - rust-lang#129168 (Return correct HirId when finding body owner in diagnostics) - rust-lang#129173 (Fix `is_val_statically_known` for floats) - rust-lang#129185 (Port `run-make/libtest-json/validate_json.py` to Rust) r? `@ghost` `@rustbot` modify labels: rollup

…bank Re-enable `dump-ice-to-disk` for Windows This test was previously flakey on `i686-mingw` (reason unknown), but since some modifications (quarantining each ICE test in separate tmp dirs, adding/removing `RUSTC_ICE` env vars as suitable to prevent any kind of environmental influence), I could no longer make it fail on `i686-mingw`. I tried running this test (without the `ignore-windows` of course) a bunch of times via `i686-mingw` try jobs and it refused to fail (see rust-lang#128958). I was also never able to reproduce the failure locally. In any case, if this turns out to be still flakey on `i686-mingw`, we can revert the removal of `ignore-windows` but this time we'll have way more context for why the test failed. Running the `i686-mingw` alongside some Windows jobs for basic santiy check. But the try jobs succeeding is insufficient to guarantee reproducibility. cc rust-lang#129115 for backlink. try-job: x86_64-msvc try-job: x86_64-mingw try-job: i686-msvc try-job: i686-mingw

Rollup of 6 pull requests Successful merges: - rust-lang#128771 (Stabilize `unsafe_attributes`) - rust-lang#128982 (Re-enable more debuginfo tests on Windows) - rust-lang#129115 (Re-enable `dump-ice-to-disk` for Windows) - rust-lang#129173 (Fix `is_val_statically_known` for floats) - rust-lang#129185 (Port `run-make/libtest-json/validate_json.py` to Rust) - rust-lang#129190 (Added f16 and f128 to tests/ui/consts/const-float-bits-conv.rs) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2024-08-18T02:25:36Z

⌛ Testing commit 35785ef with merge 23f762d...

bors · 2024-08-18T04:54:54Z

☀️ Test successful - checks-actions
Approved by: estebank
Pushing 23f762d to master...

rust-timer · 2024-08-18T06:15:09Z

Finished benchmarking commit (23f762d): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.3%	[2.3%, 2.3%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (secondary -4.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.5%	[-4.5%, -4.5%]	1
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 750.905s -> 749.938s (-0.13%)
Artifact size: 339.10 MiB -> 339.18 MiB (0.02%)

tests: re-enable dump-ice-to-disk for Windows
35785ef
This test was previously flakey on `i686-mingw`, but since some modifications I could no longer make it fail on `i686-mingw`. See <rust-lang#128958> for multiple try job runs.

jieyouxu added the O-windows Operating system: Windows label Aug 15, 2024

rustbot assigned Mark-Simulacrum Aug 15, 2024

rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 15, 2024

jieyouxu mentioned this pull request Aug 15, 2024
tests/run-make/dump-ice-to-disk is flakey on i686-mingw #128911
Closed

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 15, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 15, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 16, 2024

tgross35 mentioned this pull request Aug 17, 2024
Rollup of 8 pull requests #129197
Closed

tgross35 mentioned this pull request Aug 17, 2024
Rollup of 9 pull requests #129198
Closed

tgross35 mentioned this pull request Aug 17, 2024
Rollup of 6 pull requests #129210
Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 18, 2024

bors merged commit 23f762d into rust-lang:masterAug 18, 2024

rustbot added this to the 1.82.0 milestone Aug 18, 2024

jieyouxu deleted the reenable-dump-ice branch August 18, 2024 05:23

Navigation Menu

Uh oh!

Uh oh!

Re-enable `dump-ice-to-disk` for Windows - #129115

Re-enable `dump-ice-to-disk` for Windows#129115
bors merged 1 commit into
rust-lang:masterfrom
jieyouxu:reenable-dump-ice

jieyouxu commented Aug 15, 2024•
edited
Loading

Uh oh!

rustbot commented Aug 15, 2024

Uh oh!

jieyouxu commented Aug 15, 2024

Uh oh!

jieyouxu commented Aug 15, 2024

Uh oh!

bors commented Aug 15, 2024

Uh oh!

bors commented Aug 15, 2024

Uh oh!

jieyouxu commented Aug 15, 2024

Uh oh!

estebank commented Aug 16, 2024

Uh oh!

bors commented Aug 16, 2024

Uh oh!

bors commented Aug 18, 2024

Uh oh!

bors commented Aug 18, 2024

Uh oh!

rust-timer commented Aug 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Uh oh!

Conversation

jieyouxu commented Aug 15, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Aug 15, 2024

Uh oh!

jieyouxu commented Aug 15, 2024

Uh oh!

jieyouxu commented Aug 15, 2024

Uh oh!

bors commented Aug 15, 2024

Uh oh!

bors commented Aug 15, 2024

Uh oh!

jieyouxu commented Aug 15, 2024

Uh oh!

estebank commented Aug 16, 2024

Uh oh!

bors commented Aug 16, 2024

Uh oh!

bors commented Aug 18, 2024

Uh oh!

bors commented Aug 18, 2024

Uh oh!

rust-timer commented Aug 18, 2024

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jieyouxu commented Aug 15, 2024•
edited
Loading