Uh oh!
There was an error while loading. Please reload this page.
rustdoc-json: Clean up serialization and printing. - #129191
Merged
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
rust-cloud-vmsBotforce-pushed
the
rdj-serial-cleanup
branch
from
August 17, 2024 11:00
7454c94 to
321d40fCompareGuillaumeGomez
approved these changes
Aug 17, 2024
GuillaumeGomez
commented
Aug 17, 2024
Member
Thanks! r=me once CI pass. |
aDotInTheVoid
commented
Aug 17, 2024
MemberAuthor
@bors r=GuillaumeGomez rollup |
bors
commented
Aug 17, 2024
Collaborator
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 17, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#128989 (Emit an error for invalid use of the linkage attribute) - rust-lang#129167 (mir/pretty: use `Option` instead of `Either<Once, Empty>`) - rust-lang#129168 (Return correct HirId when finding body owner in diagnostics) - rust-lang#129191 (rustdoc-json: Clean up serialization and printing.) - rust-lang#129192 (Remove useless attributes in merged doctest generated code) - rust-lang#129196 (Remove a useless ref/id/ref round-trip from `pattern_from_hir`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 17, 2024
Rollup merge of rust-lang#129191 - aDotInTheVoid:rdj-serial-cleanup, r=GuillaumeGomez rustdoc-json: Clean up serialization and printing. Somewhat a followup to rust-lang#128963, but makes sense regardless. - Renames `out_path` to `out_dir` because it's not the path to the JSON, but the directory - Also adds a comment explaining `None` - Renames `write` to `serialize_and_write` because it does both. - Also renames the self-profile activity name to be clear this measures both IO cost and serialization CPU cost - Expands the timer to cover flushing - Renames `output` to `output_crate`, to emphasize it's the contents, not the `--output` flag. r? `@GuillaumeGomez`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Somewhat a followup to #128963, but makes sense regardless.
out_pathtoout_dirbecause it's not the path to the JSON, but the directoryNonewritetoserialize_and_writebecause it does both.outputtooutput_crate, to emphasize it's the contents, not the--outputflag.r? @GuillaumeGomez