Skip to content

crashes: more tests - #129228

Merged
bors merged 1 commit into
rust-lang:masterfrom
matthiaskrgr:oopsie
Aug 19, 2024
Merged

crashes: more tests#129228
bors merged 1 commit into
rust-lang:masterfrom
matthiaskrgr:oopsie

Conversation

@matthiaskrgr

@matthiaskrgrmatthiaskrgr commented Aug 18, 2024

Copy link
Copy Markdown
Member

@rustbotrustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 18, 2024
jieyouxu
jieyouxu approved these changes Aug 18, 2024
View reviewed changes

@jieyouxujieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jieyouxu

jieyouxu commented Aug 18, 2024

Copy link
Copy Markdown
Member

@bors r+ rollup=iffy (crashes tests)

@bors

bors commented Aug 18, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit c001a3b has been approved by jieyouxu

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 18, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 18, 2024
@bors
Auto merge ofrust-lang#129228- matthiaskrgr:oopsie, r=jieyouxu
c7719a9
crashes: more tests
r? `@jieyouxu`
@bors

bors commented Aug 18, 2024

Copy link
Copy Markdown
Collaborator

⌛ Testing commit c001a3b with merge c7719a9...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors

bors commented Aug 18, 2024

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-actions

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 18, 2024
@jieyouxu

jieyouxu commented Aug 18, 2024

Copy link
Copy Markdown
Member

@bors r-

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 18, 2024
@matthiaskrgr

matthiaskrgr commented Aug 18, 2024

Copy link
Copy Markdown
MemberAuthor

right I was wondering if that would happen 😅
marked test as //@ only-x86_64
@bors r=jieyouxu

@bors

bors commented Aug 18, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit b8531e8 has been approved by jieyouxu

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 18, 2024
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Aug 18, 2024
@jieyouxu
Rollup merge ofrust-lang#129228- matthiaskrgr:oopsie, r=jieyouxu
2e243da
crashes: more tests
r? `@jieyouxu`
@jieyouxujieyouxu mentioned this pull request Aug 18, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 18, 2024
@bors
Auto merge ofrust-lang#129242- jieyouxu:rollup-1yhzl81, r=jieyouxu
88a596a
Rollup of 4 pull requests
Successful merges:
- rust-lang#128084 (Suggest adding Result return type for associated method in E0277.)
- rust-lang#129187 (bootstrap: fix clean's remove_dir_all implementation)
- rust-lang#129208 (Fix order of normalization and recursion in const folding.)
- rust-lang#129228 (crashes: more tests)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 18, 2024
@bors
Auto merge ofrust-lang#129228- matthiaskrgr:oopsie, r=jieyouxu
2062938
crashes: more tests
r? `@jieyouxu`
@bors

bors commented Aug 18, 2024

Copy link
Copy Markdown
Collaborator

⌛ Testing commit b8531e8 with merge 2062938...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors

bors commented Aug 18, 2024

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-actions

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 18, 2024
@matthiaskrgr

matthiaskrgr commented Aug 18, 2024

Copy link
Copy Markdown
MemberAuthor

weird that this would not crash on windows but on linux??

@matthiaskrgr

matthiaskrgr commented Aug 18, 2024

Copy link
Copy Markdown
MemberAuthor

@bors r=jieyouxu

@bors

bors commented Aug 18, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit 5fe70af has been approved by jieyouxu

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 18, 2024
@bors

bors commented Aug 19, 2024

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 5fe70af with merge 804be74...

@bors

bors commented Aug 19, 2024

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing 804be74 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Aug 19, 2024
@bors
bors merged commit 804be74 into rust-lang:masterAug 19, 2024
@rustbotrustbot added this to the 1.82.0 milestone Aug 19, 2024
@rust-timer

rust-timer commented Aug 19, 2024

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (804be74): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary 1.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		4.7%[4.7%, 4.7%]1
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		-2.5%[-2.5%, -2.5%]1
All ❌✅ (primary)--0

Cycles

Results (secondary -2.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		-2.3%[-2.4%, -2.1%]2
All ❌✅ (primary)--0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 751.219s -> 751.973s (0.10%)
Artifact size: 339.13 MiB -> 339.15 MiB (0.00%)

@matthiaskrgr
matthiaskrgr deleted the oopsie branch January 25, 2025 09:12
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieyouxujieyouxujieyouxu approved these changes

Assignees

@jieyouxujieyouxu

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.82.0

Development

Successfully merging this pull request may close these issues.

6 participants

@matthiaskrgr@jieyouxu@bors@rust-log-analyzer@rust-timer@rustbot