Uh oh!
There was an error while loading. Please reload this page.
Pretty-print own args of existential projections (dyn-Trait w/ GAT constraints) - #129395
Merged
Conversation
rustbot
commented
Aug 22, 2024
Collaborator
fmease
commented
Aug 22, 2024
Uh oh!
There was an error while loading. Please reload this page.
compiler-errors
approved these changes
Aug 22, 2024
compiler-errors
left a comment
Contributor
There was a problem hiding this comment.
r=me with a comment
fmeaseforce-pushed
the
pp-dyn-w-gat
branch
2 times, most recently
from
August 22, 2024 04:21
4cdaa97 to
43063ebComparefmease
commented
Aug 22, 2024
MemberAuthor
@bors r=compiler-errors rollup |
bors
commented
Aug 22, 2024
Collaborator
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 22, 2024
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#128432 (WASI: forbid `unsafe_op_in_unsafe_fn` for `std::{os, sys}`) - rust-lang#129373 (Add missing module flags for CFI and KCFI sanitizers) - rust-lang#129374 (Use `assert_unsafe_precondition!` in `AsciiChar::digit_unchecked`) - rust-lang#129376 (Change `assert_unsafe_precondition` docs to refer to `check_language_ub`) - rust-lang#129382 (Add `const_cell_into_inner` to `OnceCell`) - rust-lang#129387 (Advise against removing the remaining Python scripts from `tests/run-make`) - rust-lang#129388 (Do not rely on names to find lifetimes.) - rust-lang#129395 (Pretty-print own args of existential projections (dyn-Trait w/ GAT constraints)) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 22, 2024
Rollup merge of rust-lang#129395 - fmease:pp-dyn-w-gat, r=compiler-errors Pretty-print own args of existential projections (dyn-Trait w/ GAT constraints) Previously we would just drop them. This bug isn't that significant as it can only be triggered by user code that constrains GATs inside trait object types which is currently gated under the interim feature `generic_associated_types_extended` (whose future is questionable) or on stable if the GATs are 'disabled' in dyn-Trait via `where Self: Sized` (in which case the assoc type bindings get ignored anyway (and trigger the warn-by-default lint `unused_associated_type_bounds`)), so yeah. Affects diagnostic output and output of `std::any::type_name{_of_val}`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we would just drop them. This bug isn't that significant as it can only be triggered by user code that constrains GATs inside trait object types which is currently gated under the interim feature
generic_associated_types_extended(whose future is questionable) or on stable if the GATs are 'disabled' in dyn-Trait viawhere Self: Sized(in which case the assoc type bindings get ignored anyway (and trigger the warn-by-default lintunused_associated_type_bounds)), so yeah.Affects diagnostics and output of
std::any::type_name{,_of_val}.