Skip to content

interpret: ImmTy: tighten sanity checks in offset logic - #129505

Merged
bors merged 1 commit into
rust-lang:masterfrom
RalfJung:imm-ty-offset
Aug 25, 2024
Merged

interpret: ImmTy: tighten sanity checks in offset logic#129505
bors merged 1 commit into
rust-lang:masterfrom
RalfJung:imm-ty-offset

Conversation

@RalfJung

@RalfJungRalfJung commented Aug 24, 2024

Copy link
Copy Markdown
Member

Also make some debug assertions into assertions. (Will need to be perf'd.)

@rustbot

rustbot commented Aug 24, 2024

Copy link
Copy Markdown
Collaborator

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 24, 2024
@rustbot

rustbot commented Aug 24, 2024

Copy link
Copy Markdown
Collaborator

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

@RalfJung

RalfJung commented Aug 24, 2024

Copy link
Copy Markdown
MemberAuthor

@bors try
@rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbotrustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 24, 2024
@bors

bors commented Aug 24, 2024

Copy link
Copy Markdown
Collaborator

⌛ Trying commit 493cf6a with merge d7ce164...

bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 24, 2024
@bors
Auto merge ofrust-lang#129505- RalfJung:imm-ty-offset, r=<try>
d7ce164
interpret: ImmTy: tighten sanity checks in offset logic
Also make some debug assertions into assertions. (Will need to be perf'd.)
@bors

bors commented Aug 24, 2024

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-actions
Build commit: d7ce164 (d7ce16479a3ccc4e599ab114dda87fed1c98271d)

@rust-timer

This comment has been minimized.

Sign in to view
davidtwco
davidtwco approved these changes Aug 24, 2024
View reviewed changes

@davidtwcodavidtwco left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me if you are happy with perf

@rust-timer

rust-timer commented Aug 24, 2024

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (d7ce164): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		-0.8%[-1.2%, -0.2%]5
All ❌✅ (primary)--0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary -2.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		-2.5%[-2.7%, -2.4%]2
All ❌✅ (primary)--0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 750.628s -> 751.151s (0.07%)
Artifact size: 338.92 MiB -> 338.81 MiB (-0.03%)

@rustbotrustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 24, 2024
@RalfJung

RalfJung commented Aug 24, 2024

Copy link
Copy Markdown
MemberAuthor

Looking good. :)

@bors r=davidtwco rollup

@bors

bors commented Aug 24, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit 493cf6a has been approved by davidtwco

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 24, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 24, 2024
@matthiaskrgr
Rollup merge ofrust-lang#129505- RalfJung:imm-ty-offset, r=davidtwco
a0108d8
interpret: ImmTy: tighten sanity checks in offset logic
Also make some debug assertions into assertions. (Will need to be perf'd.)
@matthiaskrgrmatthiaskrgr mentioned this pull request Aug 24, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 24, 2024
@bors
Auto merge ofrust-lang#129516- matthiaskrgr:rollup-u13wr8q, r=matth…
dd51090
…iaskrgr
Rollup of 10 pull requests
Successful merges:
- rust-lang#128596 (stabilize const_fn_floating_point_arithmetic)
- rust-lang#129199 (make writes_through_immutable_pointer a hard error)
- rust-lang#129246 (Retroactively feature gate `ConstArgKind::Path`)
- rust-lang#129290 (Pin `cc` to 1.0.105)
- rust-lang#129323 (Implement `ptr::fn_addr_eq`)
- rust-lang#129500 (remove invalid `TyCompat` relation for effects)
- rust-lang#129501 (panicking: improve hint for Miri's RUST_BACKTRACE behavior)
- rust-lang#129505 (interpret: ImmTy: tighten sanity checks in offset logic)
- rust-lang#129509 (Add a hack to workaround MSVC CI issues)
- rust-lang#129510 (Fix `elided_named_lifetimes` in code)
r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgrmatthiaskrgr mentioned this pull request Aug 24, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 24, 2024
@bors
Auto merge ofrust-lang#129521- matthiaskrgr:rollup-uigv77m, r=matth…
313db53
…iaskrgr
Rollup of 9 pull requests
Successful merges:
- rust-lang#128596 (stabilize const_fn_floating_point_arithmetic)
- rust-lang#129199 (make writes_through_immutable_pointer a hard error)
- rust-lang#129246 (Retroactively feature gate `ConstArgKind::Path`)
- rust-lang#129290 (Pin `cc` to 1.0.105)
- rust-lang#129323 (Implement `ptr::fn_addr_eq`)
- rust-lang#129500 (remove invalid `TyCompat` relation for effects)
- rust-lang#129501 (panicking: improve hint for Miri's RUST_BACKTRACE behavior)
- rust-lang#129505 (interpret: ImmTy: tighten sanity checks in offset logic)
- rust-lang#129510 (Fix `elided_named_lifetimes` in code)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 25, 2024
@bors
Auto merge ofrust-lang#129521- matthiaskrgr:rollup-uigv77m, r=matth…
3557abf
…iaskrgr
Rollup of 9 pull requests
Successful merges:
- rust-lang#128596 (stabilize const_fn_floating_point_arithmetic)
- rust-lang#129199 (make writes_through_immutable_pointer a hard error)
- rust-lang#129246 (Retroactively feature gate `ConstArgKind::Path`)
- rust-lang#129290 (Pin `cc` to 1.0.105)
- rust-lang#129323 (Implement `ptr::fn_addr_eq`)
- rust-lang#129500 (remove invalid `TyCompat` relation for effects)
- rust-lang#129501 (panicking: improve hint for Miri's RUST_BACKTRACE behavior)
- rust-lang#129505 (interpret: ImmTy: tighten sanity checks in offset logic)
- rust-lang#129510 (Fix `elided_named_lifetimes` in code)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 25, 2024
@bors
Auto merge ofrust-lang#129521- matthiaskrgr:rollup-uigv77m, r=matth…
717aec0
…iaskrgr
Rollup of 9 pull requests
Successful merges:
- rust-lang#128596 (stabilize const_fn_floating_point_arithmetic)
- rust-lang#129199 (make writes_through_immutable_pointer a hard error)
- rust-lang#129246 (Retroactively feature gate `ConstArgKind::Path`)
- rust-lang#129290 (Pin `cc` to 1.0.105)
- rust-lang#129323 (Implement `ptr::fn_addr_eq`)
- rust-lang#129500 (remove invalid `TyCompat` relation for effects)
- rust-lang#129501 (panicking: improve hint for Miri's RUST_BACKTRACE behavior)
- rust-lang#129505 (interpret: ImmTy: tighten sanity checks in offset logic)
- rust-lang#129510 (Fix `elided_named_lifetimes` in code)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 9e1f628 into rust-lang:masterAug 25, 2024
@rustbotrustbot added this to the 1.82.0 milestone Aug 25, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Aug 25, 2024
@rust-timer
Unrolled build forrust-lang#129505
ea268e1
Rollup merge of rust-lang#129505 - RalfJung:imm-ty-offset, r=davidtwco
interpret: ImmTy: tighten sanity checks in offset logic
Also make some debug assertions into assertions. (Will need to be perf'd.)
@RalfJung
RalfJung deleted the imm-ty-offset branch August 25, 2024 11:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidtwcodavidtwcodavidtwco approved these changes

Assignees

@davidtwcodavidtwco

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.82.0

Development

Successfully merging this pull request may close these issues.

5 participants

@RalfJung@rustbot@rust-timer@bors@davidtwco