Skip to content

Prereq4 for async drop - needs_async_drop query fixes and some cleanup - #129739

Closed
azhogin wants to merge 4 commits into
rust-lang:masterfrom
azhogin:azhogin/async-drop-prereq4-needs-async-drop-fixes-and-cleanup
Closed

Prereq4 for async drop - needs_async_drop query fixes and some cleanup#129739
azhogin wants to merge 4 commits into
rust-lang:masterfrom
azhogin:azhogin/async-drop-prereq4-needs-async-drop-fixes-and-cleanup

Conversation

@azhogin

@azhoginazhogin commented Aug 29, 2024

Copy link
Copy Markdown
Contributor

This is subpart 4 PR of #123948, just for review purposes.

is_async_drop query added, small needs_async_drop fixes and previous async drop glue implementation cleanup.
is_async_drop for detection of type implementing AsyncDrop trait itself, needs_async_drop for detection if a complex type have some internals implementing AsyncDrop and requires async drop glue for itself.

Review only last commit, based on previous PR #129737.

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Aug 29, 2024
@rustbot

rustbot commented Aug 29, 2024

Copy link
Copy Markdown
Collaborator

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

This PR changes MIR

cc @oli-obk, @RalfJung, @JakobDegen, @davidtwco, @celinval, @vakaras

This PR changes Stable MIR

cc @oli-obk, @celinval, @ouz-a

@azhoginazhogin mentioned this pull request Aug 29, 2024
Closed
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@azhoginazhogin mentioned this pull request Aug 29, 2024
Merged
@azhogin
azhoginforce-pushed the azhogin/async-drop-prereq4-needs-async-drop-fixes-and-cleanup branch from b667246 to ccf830aCompareAugust 30, 2024 07:33
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@azhogin
azhoginforce-pushed the azhogin/async-drop-prereq4-needs-async-drop-fixes-and-cleanup branch from ccf830a to b193d6aCompareAugust 30, 2024 09:01
@azhogin
azhogin marked this pull request as draft August 30, 2024 09:09
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors

bors commented Aug 31, 2024

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #129817) made this pull request unmergeable. Please resolve the merge conflicts.

@azhogin
azhoginforce-pushed the azhogin/async-drop-prereq4-needs-async-drop-fixes-and-cleanup branch 2 times, most recently from e0d8585 to aa7c159CompareSeptember 7, 2024 14:33
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@azhogin
azhoginforce-pushed the azhogin/async-drop-prereq4-needs-async-drop-fixes-and-cleanup branch from aa7c159 to 2d5cad6CompareSeptember 7, 2024 16:19
@bors

bors commented Sep 8, 2024

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #129313) made this pull request unmergeable. Please resolve the merge conflicts.

@azhogin
azhoginforce-pushed the azhogin/async-drop-prereq4-needs-async-drop-fixes-and-cleanup branch from 2d5cad6 to 81c51d9CompareSeptember 8, 2024 12:03
@bors

bors commented Sep 9, 2024

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #130165) made this pull request unmergeable. Please resolve the merge conflicts.

@davidtwco

davidtwco commented Oct 1, 2024

Copy link
Copy Markdown
Member

r? @nikomatsakis is going to look into this

@rustbotrustbot assigned nikomatsakis and unassigned davidtwcoOct 1, 2024
@azhogin
azhoginforce-pushed the azhogin/async-drop-prereq4-needs-async-drop-fixes-and-cleanup branch from 81c51d9 to 2b693c0CompareFebruary 9, 2025 13:51
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors

bors commented Feb 9, 2025

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #136751) made this pull request unmergeable. Please resolve the merge conflicts.

@azhogin
azhoginforce-pushed the azhogin/async-drop-prereq4-needs-async-drop-fixes-and-cleanup branch 2 times, most recently from fca16b3 to 4efe2f2CompareFebruary 10, 2025 14:43
@bors

bors commented Feb 12, 2025

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #136943) made this pull request unmergeable. Please resolve the merge conflicts.

@azhogin
azhoginforce-pushed the azhogin/async-drop-prereq4-needs-async-drop-fixes-and-cleanup branch from 4efe2f2 to 0da1dc0CompareMarch 30, 2025 17:07
@bors

bors commented Apr 4, 2025

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #139354) made this pull request unmergeable. Please resolve the merge conflicts.

@azhogin
azhoginforce-pushed the azhogin/async-drop-prereq4-needs-async-drop-fixes-and-cleanup branch from 0da1dc0 to 85f10baCompareApril 6, 2025 08:01
@azhogin
azhoginforce-pushed the azhogin/async-drop-prereq4-needs-async-drop-fixes-and-cleanup branch from 85f10ba to b1f3a6eCompareApril 6, 2025 10:04
@bors

bors commented Apr 11, 2025

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #139578) made this pull request unmergeable. Please resolve the merge conflicts.

@oli-obkoli-obk closed this Apr 11, 2025
@petrochenkovpetrochenkov added the F-async_drop `#![feature(async_drop)]` label Jun 6, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nikomatsakisnikomatsakis

Labels

F-async_drop`#![feature(async_drop)]`S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.WG-trait-system-refactorThe Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@azhogin@rustbot@rust-log-analyzer@bors@davidtwco@nikomatsakis@oli-obk@petrochenkov