Skip to content

Add a test for trait solver overflow in MIR inliner cycle detection - #129757

Merged
bors merged 1 commit into
rust-lang:masterfrom
saethlin:half-a-recursion
Aug 31, 2024
Merged

Add a test for trait solver overflow in MIR inliner cycle detection#129757
bors merged 1 commit into
rust-lang:masterfrom
saethlin:half-a-recursion

Conversation

@saethlin

@saethlinsaethlin commented Aug 29, 2024

Copy link
Copy Markdown
Member

This test is a combination of the reproducer posted here: #128887 (comment) and the existing test for polymorphic recursion: https://github.com/rust-lang/rust/blob/784d444733d65c3d305ce5edcbb41e3d0d0aee2e/tests/mir-opt/inline/polymorphic_recursion.rs

r? @compiler-errors

@rustbotrustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 29, 2024
@compiler-errors

compiler-errors commented Aug 29, 2024

Copy link
Copy Markdown
Contributor

thank, i really appreciate the time you took to actually turn this into a test

@bors r+ rollup

@bors

bors commented Aug 29, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit a625aa5 has been approved by compiler-errors

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 29, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@saethlin

saethlin commented Aug 29, 2024

Copy link
Copy Markdown
MemberAuthor

@bors r=compiler-errors

@bors

bors commented Aug 29, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit c71ede3 has been approved by compiler-errors

It is now in the queue for this repository.

@compiler-errors

compiler-errors commented Aug 29, 2024

Copy link
Copy Markdown
Contributor

@bors r- let's see ci happy

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 29, 2024
@saethlinsaethlin added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 30, 2024
@saethlin

saethlin commented Aug 30, 2024

Copy link
Copy Markdown
MemberAuthor

CI is happy
@bors r=compiler-errors

@bors

bors commented Aug 30, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit c71ede3 has been approved by compiler-errors

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 30, 2024
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Aug 31, 2024
@workingjubilee
Rollup merge ofrust-lang#129757- saethlin:half-a-recursion, r=compi…
b28c987
…ler-errors
Add a test for trait solver overflow in MIR inliner cycle detection
This test is a combination of the reproducer posted here: rust-lang#128887 (comment) and the existing test for polymorphic recursion: https://github.com/rust-lang/rust/blob/784d444733d65c3d305ce5edcbb41e3d0d0aee2e/tests/mir-opt/inline/polymorphic_recursion.rs
r? `@compiler-errors`
@workingjubileeworkingjubilee mentioned this pull request Aug 31, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 31, 2024
@bors
Auto merge ofrust-lang#129802- workingjubilee:rollup-kjgatqm, r=wor…
d186e16
…kingjubilee
Rollup of 16 pull requests
Successful merges:
- rust-lang#129123 (rustdoc-json: Add test for `Self` type)
- rust-lang#129675 (allow BufReader::peek to be called on unsized types)
- rust-lang#129678 (Deny imports of `rustc_type_ir::inherent` outside of type ir + new trait solver)
- rust-lang#129723 (Simplify some extern providers)
- rust-lang#129724 (Remove `Option<!>` return types.)
- rust-lang#129725 (Stop using `ty::GenericPredicates` for non-predicates_of queries)
- rust-lang#129730 (f32 docs: define 'arithmetic' operations)
- rust-lang#129749 (llvm-wrapper: adapt for LLVM API changes)
- rust-lang#129757 (Add a test for trait solver overflow in MIR inliner cycle detection)
- rust-lang#129760 (Make the "detect-old-time" UI test more representative)
- rust-lang#129762 (Update the `wasm-component-ld` binary dependency)
- rust-lang#129767 (Remove `#[macro_use] extern crate tracing`, round 4)
- rust-lang#129774 (Remove `#[macro_use] extern crate tracing` from rustdoc and rustfmt)
- rust-lang#129780 (add crashtests for several old unfixed ICEs)
- rust-lang#129782 (couple more crash tests)
- rust-lang#129791 (mark joboet as on vacation)
r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 31, 2024
@matthiaskrgr
Rollup merge ofrust-lang#129757- saethlin:half-a-recursion, r=compi…
10b65c0
…ler-errors
Add a test for trait solver overflow in MIR inliner cycle detection
This test is a combination of the reproducer posted here: rust-lang#128887 (comment) and the existing test for polymorphic recursion: https://github.com/rust-lang/rust/blob/784d444733d65c3d305ce5edcbb41e3d0d0aee2e/tests/mir-opt/inline/polymorphic_recursion.rs
r? ``@compiler-errors``
@matthiaskrgrmatthiaskrgr mentioned this pull request Aug 31, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 31, 2024
@bors
Auto merge ofrust-lang#129810- matthiaskrgr:rollup-ftlptye, r=matth…
98c77d7
…iaskrgr
Rollup of 11 pull requests
Successful merges:
- rust-lang#129630 (Document the broken C ABI of `wasm32-unknown-unknown`)
- rust-lang#129711 (Expand NLL MIR dumps)
- rust-lang#129730 (f32 docs: define 'arithmetic' operations)
- rust-lang#129733 (Subtree update of `rust-analyzer`)
- rust-lang#129749 (llvm-wrapper: adapt for LLVM API changes)
- rust-lang#129757 (Add a test for trait solver overflow in MIR inliner cycle detection)
- rust-lang#129760 (Make the "detect-old-time" UI test more representative)
- rust-lang#129767 (Remove `#[macro_use] extern crate tracing`, round 4)
- rust-lang#129774 (Remove `#[macro_use] extern crate tracing` from rustdoc and rustfmt)
- rust-lang#129785 (Miri subtree update)
- rust-lang#129791 (mark joboet as on vacation)
Failed merges:
- rust-lang#129777 (Add `unreachable_pub`, round 4)
r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgrmatthiaskrgr mentioned this pull request Aug 31, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 31, 2024
@bors
Auto merge ofrust-lang#129817- matthiaskrgr:rollup-ll2ld5m, r=matth…
3f329d5
…iaskrgr
Rollup of 12 pull requests
Successful merges:
- rust-lang#129659 (const fn stability checking: also check declared language features)
- rust-lang#129711 (Expand NLL MIR dumps)
- rust-lang#129730 (f32 docs: define 'arithmetic' operations)
- rust-lang#129733 (Subtree update of `rust-analyzer`)
- rust-lang#129749 (llvm-wrapper: adapt for LLVM API changes)
- rust-lang#129757 (Add a test for trait solver overflow in MIR inliner cycle detection)
- rust-lang#129760 (Make the "detect-old-time" UI test more representative)
- rust-lang#129767 (Remove `#[macro_use] extern crate tracing`, round 4)
- rust-lang#129774 (Remove `#[macro_use] extern crate tracing` from rustdoc and rustfmt)
- rust-lang#129785 (Miri subtree update)
- rust-lang#129791 (mark joboet as on vacation)
- rust-lang#129812 (interpret, codegen: tweak some comments and checks regarding Box with custom allocator)
Failed merges:
- rust-lang#129777 (Add `unreachable_pub`, round 4)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 31, 2024
@bors
Auto merge ofrust-lang#129817- matthiaskrgr:rollup-ll2ld5m, r=matth…
d571ae8
…iaskrgr
Rollup of 12 pull requests
Successful merges:
- rust-lang#129659 (const fn stability checking: also check declared language features)
- rust-lang#129711 (Expand NLL MIR dumps)
- rust-lang#129730 (f32 docs: define 'arithmetic' operations)
- rust-lang#129733 (Subtree update of `rust-analyzer`)
- rust-lang#129749 (llvm-wrapper: adapt for LLVM API changes)
- rust-lang#129757 (Add a test for trait solver overflow in MIR inliner cycle detection)
- rust-lang#129760 (Make the "detect-old-time" UI test more representative)
- rust-lang#129767 (Remove `#[macro_use] extern crate tracing`, round 4)
- rust-lang#129774 (Remove `#[macro_use] extern crate tracing` from rustdoc and rustfmt)
- rust-lang#129785 (Miri subtree update)
- rust-lang#129791 (mark joboet as on vacation)
- rust-lang#129812 (interpret, codegen: tweak some comments and checks regarding Box with custom allocator)
Failed merges:
- rust-lang#129777 (Add `unreachable_pub`, round 4)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 6b9ed71 into rust-lang:masterAug 31, 2024
@rustbotrustbot added this to the 1.82.0 milestone Aug 31, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Aug 31, 2024
@rust-timer
Unrolled build forrust-lang#129757
0157c37
Rollup merge of rust-lang#129757 - saethlin:half-a-recursion, r=compiler-errors
Add a test for trait solver overflow in MIR inliner cycle detection
This test is a combination of the reproducer posted here: rust-lang#128887 (comment) and the existing test for polymorphic recursion: https://github.com/rust-lang/rust/blob/784d444733d65c3d305ce5edcbb41e3d0d0aee2e/tests/mir-opt/inline/polymorphic_recursion.rs
r? ```@compiler-errors```
@saethlin
saethlin deleted the half-a-recursion branch August 31, 2024 21:56
lqd added a commit to lqd/rust that referenced this pull request Sep 1, 2024
@lqd
Revert "Rollup merge ofrust-lang#129757- saethlin:half-a-recursion,…
9af460b
… r=compiler-errors"
This reverts commit 6b9ed71, reversing
changes made to 8c7a7e3.
@theemathastheemathas mentioned this pull request Oct 20, 2024
Open
@theemathastheemathas mentioned this pull request Sep 23, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@compiler-errorscompiler-errors

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.82.0

Development

Successfully merging this pull request may close these issues.

5 participants

@saethlin@compiler-errors@bors@rust-log-analyzer@rustbot