Uh oh!
There was an error while loading. Please reload this page.
miri-test-libstd: add missing BOOTSTRAP_ARGS - #130143
Merged
Merged
Conversation
also don't unnecessarily set BOOTSTRAP_SKIP_TARGET_SANITY while we are at it
rustbot
commented
Sep 9, 2024
Collaborator
rustbot has assigned @albertlarsan68. Use |
compiler-errors
left a comment
Contributor
There was a problem hiding this comment.
The side-effect of this is to pass -v to these x.py miri invocations, so all it will be is more verbose. Seems fine to me.
compiler-errors
commented
Sep 10, 2024
Contributor
r? compiler-errors @bors r+ rollup |
bors
commented
Sep 10, 2024
Collaborator
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 10, 2024
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#130143 (miri-test-libstd: add missing BOOTSTRAP_ARGS) - rust-lang#130173 (rustdoc: add two regression tests) - rust-lang#130175 (`rustc_mir_transform` cleanups 3) - rust-lang#130184 (coverage: Clean up terminology in counter creation) - rust-lang#130185 (abi/compatibility test: remove tests inside repr(C) wrappers) r? `@ghost` `@rustbot` modify labels: rollup
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 10, 2024
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#130143 (miri-test-libstd: add missing BOOTSTRAP_ARGS) - rust-lang#130173 (rustdoc: add two regression tests) - rust-lang#130175 (`rustc_mir_transform` cleanups 3) - rust-lang#130184 (coverage: Clean up terminology in counter creation) - rust-lang#130185 (abi/compatibility test: remove tests inside repr(C) wrappers) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 10, 2024
Rollup merge of rust-lang#130143 - RalfJung:miri-test-libstd, r=compiler-errors miri-test-libstd: add missing BOOTSTRAP_ARGS Note sure if BOOTSTRAP_ARGS will make any difference here, but all the other x.py invocations have it and I did not *deliberately* leave it away when I added these, so... probably best to add them? Also don't unnecessarily set BOOTSTRAP_SKIP_TARGET_SANITY while we are at it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note sure if BOOTSTRAP_ARGS will make any difference here, but all the other x.py invocations have it and I did not deliberately leave it away when I added these, so... probably best to add them?
Also don't unnecessarily set BOOTSTRAP_SKIP_TARGET_SANITY while we are at it.