Uh oh!
There was an error while loading. Please reload this page.
unstable feature usage metrics - #130236
Conversation
rustbot
commented
Sep 11, 2024
This comment has been minimized.
This comment has been minimized.
25ee72d to
06b95b2Compare
This comment has been minimized.
This comment has been minimized.
06b95b2 to
29fcb25Compare
This comment has been minimized.
This comment has been minimized.
29fcb25 to
28d9d1bCompare
This comment has been minimized.
This comment has been minimized.
yaahc
commented
Sep 24, 2024
r? @estebank |
Uh oh!
There was an error while loading. Please reload this page.
28d9d1b to
3addcf4Compare
This comment has been minimized.
This comment has been minimized.
9ca273b to
cd70825Compare
This comment has been minimized.
This comment has been minimized.
cd70825 to
137db8dCompare
This comment has been minimized.
This comment has been minimized.
b0fcb24 to
3cf1bb8Comparerustbot
commented
Nov 15, 2024
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. This PR modifies cc @jieyouxu |
3cf1bb8 to
35bfeffCompare
This comment has been minimized.
This comment has been minimized.
35bfeff to
5d8de54Compare
This comment has been minimized.
This comment has been minimized.
5d8de54 to
9dd032fCompare
This comment has been minimized.
This comment has been minimized.
9dd032f to
5a05655Compare
This comment has been minimized.
This comment has been minimized.
5a05655 to
609925fCompare609925f to
dc97db1CompareUh oh!
There was an error while loading. Please reload this page.
| .arg("-Zmetrics-dir=invaliddirectorythatdefinitelydoesntexist") | ||
| .run_fail() | ||
| .assert_stderr_contains( | ||
| "error: cannot dump feature usage metrics: No such file or directory", |
There was a problem hiding this comment.
Because we use dyn Error/IOError we don't display the file path that we couldn't open. That's not ideal but ok for now. Let's revisit in the future.
Co-authored-by: Esteban Kuber <estebank@users.noreply.github.com>
yaahc
commented
Nov 20, 2024
@bors r=estebank |
estebank
commented
Nov 20, 2024
@bors r+ |
yaahc
commented
Nov 20, 2024
@bors r=estebank |
bors
commented
Nov 20, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#130236 (unstable feature usage metrics) - rust-lang#131544 (Make asm label blocks safe context) - rust-lang#131586 (Support s390x z13 vector ABI) - rust-lang#132489 (Fix closure arg extraction in `extract_callable_info`, generalize it to async closures) - rust-lang#133078 (tests: ui/inline-consts: add issue number to a test, rename other tests) - rust-lang#133283 (Don't exclude relnotes from `needs-triage` label) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#130236 - yaahc:unstable-feature-usage, r=estebank unstable feature usage metrics example output ``` test-lib on master [?] is 📦 v0.1.0 via 🦀 v1.80.1 ❯ cat src/lib.rs ───────┬─────────────────────────────────────────────────────── │ File: src/lib.rs ───────┼─────────────────────────────────────────────────────── 1 │ #![feature(unix_set_mark)] 2 │ pub fn add(left: u64, right: u64) -> u64 { 3 │ left + right 4 │ } 5 │ 6 │ #[cfg(test)] 7 │ mod tests { 8 │ use super::*; 9 │ 10 │ #[test] 11 │ fn it_works() { 12 │ let result = add(2, 2); 13 │ assert_eq!(result, 4); 14 │ } 15 │ } ───────┴─────────────────────────────────────────────────────── test-lib on master [?] is 📦 v0.1.0 via 🦀 v1.80.1 ❯ cargo +stage1 rustc -- -Zmetrics-dir=$PWD/metrics Compiling test-lib v0.1.0 (/home/yaahc/tmp/test-lib) Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.08s test-lib on master [?] is 📦 v0.1.0 via 🦀 v1.80.1 ❯ cat metrics/unstable_feature_usage.json ───────┬───────────────────────────────────────────────────────────────────── │ File: metrics/unstable_feature_usage.json ───────┼───────────────────────────────────────────────────────────────────── 1 │ {"lib_features":[{"symbol":"unix_set_mark"}],"lang_features":[]} ``` related to rust-lang#129485
example output
related to #129485