Uh oh!
There was an error while loading. Please reload this page.
compiler: Document AbiAndPrefAlign - #130384
Merged
bors merged 1 commit intoSep 15, 2024
Merged
Conversation
rustbot
commented
Sep 15, 2024
Collaborator
compiler-errors
approved these changes
Sep 15, 2024
compiler-errors
commented
Sep 15, 2024
Contributor
r? compiler-errors @bors r+ rollup |
bors
commented
Sep 15, 2024
Collaborator
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 15, 2024
…iaskrgr Rollup of 3 pull requests Successful merges: - rust-lang#129897 (deprecate -Csoft-float because it is unsound (and not fixable)) - rust-lang#130339 (Add `core::panic::abort_unwind`) - rust-lang#130384 (compiler: Document AbiAndPrefAlign) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 15, 2024
Rollup merge of rust-lang#130384 - workingjubilee:document-what-abi-and-pref-align-is, r=compiler-errors compiler: Document AbiAndPrefAlign The mere existence of this struct is confusing, and the second field doubly so. It's easy to mistake the "preferred" alignment as semantically relevant somehow. Insofar as I am aware, it is not, and certainly not for Rust code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mere existence of this struct is confusing, and the second field doubly so. It's easy to mistake the "preferred" alignment as semantically relevant somehow. Insofar as I am aware, it is not, and certainly not for Rust code.