Uh oh!
There was an error while loading. Please reload this page.
Don't ICE when generating Fn shim for async closure with borrowck error - #130410
Merged
Conversation
rustbot
commented
Sep 15, 2024
Collaborator
rustbot
commented
Sep 15, 2024
Collaborator
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
jieyouxu
approved these changes
Sep 16, 2024
jieyouxu
left a comment
Member
There was a problem hiding this comment.
Thanks, this seems reasonable.
jieyouxu
commented
Sep 16, 2024
Member
@bors r+ rollup |
bors
commented
Sep 16, 2024
Collaborator
compiler-errors
commented
Sep 16, 2024
ContributorAuthor
compiler-errorsforce-pushed
the
shim-borrowck-err
branch
from
September 16, 2024 14:58
21b740b to
57a7e51Comparecompiler-errors
commented
Sep 16, 2024
ContributorAuthor
@bors r=jieyouxu |
bors
commented
Sep 16, 2024
Collaborator
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 16, 2024
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#123436 (linker: Allow MSVC to use import libraries following the Meson/MinGW convention) - rust-lang#130410 (Don't ICE when generating `Fn` shim for async closure with borrowck error) - rust-lang#130412 (Don't ICE when RPITIT captures more method args than trait definition) - rust-lang#130436 (Ignore reduce-fadd-unordered on SGX platform) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 16, 2024
Rollup merge of rust-lang#130410 - compiler-errors:shim-borrowck-err, r=jieyouxu Don't ICE when generating `Fn` shim for async closure with borrowck error Turn an assumption that I had originally written as an assert into a delayed bug, because this shim code is reachable even if we have borrowck errors via the MIR inliner. Fixesrust-lang#129262.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turn an assumption that I had originally written as an assert into a delayed bug, because this shim code is reachable even if we have borrowck errors via the MIR inliner.
Fixes#129262.