Skip to content

Fix scraped examples height - #130619

Merged
bors merged 4 commits into
rust-lang:masterfrom
GuillaumeGomez:scraped-examples-height
Sep 20, 2024
Merged

Fix scraped examples height#130619
bors merged 4 commits into
rust-lang:masterfrom
GuillaumeGomez:scraped-examples-height

Conversation

@GuillaumeGomez

Copy link
Copy Markdown
Member

Fixes#130562.

You can test it here.

I also used this opportunity to reduce the padding on line numbers:

beforeafter
Screenshot from 2024-09-20 16-20-40Screenshot from 2024-09-20 16-20-13

r? @notriddle

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Sep 20, 2024
@GuillaumeGomezGuillaumeGomez changed the title Scraped examples heightFixe scraped examples heightSep 20, 2024
@rustbot

Copy link
Copy Markdown
Collaborator

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @jsha

@GuillaumeGomezGuillaumeGomez changed the title Fixe scraped examples heightFix scraped examples heightSep 20, 2024
@notriddle

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Sep 20, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit 55058b6 has been approved by notriddle

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 20, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 20, 2024
…llaumeGomez
Rollup of 7 pull requests
Successful merges:
- rust-lang#128209 (Remove macOS 10.10 dynamic linker bug workaround)
- rust-lang#130526 (Begin experimental support for pin reborrowing)
- rust-lang#130611 (Address diagnostics regression for `const_char_encode_utf8`.)
- rust-lang#130614 (Add arm64e-apple-tvos target)
- rust-lang#130617 (bail if there are too many non-region infer vars in the query response)
- rust-lang#130619 (Fix scraped examples height)
- rust-lang#130624 (Add `Vec::as_non_null`)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 5708062 into rust-lang:masterSep 20, 2024
@rustbotrustbot added this to the 1.83.0 milestone Sep 20, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 20, 2024
Rollup merge of rust-lang#130619 - GuillaumeGomez:scraped-examples-height, r=notriddle
Fix scraped examples height
Fixes [rust-lang#130562](rust-lang#130562).
You can test it [here](https://rustdoc.crud.net/imperio/scraped-examples-height/doc/scrape_examples/fn.test_many.html).
I also used this opportunity to reduce the padding on line numbers:
| before | after |
| - | - |
| ![Screenshot from 2024-09-20 16-20-40](https://github.com/user-attachments/assets/9434704c-afe0-4ec3-a1dc-6f3c16d03b3b) | ![Screenshot from 2024-09-20 16-20-13](https://github.com/user-attachments/assets/f3bd01bf-760a-4acd-ba34-8e7db083245a) |
r? `@notriddle`
@GuillaumeGomez
GuillaumeGomez deleted the scraped-examples-height branch September 20, 2024 22:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

extra scraped examples height was changed without noticed

4 participants

@GuillaumeGomez@rustbot@notriddle@bors