Assert that `explicit_super_predicates_of` and `explicit_item_super_predicates` truly only contains bounds for the type itself by compiler-errors · Pull Request #130666 · rust-lang/rust

compiler-errors · 2024-09-21T15:45:00Z

We distinguish implied predicates (anything that is implied from elaborating a trait bound) from super predicates, which are are the subset of implied predicates that share the same self type as the trait predicate we're elaborating. This was originally done in #107614, which fixed a large class of ICEs and strange errors where the compiler expected the self type of a trait predicate not to change when elaborating super predicates.

Specifically, super predicates are special for various reasons: they're the valid candidates for trait upcasting, are the only predicates we elaborate when doing closure signature inference, etc. So making sure that we get this list correct and don't accidentally "leak" any other predicates into this list is quite important.

This PR adds some debug assertions that we're in fact not doing so, and it fixes an oversight in the effect desugaring rework.

rustbot · 2024-09-21T15:45:08Z

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2024-09-21T15:45:10Z

HIR ty lowering was modified

cc @fmease

fee1-dead

LGTM

fee1-dead · 2024-09-21T16:03:31Z

@bors r+
r? @fee1-dead

bors · 2024-09-21T16:03:34Z

📌 Commit 55db3ff has been approved by fee1-dead

It is now in the queue for this repository.

…ly only bounds for the type itself

…ally collecting implied bounds, not super bounds

compiler-errors · 2024-09-21T16:24:40Z

@bors r=fee1-dead,fmease rollup

bors · 2024-09-21T16:24:43Z

📌 Commit 4f3d06f has been approved by fee1-dead,fmease

It is now in the queue for this repository.

…e1-dead,fmease Assert that `explicit_super_predicates_of` and `explicit_item_super_predicates` truly only contains bounds for the type itself We distinguish _implied_ predicates (anything that is implied from elaborating a trait bound) from _super_ predicates, which are are the subset of implied predicates that share the same self type as the trait predicate we're elaborating. This was originally done in rust-lang#107614, which fixed a large class of ICEs and strange errors where the compiler expected the self type of a trait predicate not to change when elaborating super predicates. Specifically, super predicates are special for various reasons: they're the valid candidates for trait upcasting, are the only predicates we elaborate when doing closure signature inference, etc. So making sure that we get this list correct and don't accidentally "leak" any other predicates into this list is quite important. This PR adds some debug assertions that we're in fact not doing so, and it fixes an oversight in the effect desugaring rework.

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#127766 (add `extern "C-cmse-nonsecure-entry" fn` ) - rust-lang#129629 (Implement Return Type Notation (RTN)'s path form in where clauses) - rust-lang#130246 (rustc_expand: remember module `#[path]`s during expansion) - rust-lang#130408 (Avoid re-validating UTF-8 in `FromUtf8Error::into_utf8_lossy`) - rust-lang#130651 (Add --enable-profiler to armhf dist) - rust-lang#130653 (ABI compatibility: mention Result guarantee) - rust-lang#130665 (Prevent Deduplication of `LongRunningWarn`) - rust-lang#130666 (Assert that `explicit_super_predicates_of` and `explicit_item_super_predicates` truly only contains bounds for the type itself) - rust-lang#130667 (compiler: Accept "improper" ctypes in extern "rust-cold" fn) r? `@ghost` `@rustbot` modify labels: rollup

…mpiler-errors Rollup of 8 pull requests Successful merges: - rust-lang#127766 (add `extern "C-cmse-nonsecure-entry" fn` ) - rust-lang#129629 (Implement Return Type Notation (RTN)'s path form in where clauses) - rust-lang#130408 (Avoid re-validating UTF-8 in `FromUtf8Error::into_utf8_lossy`) - rust-lang#130651 (Add --enable-profiler to armhf dist) - rust-lang#130653 (ABI compatibility: mention Result guarantee) - rust-lang#130666 (Assert that `explicit_super_predicates_of` and `explicit_item_super_predicates` truly only contains bounds for the type itself) - rust-lang#130667 (compiler: Accept "improper" ctypes in extern "rust-cold" fn) - rust-lang#130673 (Parser: recover from `:::` to `::`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#130666 - compiler-errors:super-bounds, r=fee1-dead,fmease Assert that `explicit_super_predicates_of` and `explicit_item_super_predicates` truly only contains bounds for the type itself We distinguish _implied_ predicates (anything that is implied from elaborating a trait bound) from _super_ predicates, which are are the subset of implied predicates that share the same self type as the trait predicate we're elaborating. This was originally done in rust-lang#107614, which fixed a large class of ICEs and strange errors where the compiler expected the self type of a trait predicate not to change when elaborating super predicates. Specifically, super predicates are special for various reasons: they're the valid candidates for trait upcasting, are the only predicates we elaborate when doing closure signature inference, etc. So making sure that we get this list correct and don't accidentally "leak" any other predicates into this list is quite important. This PR adds some debug assertions that we're in fact not doing so, and it fixes an oversight in the effect desugaring rework.

compiler-errors · 2024-09-21T15:45:00Z

We distinguish implied predicates (anything that is implied from elaborating a trait bound) from super predicates, which are are the subset of implied predicates that share the same self type as the trait predicate we're elaborating. This was originally done in #107614, which fixed a large class of ICEs and strange errors where the compiler expected the self type of a trait predicate not to change when elaborating super predicates.

Specifically, super predicates are special for various reasons: they're the valid candidates for trait upcasting, are the only predicates we elaborate when doing closure signature inference, etc. So making sure that we get this list correct and don't accidentally "leak" any other predicates into this list is quite important.

This PR adds some debug assertions that we're in fact not doing so, and it fixes an oversight in the effect desugaring rework.

rustbot · 2024-09-21T15:45:08Z

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2024-09-21T15:45:10Z

HIR ty lowering was modified

cc @fmease

fee1-dead

LGTM

fee1-dead · 2024-09-21T16:03:31Z

@bors r+
r? @fee1-dead

bors · 2024-09-21T16:03:34Z

📌 Commit 55db3ff has been approved by fee1-dead

It is now in the queue for this repository.

…ly only bounds for the type itself

…ally collecting implied bounds, not super bounds

compiler-errors · 2024-09-21T16:24:40Z

@bors r=fee1-dead,fmease rollup

bors · 2024-09-21T16:24:43Z

📌 Commit 4f3d06f has been approved by fee1-dead,fmease

It is now in the queue for this repository.

…e1-dead,fmease Assert that `explicit_super_predicates_of` and `explicit_item_super_predicates` truly only contains bounds for the type itself We distinguish _implied_ predicates (anything that is implied from elaborating a trait bound) from _super_ predicates, which are are the subset of implied predicates that share the same self type as the trait predicate we're elaborating. This was originally done in rust-lang#107614, which fixed a large class of ICEs and strange errors where the compiler expected the self type of a trait predicate not to change when elaborating super predicates. Specifically, super predicates are special for various reasons: they're the valid candidates for trait upcasting, are the only predicates we elaborate when doing closure signature inference, etc. So making sure that we get this list correct and don't accidentally "leak" any other predicates into this list is quite important. This PR adds some debug assertions that we're in fact not doing so, and it fixes an oversight in the effect desugaring rework.

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#127766 (add `extern "C-cmse-nonsecure-entry" fn` ) - rust-lang#129629 (Implement Return Type Notation (RTN)'s path form in where clauses) - rust-lang#130246 (rustc_expand: remember module `#[path]`s during expansion) - rust-lang#130408 (Avoid re-validating UTF-8 in `FromUtf8Error::into_utf8_lossy`) - rust-lang#130651 (Add --enable-profiler to armhf dist) - rust-lang#130653 (ABI compatibility: mention Result guarantee) - rust-lang#130665 (Prevent Deduplication of `LongRunningWarn`) - rust-lang#130666 (Assert that `explicit_super_predicates_of` and `explicit_item_super_predicates` truly only contains bounds for the type itself) - rust-lang#130667 (compiler: Accept "improper" ctypes in extern "rust-cold" fn) r? `@ghost` `@rustbot` modify labels: rollup

…mpiler-errors Rollup of 8 pull requests Successful merges: - rust-lang#127766 (add `extern "C-cmse-nonsecure-entry" fn` ) - rust-lang#129629 (Implement Return Type Notation (RTN)'s path form in where clauses) - rust-lang#130408 (Avoid re-validating UTF-8 in `FromUtf8Error::into_utf8_lossy`) - rust-lang#130651 (Add --enable-profiler to armhf dist) - rust-lang#130653 (ABI compatibility: mention Result guarantee) - rust-lang#130666 (Assert that `explicit_super_predicates_of` and `explicit_item_super_predicates` truly only contains bounds for the type itself) - rust-lang#130667 (compiler: Accept "improper" ctypes in extern "rust-cold" fn) - rust-lang#130673 (Parser: recover from `:::` to `::`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#130666 - compiler-errors:super-bounds, r=fee1-dead,fmease Assert that `explicit_super_predicates_of` and `explicit_item_super_predicates` truly only contains bounds for the type itself We distinguish _implied_ predicates (anything that is implied from elaborating a trait bound) from _super_ predicates, which are are the subset of implied predicates that share the same self type as the trait predicate we're elaborating. This was originally done in rust-lang#107614, which fixed a large class of ICEs and strange errors where the compiler expected the self type of a trait predicate not to change when elaborating super predicates. Specifically, super predicates are special for various reasons: they're the valid candidates for trait upcasting, are the only predicates we elaborate when doing closure signature inference, etc. So making sure that we get this list correct and don't accidentally "leak" any other predicates into this list is quite important. This PR adds some debug assertions that we're in fact not doing so, and it fixes an oversight in the effect desugaring rework.

compiler-errors · 2024-09-21T15:45:00Z

We distinguish implied predicates (anything that is implied from elaborating a trait bound) from super predicates, which are are the subset of implied predicates that share the same self type as the trait predicate we're elaborating. This was originally done in #107614, which fixed a large class of ICEs and strange errors where the compiler expected the self type of a trait predicate not to change when elaborating super predicates.

Specifically, super predicates are special for various reasons: they're the valid candidates for trait upcasting, are the only predicates we elaborate when doing closure signature inference, etc. So making sure that we get this list correct and don't accidentally "leak" any other predicates into this list is quite important.

This PR adds some debug assertions that we're in fact not doing so, and it fixes an oversight in the effect desugaring rework.

rustbot · 2024-09-21T15:45:08Z

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2024-09-21T15:45:10Z

HIR ty lowering was modified

cc @fmease

fee1-dead

LGTM

fee1-dead · 2024-09-21T16:03:31Z

@bors r+
r? @fee1-dead

bors · 2024-09-21T16:03:34Z

📌 Commit 55db3ff has been approved by fee1-dead

It is now in the queue for this repository.

…ly only bounds for the type itself

…ally collecting implied bounds, not super bounds

compiler-errors · 2024-09-21T16:24:40Z

@bors r=fee1-dead,fmease rollup

bors · 2024-09-21T16:24:43Z

📌 Commit 4f3d06f has been approved by fee1-dead,fmease

It is now in the queue for this repository.

…e1-dead,fmease Assert that `explicit_super_predicates_of` and `explicit_item_super_predicates` truly only contains bounds for the type itself We distinguish _implied_ predicates (anything that is implied from elaborating a trait bound) from _super_ predicates, which are are the subset of implied predicates that share the same self type as the trait predicate we're elaborating. This was originally done in rust-lang#107614, which fixed a large class of ICEs and strange errors where the compiler expected the self type of a trait predicate not to change when elaborating super predicates. Specifically, super predicates are special for various reasons: they're the valid candidates for trait upcasting, are the only predicates we elaborate when doing closure signature inference, etc. So making sure that we get this list correct and don't accidentally "leak" any other predicates into this list is quite important. This PR adds some debug assertions that we're in fact not doing so, and it fixes an oversight in the effect desugaring rework.

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#127766 (add `extern "C-cmse-nonsecure-entry" fn` ) - rust-lang#129629 (Implement Return Type Notation (RTN)'s path form in where clauses) - rust-lang#130246 (rustc_expand: remember module `#[path]`s during expansion) - rust-lang#130408 (Avoid re-validating UTF-8 in `FromUtf8Error::into_utf8_lossy`) - rust-lang#130651 (Add --enable-profiler to armhf dist) - rust-lang#130653 (ABI compatibility: mention Result guarantee) - rust-lang#130665 (Prevent Deduplication of `LongRunningWarn`) - rust-lang#130666 (Assert that `explicit_super_predicates_of` and `explicit_item_super_predicates` truly only contains bounds for the type itself) - rust-lang#130667 (compiler: Accept "improper" ctypes in extern "rust-cold" fn) r? `@ghost` `@rustbot` modify labels: rollup

…mpiler-errors Rollup of 8 pull requests Successful merges: - rust-lang#127766 (add `extern "C-cmse-nonsecure-entry" fn` ) - rust-lang#129629 (Implement Return Type Notation (RTN)'s path form in where clauses) - rust-lang#130408 (Avoid re-validating UTF-8 in `FromUtf8Error::into_utf8_lossy`) - rust-lang#130651 (Add --enable-profiler to armhf dist) - rust-lang#130653 (ABI compatibility: mention Result guarantee) - rust-lang#130666 (Assert that `explicit_super_predicates_of` and `explicit_item_super_predicates` truly only contains bounds for the type itself) - rust-lang#130667 (compiler: Accept "improper" ctypes in extern "rust-cold" fn) - rust-lang#130673 (Parser: recover from `:::` to `::`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#130666 - compiler-errors:super-bounds, r=fee1-dead,fmease Assert that `explicit_super_predicates_of` and `explicit_item_super_predicates` truly only contains bounds for the type itself We distinguish _implied_ predicates (anything that is implied from elaborating a trait bound) from _super_ predicates, which are are the subset of implied predicates that share the same self type as the trait predicate we're elaborating. This was originally done in rust-lang#107614, which fixed a large class of ICEs and strange errors where the compiler expected the self type of a trait predicate not to change when elaborating super predicates. Specifically, super predicates are special for various reasons: they're the valid candidates for trait upcasting, are the only predicates we elaborate when doing closure signature inference, etc. So making sure that we get this list correct and don't accidentally "leak" any other predicates into this list is quite important. This PR adds some debug assertions that we're in fact not doing so, and it fixes an oversight in the effect desugaring rework.

compiler-errors · 2024-09-21T15:45:00Z

We distinguish implied predicates (anything that is implied from elaborating a trait bound) from super predicates, which are are the subset of implied predicates that share the same self type as the trait predicate we're elaborating. This was originally done in #107614, which fixed a large class of ICEs and strange errors where the compiler expected the self type of a trait predicate not to change when elaborating super predicates.

Specifically, super predicates are special for various reasons: they're the valid candidates for trait upcasting, are the only predicates we elaborate when doing closure signature inference, etc. So making sure that we get this list correct and don't accidentally "leak" any other predicates into this list is quite important.

This PR adds some debug assertions that we're in fact not doing so, and it fixes an oversight in the effect desugaring rework.

rustbot · 2024-09-21T15:45:08Z

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2024-09-21T15:45:10Z

HIR ty lowering was modified

cc @fmease

fee1-dead

LGTM

fee1-dead · 2024-09-21T16:03:31Z

@bors r+
r? @fee1-dead

bors · 2024-09-21T16:03:34Z

📌 Commit 55db3ff has been approved by fee1-dead

It is now in the queue for this repository.

…ly only bounds for the type itself

…ally collecting implied bounds, not super bounds

compiler-errors · 2024-09-21T16:24:40Z

@bors r=fee1-dead,fmease rollup

bors · 2024-09-21T16:24:43Z

📌 Commit 4f3d06f has been approved by fee1-dead,fmease

It is now in the queue for this repository.

…e1-dead,fmease Assert that `explicit_super_predicates_of` and `explicit_item_super_predicates` truly only contains bounds for the type itself We distinguish _implied_ predicates (anything that is implied from elaborating a trait bound) from _super_ predicates, which are are the subset of implied predicates that share the same self type as the trait predicate we're elaborating. This was originally done in rust-lang#107614, which fixed a large class of ICEs and strange errors where the compiler expected the self type of a trait predicate not to change when elaborating super predicates. Specifically, super predicates are special for various reasons: they're the valid candidates for trait upcasting, are the only predicates we elaborate when doing closure signature inference, etc. So making sure that we get this list correct and don't accidentally "leak" any other predicates into this list is quite important. This PR adds some debug assertions that we're in fact not doing so, and it fixes an oversight in the effect desugaring rework.

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#127766 (add `extern "C-cmse-nonsecure-entry" fn` ) - rust-lang#129629 (Implement Return Type Notation (RTN)'s path form in where clauses) - rust-lang#130246 (rustc_expand: remember module `#[path]`s during expansion) - rust-lang#130408 (Avoid re-validating UTF-8 in `FromUtf8Error::into_utf8_lossy`) - rust-lang#130651 (Add --enable-profiler to armhf dist) - rust-lang#130653 (ABI compatibility: mention Result guarantee) - rust-lang#130665 (Prevent Deduplication of `LongRunningWarn`) - rust-lang#130666 (Assert that `explicit_super_predicates_of` and `explicit_item_super_predicates` truly only contains bounds for the type itself) - rust-lang#130667 (compiler: Accept "improper" ctypes in extern "rust-cold" fn) r? `@ghost` `@rustbot` modify labels: rollup

…mpiler-errors Rollup of 8 pull requests Successful merges: - rust-lang#127766 (add `extern "C-cmse-nonsecure-entry" fn` ) - rust-lang#129629 (Implement Return Type Notation (RTN)'s path form in where clauses) - rust-lang#130408 (Avoid re-validating UTF-8 in `FromUtf8Error::into_utf8_lossy`) - rust-lang#130651 (Add --enable-profiler to armhf dist) - rust-lang#130653 (ABI compatibility: mention Result guarantee) - rust-lang#130666 (Assert that `explicit_super_predicates_of` and `explicit_item_super_predicates` truly only contains bounds for the type itself) - rust-lang#130667 (compiler: Accept "improper" ctypes in extern "rust-cold" fn) - rust-lang#130673 (Parser: recover from `:::` to `::`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#130666 - compiler-errors:super-bounds, r=fee1-dead,fmease Assert that `explicit_super_predicates_of` and `explicit_item_super_predicates` truly only contains bounds for the type itself We distinguish _implied_ predicates (anything that is implied from elaborating a trait bound) from _super_ predicates, which are are the subset of implied predicates that share the same self type as the trait predicate we're elaborating. This was originally done in rust-lang#107614, which fixed a large class of ICEs and strange errors where the compiler expected the self type of a trait predicate not to change when elaborating super predicates. Specifically, super predicates are special for various reasons: they're the valid candidates for trait upcasting, are the only predicates we elaborate when doing closure signature inference, etc. So making sure that we get this list correct and don't accidentally "leak" any other predicates into this list is quite important. This PR adds some debug assertions that we're in fact not doing so, and it fixes an oversight in the effect desugaring rework.

compiler-errors · 2024-09-21T15:45:00Z

We distinguish implied predicates (anything that is implied from elaborating a trait bound) from super predicates, which are are the subset of implied predicates that share the same self type as the trait predicate we're elaborating. This was originally done in #107614, which fixed a large class of ICEs and strange errors where the compiler expected the self type of a trait predicate not to change when elaborating super predicates.

Specifically, super predicates are special for various reasons: they're the valid candidates for trait upcasting, are the only predicates we elaborate when doing closure signature inference, etc. So making sure that we get this list correct and don't accidentally "leak" any other predicates into this list is quite important.

This PR adds some debug assertions that we're in fact not doing so, and it fixes an oversight in the effect desugaring rework.

rustbot · 2024-09-21T15:45:08Z

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2024-09-21T15:45:10Z

HIR ty lowering was modified

cc @fmease

fee1-dead

LGTM

fee1-dead · 2024-09-21T16:03:31Z

@bors r+
r? @fee1-dead

bors · 2024-09-21T16:03:34Z

📌 Commit 55db3ff has been approved by fee1-dead

It is now in the queue for this repository.

…ly only bounds for the type itself

…ally collecting implied bounds, not super bounds

compiler-errors · 2024-09-21T16:24:40Z

@bors r=fee1-dead,fmease rollup

bors · 2024-09-21T16:24:43Z

📌 Commit 4f3d06f has been approved by fee1-dead,fmease

It is now in the queue for this repository.

…e1-dead,fmease Assert that `explicit_super_predicates_of` and `explicit_item_super_predicates` truly only contains bounds for the type itself We distinguish _implied_ predicates (anything that is implied from elaborating a trait bound) from _super_ predicates, which are are the subset of implied predicates that share the same self type as the trait predicate we're elaborating. This was originally done in rust-lang#107614, which fixed a large class of ICEs and strange errors where the compiler expected the self type of a trait predicate not to change when elaborating super predicates. Specifically, super predicates are special for various reasons: they're the valid candidates for trait upcasting, are the only predicates we elaborate when doing closure signature inference, etc. So making sure that we get this list correct and don't accidentally "leak" any other predicates into this list is quite important. This PR adds some debug assertions that we're in fact not doing so, and it fixes an oversight in the effect desugaring rework.

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#127766 (add `extern "C-cmse-nonsecure-entry" fn` ) - rust-lang#129629 (Implement Return Type Notation (RTN)'s path form in where clauses) - rust-lang#130246 (rustc_expand: remember module `#[path]`s during expansion) - rust-lang#130408 (Avoid re-validating UTF-8 in `FromUtf8Error::into_utf8_lossy`) - rust-lang#130651 (Add --enable-profiler to armhf dist) - rust-lang#130653 (ABI compatibility: mention Result guarantee) - rust-lang#130665 (Prevent Deduplication of `LongRunningWarn`) - rust-lang#130666 (Assert that `explicit_super_predicates_of` and `explicit_item_super_predicates` truly only contains bounds for the type itself) - rust-lang#130667 (compiler: Accept "improper" ctypes in extern "rust-cold" fn) r? `@ghost` `@rustbot` modify labels: rollup

…mpiler-errors Rollup of 8 pull requests Successful merges: - rust-lang#127766 (add `extern "C-cmse-nonsecure-entry" fn` ) - rust-lang#129629 (Implement Return Type Notation (RTN)'s path form in where clauses) - rust-lang#130408 (Avoid re-validating UTF-8 in `FromUtf8Error::into_utf8_lossy`) - rust-lang#130651 (Add --enable-profiler to armhf dist) - rust-lang#130653 (ABI compatibility: mention Result guarantee) - rust-lang#130666 (Assert that `explicit_super_predicates_of` and `explicit_item_super_predicates` truly only contains bounds for the type itself) - rust-lang#130667 (compiler: Accept "improper" ctypes in extern "rust-cold" fn) - rust-lang#130673 (Parser: recover from `:::` to `::`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#130666 - compiler-errors:super-bounds, r=fee1-dead,fmease Assert that `explicit_super_predicates_of` and `explicit_item_super_predicates` truly only contains bounds for the type itself We distinguish _implied_ predicates (anything that is implied from elaborating a trait bound) from _super_ predicates, which are are the subset of implied predicates that share the same self type as the trait predicate we're elaborating. This was originally done in rust-lang#107614, which fixed a large class of ICEs and strange errors where the compiler expected the self type of a trait predicate not to change when elaborating super predicates. Specifically, super predicates are special for various reasons: they're the valid candidates for trait upcasting, are the only predicates we elaborate when doing closure signature inference, etc. So making sure that we get this list correct and don't accidentally "leak" any other predicates into this list is quite important. This PR adds some debug assertions that we're in fact not doing so, and it fixes an oversight in the effect desugaring rework.

compiler-errors · 2024-09-21T15:45:00Z

We distinguish implied predicates (anything that is implied from elaborating a trait bound) from super predicates, which are are the subset of implied predicates that share the same self type as the trait predicate we're elaborating. This was originally done in #107614, which fixed a large class of ICEs and strange errors where the compiler expected the self type of a trait predicate not to change when elaborating super predicates.

Specifically, super predicates are special for various reasons: they're the valid candidates for trait upcasting, are the only predicates we elaborate when doing closure signature inference, etc. So making sure that we get this list correct and don't accidentally "leak" any other predicates into this list is quite important.

This PR adds some debug assertions that we're in fact not doing so, and it fixes an oversight in the effect desugaring rework.

rustbot · 2024-09-21T15:45:08Z

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2024-09-21T15:45:10Z

HIR ty lowering was modified

cc @fmease

fee1-dead

LGTM

fee1-dead · 2024-09-21T16:03:31Z

@bors r+
r? @fee1-dead

bors · 2024-09-21T16:03:34Z

📌 Commit 55db3ff has been approved by fee1-dead

It is now in the queue for this repository.

…ly only bounds for the type itself

…ally collecting implied bounds, not super bounds

compiler-errors · 2024-09-21T16:24:40Z

@bors r=fee1-dead,fmease rollup

bors · 2024-09-21T16:24:43Z

📌 Commit 4f3d06f has been approved by fee1-dead,fmease

It is now in the queue for this repository.

…e1-dead,fmease Assert that `explicit_super_predicates_of` and `explicit_item_super_predicates` truly only contains bounds for the type itself We distinguish _implied_ predicates (anything that is implied from elaborating a trait bound) from _super_ predicates, which are are the subset of implied predicates that share the same self type as the trait predicate we're elaborating. This was originally done in rust-lang#107614, which fixed a large class of ICEs and strange errors where the compiler expected the self type of a trait predicate not to change when elaborating super predicates. Specifically, super predicates are special for various reasons: they're the valid candidates for trait upcasting, are the only predicates we elaborate when doing closure signature inference, etc. So making sure that we get this list correct and don't accidentally "leak" any other predicates into this list is quite important. This PR adds some debug assertions that we're in fact not doing so, and it fixes an oversight in the effect desugaring rework.

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#127766 (add `extern "C-cmse-nonsecure-entry" fn` ) - rust-lang#129629 (Implement Return Type Notation (RTN)'s path form in where clauses) - rust-lang#130246 (rustc_expand: remember module `#[path]`s during expansion) - rust-lang#130408 (Avoid re-validating UTF-8 in `FromUtf8Error::into_utf8_lossy`) - rust-lang#130651 (Add --enable-profiler to armhf dist) - rust-lang#130653 (ABI compatibility: mention Result guarantee) - rust-lang#130665 (Prevent Deduplication of `LongRunningWarn`) - rust-lang#130666 (Assert that `explicit_super_predicates_of` and `explicit_item_super_predicates` truly only contains bounds for the type itself) - rust-lang#130667 (compiler: Accept "improper" ctypes in extern "rust-cold" fn) r? `@ghost` `@rustbot` modify labels: rollup

…mpiler-errors Rollup of 8 pull requests Successful merges: - rust-lang#127766 (add `extern "C-cmse-nonsecure-entry" fn` ) - rust-lang#129629 (Implement Return Type Notation (RTN)'s path form in where clauses) - rust-lang#130408 (Avoid re-validating UTF-8 in `FromUtf8Error::into_utf8_lossy`) - rust-lang#130651 (Add --enable-profiler to armhf dist) - rust-lang#130653 (ABI compatibility: mention Result guarantee) - rust-lang#130666 (Assert that `explicit_super_predicates_of` and `explicit_item_super_predicates` truly only contains bounds for the type itself) - rust-lang#130667 (compiler: Accept "improper" ctypes in extern "rust-cold" fn) - rust-lang#130673 (Parser: recover from `:::` to `::`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#130666 - compiler-errors:super-bounds, r=fee1-dead,fmease Assert that `explicit_super_predicates_of` and `explicit_item_super_predicates` truly only contains bounds for the type itself We distinguish _implied_ predicates (anything that is implied from elaborating a trait bound) from _super_ predicates, which are are the subset of implied predicates that share the same self type as the trait predicate we're elaborating. This was originally done in rust-lang#107614, which fixed a large class of ICEs and strange errors where the compiler expected the self type of a trait predicate not to change when elaborating super predicates. Specifically, super predicates are special for various reasons: they're the valid candidates for trait upcasting, are the only predicates we elaborate when doing closure signature inference, etc. So making sure that we get this list correct and don't accidentally "leak" any other predicates into this list is quite important. This PR adds some debug assertions that we're in fact not doing so, and it fixes an oversight in the effect desugaring rework.

compiler-errors · 2024-09-21T15:45:00Z

We distinguish implied predicates (anything that is implied from elaborating a trait bound) from super predicates, which are are the subset of implied predicates that share the same self type as the trait predicate we're elaborating. This was originally done in #107614, which fixed a large class of ICEs and strange errors where the compiler expected the self type of a trait predicate not to change when elaborating super predicates.

Specifically, super predicates are special for various reasons: they're the valid candidates for trait upcasting, are the only predicates we elaborate when doing closure signature inference, etc. So making sure that we get this list correct and don't accidentally "leak" any other predicates into this list is quite important.

This PR adds some debug assertions that we're in fact not doing so, and it fixes an oversight in the effect desugaring rework.

rustbot · 2024-09-21T15:45:08Z

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2024-09-21T15:45:10Z

HIR ty lowering was modified

cc @fmease

fee1-dead

LGTM

fee1-dead · 2024-09-21T16:03:31Z

@bors r+
r? @fee1-dead

bors · 2024-09-21T16:03:34Z

📌 Commit 55db3ff has been approved by fee1-dead

It is now in the queue for this repository.

…ly only bounds for the type itself

…ally collecting implied bounds, not super bounds

compiler-errors · 2024-09-21T16:24:40Z

@bors r=fee1-dead,fmease rollup

bors · 2024-09-21T16:24:43Z

📌 Commit 4f3d06f has been approved by fee1-dead,fmease

It is now in the queue for this repository.

…e1-dead,fmease Assert that `explicit_super_predicates_of` and `explicit_item_super_predicates` truly only contains bounds for the type itself We distinguish _implied_ predicates (anything that is implied from elaborating a trait bound) from _super_ predicates, which are are the subset of implied predicates that share the same self type as the trait predicate we're elaborating. This was originally done in rust-lang#107614, which fixed a large class of ICEs and strange errors where the compiler expected the self type of a trait predicate not to change when elaborating super predicates. Specifically, super predicates are special for various reasons: they're the valid candidates for trait upcasting, are the only predicates we elaborate when doing closure signature inference, etc. So making sure that we get this list correct and don't accidentally "leak" any other predicates into this list is quite important. This PR adds some debug assertions that we're in fact not doing so, and it fixes an oversight in the effect desugaring rework.

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#127766 (add `extern "C-cmse-nonsecure-entry" fn` ) - rust-lang#129629 (Implement Return Type Notation (RTN)'s path form in where clauses) - rust-lang#130246 (rustc_expand: remember module `#[path]`s during expansion) - rust-lang#130408 (Avoid re-validating UTF-8 in `FromUtf8Error::into_utf8_lossy`) - rust-lang#130651 (Add --enable-profiler to armhf dist) - rust-lang#130653 (ABI compatibility: mention Result guarantee) - rust-lang#130665 (Prevent Deduplication of `LongRunningWarn`) - rust-lang#130666 (Assert that `explicit_super_predicates_of` and `explicit_item_super_predicates` truly only contains bounds for the type itself) - rust-lang#130667 (compiler: Accept "improper" ctypes in extern "rust-cold" fn) r? `@ghost` `@rustbot` modify labels: rollup

…mpiler-errors Rollup of 8 pull requests Successful merges: - rust-lang#127766 (add `extern "C-cmse-nonsecure-entry" fn` ) - rust-lang#129629 (Implement Return Type Notation (RTN)'s path form in where clauses) - rust-lang#130408 (Avoid re-validating UTF-8 in `FromUtf8Error::into_utf8_lossy`) - rust-lang#130651 (Add --enable-profiler to armhf dist) - rust-lang#130653 (ABI compatibility: mention Result guarantee) - rust-lang#130666 (Assert that `explicit_super_predicates_of` and `explicit_item_super_predicates` truly only contains bounds for the type itself) - rust-lang#130667 (compiler: Accept "improper" ctypes in extern "rust-cold" fn) - rust-lang#130673 (Parser: recover from `:::` to `::`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#130666 - compiler-errors:super-bounds, r=fee1-dead,fmease Assert that `explicit_super_predicates_of` and `explicit_item_super_predicates` truly only contains bounds for the type itself We distinguish _implied_ predicates (anything that is implied from elaborating a trait bound) from _super_ predicates, which are are the subset of implied predicates that share the same self type as the trait predicate we're elaborating. This was originally done in rust-lang#107614, which fixed a large class of ICEs and strange errors where the compiler expected the self type of a trait predicate not to change when elaborating super predicates. Specifically, super predicates are special for various reasons: they're the valid candidates for trait upcasting, are the only predicates we elaborate when doing closure signature inference, etc. So making sure that we get this list correct and don't accidentally "leak" any other predicates into this list is quite important. This PR adds some debug assertions that we're in fact not doing so, and it fixes an oversight in the effect desugaring rework.

compiler-errors · 2024-09-21T15:45:00Z

We distinguish implied predicates (anything that is implied from elaborating a trait bound) from super predicates, which are are the subset of implied predicates that share the same self type as the trait predicate we're elaborating. This was originally done in #107614, which fixed a large class of ICEs and strange errors where the compiler expected the self type of a trait predicate not to change when elaborating super predicates.

Specifically, super predicates are special for various reasons: they're the valid candidates for trait upcasting, are the only predicates we elaborate when doing closure signature inference, etc. So making sure that we get this list correct and don't accidentally "leak" any other predicates into this list is quite important.

This PR adds some debug assertions that we're in fact not doing so, and it fixes an oversight in the effect desugaring rework.

rustbot · 2024-09-21T15:45:08Z

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2024-09-21T15:45:10Z

HIR ty lowering was modified

cc @fmease

fee1-dead

LGTM

fee1-dead · 2024-09-21T16:03:31Z

@bors r+
r? @fee1-dead

bors · 2024-09-21T16:03:34Z

📌 Commit 55db3ff has been approved by fee1-dead

It is now in the queue for this repository.

…ly only bounds for the type itself

…ally collecting implied bounds, not super bounds

compiler-errors · 2024-09-21T16:24:40Z

@bors r=fee1-dead,fmease rollup

bors · 2024-09-21T16:24:43Z

📌 Commit 4f3d06f has been approved by fee1-dead,fmease

It is now in the queue for this repository.

…e1-dead,fmease Assert that `explicit_super_predicates_of` and `explicit_item_super_predicates` truly only contains bounds for the type itself We distinguish _implied_ predicates (anything that is implied from elaborating a trait bound) from _super_ predicates, which are are the subset of implied predicates that share the same self type as the trait predicate we're elaborating. This was originally done in rust-lang#107614, which fixed a large class of ICEs and strange errors where the compiler expected the self type of a trait predicate not to change when elaborating super predicates. Specifically, super predicates are special for various reasons: they're the valid candidates for trait upcasting, are the only predicates we elaborate when doing closure signature inference, etc. So making sure that we get this list correct and don't accidentally "leak" any other predicates into this list is quite important. This PR adds some debug assertions that we're in fact not doing so, and it fixes an oversight in the effect desugaring rework.

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#127766 (add `extern "C-cmse-nonsecure-entry" fn` ) - rust-lang#129629 (Implement Return Type Notation (RTN)'s path form in where clauses) - rust-lang#130246 (rustc_expand: remember module `#[path]`s during expansion) - rust-lang#130408 (Avoid re-validating UTF-8 in `FromUtf8Error::into_utf8_lossy`) - rust-lang#130651 (Add --enable-profiler to armhf dist) - rust-lang#130653 (ABI compatibility: mention Result guarantee) - rust-lang#130665 (Prevent Deduplication of `LongRunningWarn`) - rust-lang#130666 (Assert that `explicit_super_predicates_of` and `explicit_item_super_predicates` truly only contains bounds for the type itself) - rust-lang#130667 (compiler: Accept "improper" ctypes in extern "rust-cold" fn) r? `@ghost` `@rustbot` modify labels: rollup

…mpiler-errors Rollup of 8 pull requests Successful merges: - rust-lang#127766 (add `extern "C-cmse-nonsecure-entry" fn` ) - rust-lang#129629 (Implement Return Type Notation (RTN)'s path form in where clauses) - rust-lang#130408 (Avoid re-validating UTF-8 in `FromUtf8Error::into_utf8_lossy`) - rust-lang#130651 (Add --enable-profiler to armhf dist) - rust-lang#130653 (ABI compatibility: mention Result guarantee) - rust-lang#130666 (Assert that `explicit_super_predicates_of` and `explicit_item_super_predicates` truly only contains bounds for the type itself) - rust-lang#130667 (compiler: Accept "improper" ctypes in extern "rust-cold" fn) - rust-lang#130673 (Parser: recover from `:::` to `::`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#130666 - compiler-errors:super-bounds, r=fee1-dead,fmease Assert that `explicit_super_predicates_of` and `explicit_item_super_predicates` truly only contains bounds for the type itself We distinguish _implied_ predicates (anything that is implied from elaborating a trait bound) from _super_ predicates, which are are the subset of implied predicates that share the same self type as the trait predicate we're elaborating. This was originally done in rust-lang#107614, which fixed a large class of ICEs and strange errors where the compiler expected the self type of a trait predicate not to change when elaborating super predicates. Specifically, super predicates are special for various reasons: they're the valid candidates for trait upcasting, are the only predicates we elaborate when doing closure signature inference, etc. So making sure that we get this list correct and don't accidentally "leak" any other predicates into this list is quite important. This PR adds some debug assertions that we're in fact not doing so, and it fixes an oversight in the effect desugaring rework.

rustbot assigned davidtwco Sep 21, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 21, 2024

compiler-errors changed the title ~~Assert that explicit_super_predicates_of and explicit_item_bounds truly only bounds for the type itself~~Assert that explicit_super_predicates_of and explicit_item_super_predicates truly only bounds for the type itselfSep 21, 2024

This comment was marked as resolved.
Sign in to view

compiler-errors changed the title ~~Assert that explicit_super_predicates_of and explicit_item_super_predicates truly only bounds for the type itself~~Assert that explicit_super_predicates_of and explicit_item_super_predicates truly only contains bounds for the type itselfSep 21, 2024

compiler-errors mentioned this pull request Sep 21, 2024
properly elaborate effects implied bounds for super traits #129499
Merged

fee1-dead approved these changes Sep 21, 2024
View reviewed changes

rustbot assigned fee1-dead and unassigned davidtwco Sep 21, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 21, 2024

This comment was marked as duplicate.
Sign in to view

compiler-errors added 2 commits September 21, 2024 12:20

Assert that explicit_super_predicates_of and explicit_item_bounds tru…
a846d55
…ly only bounds for the type itself

Don't elaborate effects predicates into bounds list unless we're actu…
4f3d06f
…ally collecting implied bounds, not super bounds

compiler-errors force-pushed the super-bounds branch from 55db3ff to 4f3d06fCompare September 21, 2024 16:20

matthiaskrgr mentioned this pull request Sep 21, 2024
Rollup of 9 pull requests #130671
Closed

compiler-errors mentioned this pull request Sep 21, 2024
Rollup of 8 pull requests #130674
Merged

bors merged commit d1b43d0 into rust-lang:masterSep 22, 2024

rustbot added this to the 1.83.0 milestone Sep 22, 2024

rustbot assigned davidtwco Sep 21, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 21, 2024

compiler-errors changed the title ~~Assert that explicit_super_predicates_of and explicit_item_bounds truly only bounds for the type itself~~Assert that explicit_super_predicates_of and explicit_item_super_predicates truly only bounds for the type itselfSep 21, 2024

This comment was marked as resolved.
Sign in to view

compiler-errors changed the title ~~Assert that explicit_super_predicates_of and explicit_item_super_predicates truly only bounds for the type itself~~Assert that explicit_super_predicates_of and explicit_item_super_predicates truly only contains bounds for the type itselfSep 21, 2024

compiler-errors mentioned this pull request Sep 21, 2024
properly elaborate effects implied bounds for super traits #129499
Merged

fee1-dead approved these changes Sep 21, 2024
View reviewed changes

rustbot assigned fee1-dead and unassigned davidtwco Sep 21, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 21, 2024

This comment was marked as duplicate.
Sign in to view

compiler-errors added 2 commits September 21, 2024 12:20

Assert that explicit_super_predicates_of and explicit_item_bounds tru…
a846d55
…ly only bounds for the type itself

Don't elaborate effects predicates into bounds list unless we're actu…
4f3d06f
…ally collecting implied bounds, not super bounds

compiler-errors force-pushed the super-bounds branch from 55db3ff to 4f3d06fCompare September 21, 2024 16:20

matthiaskrgr mentioned this pull request Sep 21, 2024
Rollup of 9 pull requests #130671
Closed

compiler-errors mentioned this pull request Sep 21, 2024
Rollup of 8 pull requests #130674
Merged

bors merged commit d1b43d0 into rust-lang:masterSep 22, 2024

rustbot added this to the 1.83.0 milestone Sep 22, 2024

rustbot assigned davidtwco Sep 21, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 21, 2024

compiler-errors changed the title ~~Assert that explicit_super_predicates_of and explicit_item_bounds truly only bounds for the type itself~~Assert that explicit_super_predicates_of and explicit_item_super_predicates truly only bounds for the type itselfSep 21, 2024

This comment was marked as resolved.
Sign in to view

compiler-errors changed the title ~~Assert that explicit_super_predicates_of and explicit_item_super_predicates truly only bounds for the type itself~~Assert that explicit_super_predicates_of and explicit_item_super_predicates truly only contains bounds for the type itselfSep 21, 2024

compiler-errors mentioned this pull request Sep 21, 2024
properly elaborate effects implied bounds for super traits #129499
Merged

fee1-dead approved these changes Sep 21, 2024
View reviewed changes

rustbot assigned fee1-dead and unassigned davidtwco Sep 21, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 21, 2024

This comment was marked as duplicate.
Sign in to view

compiler-errors added 2 commits September 21, 2024 12:20

Assert that explicit_super_predicates_of and explicit_item_bounds tru…
a846d55
…ly only bounds for the type itself

Don't elaborate effects predicates into bounds list unless we're actu…
4f3d06f
…ally collecting implied bounds, not super bounds

compiler-errors force-pushed the super-bounds branch from 55db3ff to 4f3d06fCompare September 21, 2024 16:20

matthiaskrgr mentioned this pull request Sep 21, 2024
Rollup of 9 pull requests #130671
Closed

compiler-errors mentioned this pull request Sep 21, 2024
Rollup of 8 pull requests #130674
Merged

bors merged commit d1b43d0 into rust-lang:masterSep 22, 2024

rustbot added this to the 1.83.0 milestone Sep 22, 2024

rustbot assigned davidtwco Sep 21, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 21, 2024

compiler-errors changed the title ~~Assert that explicit_super_predicates_of and explicit_item_bounds truly only bounds for the type itself~~Assert that explicit_super_predicates_of and explicit_item_super_predicates truly only bounds for the type itselfSep 21, 2024

This comment was marked as resolved.
Sign in to view

compiler-errors changed the title ~~Assert that explicit_super_predicates_of and explicit_item_super_predicates truly only bounds for the type itself~~Assert that explicit_super_predicates_of and explicit_item_super_predicates truly only contains bounds for the type itselfSep 21, 2024

compiler-errors mentioned this pull request Sep 21, 2024
properly elaborate effects implied bounds for super traits #129499
Merged

fee1-dead approved these changes Sep 21, 2024
View reviewed changes

rustbot assigned fee1-dead and unassigned davidtwco Sep 21, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 21, 2024

This comment was marked as duplicate.
Sign in to view

compiler-errors added 2 commits September 21, 2024 12:20

Assert that explicit_super_predicates_of and explicit_item_bounds tru…
a846d55
…ly only bounds for the type itself

Don't elaborate effects predicates into bounds list unless we're actu…
4f3d06f
…ally collecting implied bounds, not super bounds

compiler-errors force-pushed the super-bounds branch from 55db3ff to 4f3d06fCompare September 21, 2024 16:20

matthiaskrgr mentioned this pull request Sep 21, 2024
Rollup of 9 pull requests #130671
Closed

compiler-errors mentioned this pull request Sep 21, 2024
Rollup of 8 pull requests #130674
Merged

bors merged commit d1b43d0 into rust-lang:masterSep 22, 2024

rustbot added this to the 1.83.0 milestone Sep 22, 2024

rustbot assigned davidtwco Sep 21, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 21, 2024

compiler-errors changed the title ~~Assert that explicit_super_predicates_of and explicit_item_bounds truly only bounds for the type itself~~Assert that explicit_super_predicates_of and explicit_item_super_predicates truly only bounds for the type itselfSep 21, 2024

This comment was marked as resolved.
Sign in to view

compiler-errors changed the title ~~Assert that explicit_super_predicates_of and explicit_item_super_predicates truly only bounds for the type itself~~Assert that explicit_super_predicates_of and explicit_item_super_predicates truly only contains bounds for the type itselfSep 21, 2024

compiler-errors mentioned this pull request Sep 21, 2024
properly elaborate effects implied bounds for super traits #129499
Merged

fee1-dead approved these changes Sep 21, 2024
View reviewed changes

rustbot assigned fee1-dead and unassigned davidtwco Sep 21, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 21, 2024

This comment was marked as duplicate.
Sign in to view

compiler-errors added 2 commits September 21, 2024 12:20

Assert that explicit_super_predicates_of and explicit_item_bounds tru…
a846d55
…ly only bounds for the type itself

Don't elaborate effects predicates into bounds list unless we're actu…
4f3d06f
…ally collecting implied bounds, not super bounds

compiler-errors force-pushed the super-bounds branch from 55db3ff to 4f3d06fCompare September 21, 2024 16:20

matthiaskrgr mentioned this pull request Sep 21, 2024
Rollup of 9 pull requests #130671
Closed

compiler-errors mentioned this pull request Sep 21, 2024
Rollup of 8 pull requests #130674
Merged

bors merged commit d1b43d0 into rust-lang:masterSep 22, 2024

rustbot added this to the 1.83.0 milestone Sep 22, 2024

rustbot assigned davidtwco Sep 21, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 21, 2024

compiler-errors changed the title ~~Assert that explicit_super_predicates_of and explicit_item_bounds truly only bounds for the type itself~~Assert that explicit_super_predicates_of and explicit_item_super_predicates truly only bounds for the type itselfSep 21, 2024

This comment was marked as resolved.
Sign in to view

compiler-errors changed the title ~~Assert that explicit_super_predicates_of and explicit_item_super_predicates truly only bounds for the type itself~~Assert that explicit_super_predicates_of and explicit_item_super_predicates truly only contains bounds for the type itselfSep 21, 2024

compiler-errors mentioned this pull request Sep 21, 2024
properly elaborate effects implied bounds for super traits #129499
Merged

fee1-dead approved these changes Sep 21, 2024
View reviewed changes

rustbot assigned fee1-dead and unassigned davidtwco Sep 21, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 21, 2024

This comment was marked as duplicate.
Sign in to view

compiler-errors added 2 commits September 21, 2024 12:20

Assert that explicit_super_predicates_of and explicit_item_bounds tru…
a846d55
…ly only bounds for the type itself

Don't elaborate effects predicates into bounds list unless we're actu…
4f3d06f
…ally collecting implied bounds, not super bounds

compiler-errors force-pushed the super-bounds branch from 55db3ff to 4f3d06fCompare September 21, 2024 16:20

matthiaskrgr mentioned this pull request Sep 21, 2024
Rollup of 9 pull requests #130671
Closed

compiler-errors mentioned this pull request Sep 21, 2024
Rollup of 8 pull requests #130674
Merged

bors merged commit d1b43d0 into rust-lang:masterSep 22, 2024

rustbot added this to the 1.83.0 milestone Sep 22, 2024

rustbot assigned davidtwco Sep 21, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 21, 2024

compiler-errors changed the title ~~Assert that explicit_super_predicates_of and explicit_item_bounds truly only bounds for the type itself~~Assert that explicit_super_predicates_of and explicit_item_super_predicates truly only bounds for the type itselfSep 21, 2024

This comment was marked as resolved.
Sign in to view

compiler-errors changed the title ~~Assert that explicit_super_predicates_of and explicit_item_super_predicates truly only bounds for the type itself~~Assert that explicit_super_predicates_of and explicit_item_super_predicates truly only contains bounds for the type itselfSep 21, 2024

compiler-errors mentioned this pull request Sep 21, 2024
properly elaborate effects implied bounds for super traits #129499
Merged

fee1-dead approved these changes Sep 21, 2024
View reviewed changes

rustbot assigned fee1-dead and unassigned davidtwco Sep 21, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 21, 2024

This comment was marked as duplicate.
Sign in to view

compiler-errors added 2 commits September 21, 2024 12:20

Assert that explicit_super_predicates_of and explicit_item_bounds tru…
a846d55
…ly only bounds for the type itself

Don't elaborate effects predicates into bounds list unless we're actu…
4f3d06f
…ally collecting implied bounds, not super bounds

compiler-errors force-pushed the super-bounds branch from 55db3ff to 4f3d06fCompare September 21, 2024 16:20

matthiaskrgr mentioned this pull request Sep 21, 2024
Rollup of 9 pull requests #130671
Closed

compiler-errors mentioned this pull request Sep 21, 2024
Rollup of 8 pull requests #130674
Merged

bors merged commit d1b43d0 into rust-lang:masterSep 22, 2024

rustbot added this to the 1.83.0 milestone Sep 22, 2024

rustbot assigned davidtwco Sep 21, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 21, 2024

compiler-errors changed the title ~~Assert that explicit_super_predicates_of and explicit_item_bounds truly only bounds for the type itself~~Assert that explicit_super_predicates_of and explicit_item_super_predicates truly only bounds for the type itselfSep 21, 2024

This comment was marked as resolved.
Sign in to view

compiler-errors changed the title ~~Assert that explicit_super_predicates_of and explicit_item_super_predicates truly only bounds for the type itself~~Assert that explicit_super_predicates_of and explicit_item_super_predicates truly only contains bounds for the type itselfSep 21, 2024

compiler-errors mentioned this pull request Sep 21, 2024
properly elaborate effects implied bounds for super traits #129499
Merged

fee1-dead approved these changes Sep 21, 2024
View reviewed changes

rustbot assigned fee1-dead and unassigned davidtwco Sep 21, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 21, 2024

This comment was marked as duplicate.
Sign in to view

compiler-errors added 2 commits September 21, 2024 12:20

Assert that explicit_super_predicates_of and explicit_item_bounds tru…
a846d55
…ly only bounds for the type itself

Don't elaborate effects predicates into bounds list unless we're actu…
4f3d06f
…ally collecting implied bounds, not super bounds

compiler-errors force-pushed the super-bounds branch from 55db3ff to 4f3d06fCompare September 21, 2024 16:20

matthiaskrgr mentioned this pull request Sep 21, 2024
Rollup of 9 pull requests #130671
Closed

compiler-errors mentioned this pull request Sep 21, 2024
Rollup of 8 pull requests #130674
Merged

bors merged commit d1b43d0 into rust-lang:masterSep 22, 2024

rustbot added this to the 1.83.0 milestone Sep 22, 2024

Uh oh!

Uh oh!

Conversation

compiler-errors commented Sep 21, 2024

Uh oh!

rustbot commented Sep 21, 2024

Uh oh!

rustbot commented Sep 21, 2024

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

fee1-dead left a comment

Choose a reason for hiding this comment

Uh oh!

fee1-dead commented Sep 21, 2024

Uh oh!

bors commented Sep 21, 2024

Uh oh!

This comment was marked as duplicate.

Uh oh!

compiler-errors commented Sep 21, 2024

Uh oh!

bors commented Sep 21, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Uh oh!

Conversation

compiler-errors commented Sep 21, 2024

Uh oh!

rustbot commented Sep 21, 2024

Uh oh!

rustbot commented Sep 21, 2024

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

fee1-dead left a comment

Choose a reason for hiding this comment

Uh oh!

fee1-dead commented Sep 21, 2024

Uh oh!

bors commented Sep 21, 2024

Uh oh!

This comment was marked as duplicate.

Uh oh!

compiler-errors commented Sep 21, 2024

Uh oh!

bors commented Sep 21, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Uh oh!

Conversation

compiler-errors commented Sep 21, 2024

Uh oh!

rustbot commented Sep 21, 2024

Uh oh!

rustbot commented Sep 21, 2024

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

fee1-dead left a comment

Choose a reason for hiding this comment