Uh oh!
There was an error while loading. Please reload this page.
[rustdoc] Remove unneeded jinja comments - #130706
Merged
bors merged 2 commits intoSep 27, 2024
Merged
Conversation
notriddle
commented
Sep 26, 2024
Contributor
@bors r+ rollup |
bors
commented
Sep 26, 2024
Collaborator
workingjubilee added a commit
to workingjubilee/rustc
that referenced
this pull request
Sep 26, 2024
…ja-comments, r=notriddle [rustdoc] Remove unneeded jinja comments This is a follow-up of rust-lang#130585. Since we now check for the jinja comments we missed, we can now check for the jinja comments which are unneeded. It will make the parsing and therefore the compilation a tiny bit faster (well, if anyone sees a difference haha). The real goal is mostly to have easier to read template files. 😉 r? `@notriddle`
Member
@bors r- Based on #130902 (comment) it looks like a couple more html files need tweaks (one was changed since this PR was created, not sure about the other one?) Reopened for fresh CI |
This comment has been minimized.
This comment has been minimized.
GuillaumeGomezforce-pushed
the
remove-unneeded-jinja-comments
branch
from
September 26, 2024 22:58
912e1ae to
575df06CompareGuillaumeGomez
commented
Sep 26, 2024
MemberAuthor
bors
commented
Sep 26, 2024
Collaborator
tgross35 added a commit
to tgross35/rust
that referenced
this pull request
Sep 27, 2024
…ja-comments, r=notriddle [rustdoc] Remove unneeded jinja comments This is a follow-up of rust-lang#130585. Since we now check for the jinja comments we missed, we can now check for the jinja comments which are unneeded. It will make the parsing and therefore the compilation a tiny bit faster (well, if anyone sees a difference haha). The real goal is mostly to have easier to read template files. 😉 r? `@notriddle`
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 27, 2024
Rollup of 7 pull requests Successful merges: - rust-lang#129687 (Implement RFC3137 trim-paths sysroot changes - take 2) - rust-lang#130313 ([`cfg_match`] Generalize inputs) - rust-lang#130706 ([rustdoc] Remove unneeded jinja comments) - rust-lang#130846 (Revert Break into the debugger on panic (129019)) - rust-lang#130873 (rustc_target: Add powerpc64 atomic-related features) - rust-lang#130875 (update `compiler-builtins` to 0.1.126) - rust-lang#130889 (Weekly `cargo update`: only `rustbook`) r? `@ghost` `@rustbot` modify labels: rollup
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 27, 2024
…kingjubilee Rollup of 8 pull requests Successful merges: - rust-lang#130313 ([`cfg_match`] Generalize inputs) - rust-lang#130706 ([rustdoc] Remove unneeded jinja comments) - rust-lang#130846 (Revert Break into the debugger on panic (129019)) - rust-lang#130875 (update `compiler-builtins` to 0.1.126) - rust-lang#130889 (Weekly `cargo update`: only `rustbook`) - rust-lang#130892 (Partially update `library/Cargo.lock`) - rust-lang#130911 (diagnostics: wrap fn cast suggestions in parens when needed) - rust-lang#130912 (On implicit `Sized` bound on fn argument, point at type instead of pattern) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 27, 2024
Rollup merge of rust-lang#130706 - GuillaumeGomez:remove-unneeded-jinja-comments, r=notriddle [rustdoc] Remove unneeded jinja comments This is a follow-up of rust-lang#130585. Since we now check for the jinja comments we missed, we can now check for the jinja comments which are unneeded. It will make the parsing and therefore the compilation a tiny bit faster (well, if anyone sees a difference haha). The real goal is mostly to have easier to read template files. 😉 r? ``@notriddle``
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up of #130585.
Since we now check for the jinja comments we missed, we can now check for the jinja comments which are unneeded. It will make the parsing and therefore the compilation a tiny bit faster (well, if anyone sees a difference haha). The real goal is mostly to have easier to read template files. 😉
r? @notriddle