Bump cc dependency by arttet · Pull Request #130720 · rust-lang/rust

arttet · 2024-09-22T20:28:40Z

try-job: x86_64-msvc

rustbot · 2024-09-22T20:28:48Z

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2024-09-22T20:41:30Z

These commits modify the library/Cargo.lock file. Unintentional changes to library/Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

rustbot · 2024-09-23T10:28:38Z

The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging.

cc @davidtwco, @wesleywiser

arttet · 2024-09-23T10:35:27Z

r? @onur-ozkan

onur-ozkan · 2024-09-23T12:43:27Z

Library team should review this.

r? library

rustbot · 2024-09-23T12:43:30Z

Failed to set assignee to library: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

onur-ozkan · 2024-09-23T12:45:10Z

r? libs

Amanieu · 2024-09-23T19:33:46Z

@bors r+

bors · 2024-09-23T19:33:48Z

📌 Commit 1265643 has been approved by Amanieu

It is now in the queue for this repository.

Bump cc dependency Closes [rust-lang#130719](rust-lang#130719)

bors · 2024-09-24T01:40:18Z

⌛ Testing commit 1265643 with merge d969b05...

bors · 2024-09-24T02:50:03Z

💔 Test failed - checks-actions

arttet · 2024-09-26T17:49:43Z

If this fails again you should try only bumping to 1.0.100, to get a better idea of whether this is due to a specific cc change or just cache-related.

I really thought it's related to cc. But I've built the compiler on Windows several times successfully. Moreover, I have merged one of the PR.

bors · 2024-09-26T18:23:26Z

💔 Test failed - checks-actions

Bump cc dependency We cannot merge the [PR](rust-lang#130720) Let's try merging an older version for a change. rust-lang#130720 (comment) try-job: x86_64-msvc

workingjubilee · 2024-09-26T20:49:11Z

@bors rollup=iffy

workingjubilee · 2024-09-26T22:54:09Z

Oh, I somehow missed this was already

@bors rollup=never

[experiment] Update cc to 1.0.100 See rust-lang#130720, rust-lang#130898; try with the minimal version bump. try-job: x86_64-msvc

Bump cc dependency We cannot merge the [PR](rust-lang#130720) Let's try merging an older version for a change. rust-lang#130720 (comment) try-job: x86_64-msvc

[experiment] Update cc to 1.0.100 See rust-lang#130720, rust-lang#130898; try with the minimal version bump. try-job: x86_64-msvc

[experiment] Update `cc` CI tests See rust-lang#130720, rust-lang#130898; try with the minimal version bump. try-job: x86_64-msvc

…oratrieb Partially update `library/Cargo.lock` Run `cargo update` in library but exclude updates to `cc` and to `compiler_builtins`. Exclusions were done because `cc` seems to have some issues updating [1], and `compiler_builtins` needs to be updated on its own. Partially supersedes rust-lang#129538. [1]: rust-lang#130720 try-job: x86_64-msvc

Rollup merge of rust-lang#130892 - tgross35:library-cargo-update, r=Noratrieb Partially update `library/Cargo.lock` Run `cargo update` in library but exclude updates to `cc` and to `compiler_builtins`. Exclusions were done because `cc` seems to have some issues updating [1], and `compiler_builtins` needs to be updated on its own. Partially supersedes rust-lang#129538. [1]: rust-lang#130720 try-job: x86_64-msvc

arttet · 2024-09-27T13:23:47Z

@bors try

bors · 2024-09-27T13:24:59Z

⌛ Trying commit 522a53d with merge ddfac70...

tgross35 · 2024-09-27T13:40:18Z

FYI 1.1.22 was already tested, see the results at #130926 (comment)

bors · 2024-09-27T15:11:18Z

☀️ Try build successful - checks-actions
Build commit: ddfac70 (ddfac706ad8c2f0ad73a05566c4a86fd64e248e7)

tgross35 · 2024-09-28T13:13:48Z

#130926 was merged (🎉) so this should be all set

arttet · 2024-09-28T13:15:14Z

Thank you!

rustbot assigned Mark-Simulacrum Sep 22, 2024

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 22, 2024

This comment has been minimized.
Sign in to view

arttet force-pushed the fix/profiler_builtins branch from e28d8a0 to 6792b19Compare September 22, 2024 20:41

This comment has been minimized.
Sign in to view

arttet force-pushed the fix/profiler_builtins branch 2 times, most recently from a109243 to 1265643Compare September 23, 2024 10:28

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Sep 23, 2024

rustbot assigned onur-ozkan and unassigned Mark-Simulacrum Sep 23, 2024

rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Sep 23, 2024

rustbot assigned Amanieu and unassigned onur-ozkan Sep 23, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 23, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 24, 2024
Auto merge ofrust-lang#130720- arttet:fix/profiler_builtins, r=Amanieu
d969b05
Bump cc dependency Closes [rust-lang#130719](rust-lang#130719)

This comment has been minimized.
Sign in to view

bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 24, 2024

tgross35 mentioned this pull request Sep 26, 2024
Run cargo update in the project root #129624
Merged

This comment has been minimized.
Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 26, 2024

arttet mentioned this pull request Sep 26, 2024
Bump cc dependency #130898
Closed

tgross35 mentioned this pull request Sep 26, 2024
[experiment] Update cc CI tests #130908
Closed

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 26, 2024
Auto merge ofrust-lang#130908- tgross35:update-cc, r=<try>
f42fb94
[experiment] Update cc to 1.0.100 See rust-lang#130720, rust-lang#130898; try with the minimal version bump. try-job: x86_64-msvc

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2024
Auto merge ofrust-lang#130908- tgross35:update-cc, r=<try>
9d55780
[experiment] Update cc to 1.0.100 See rust-lang#130720, rust-lang#130898; try with the minimal version bump. try-job: x86_64-msvc

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2024
Auto merge ofrust-lang#130908- tgross35:update-cc, r=<try>
ed664a2
[experiment] Update cc to 1.0.100 See rust-lang#130720, rust-lang#130898; try with the minimal version bump. try-job: x86_64-msvc

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2024
Auto merge ofrust-lang#130908- tgross35:update-cc, r=<try>
f1d03b0
[experiment] Update cc to 1.0.100 See rust-lang#130720, rust-lang#130898; try with the minimal version bump. try-job: x86_64-msvc

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2024
Auto merge ofrust-lang#130908- tgross35:update-cc, r=<try>
3bfb192
[experiment] Update `cc` CI tests See rust-lang#130720, rust-lang#130898; try with the minimal version bump. try-job: x86_64-msvc

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2024
Auto merge ofrust-lang#130908- tgross35:update-cc, r=<try>
61e52cc
[experiment] Update `cc` CI tests See rust-lang#130720, rust-lang#130898; try with the minimal version bump. try-job: x86_64-msvc

tgross35 mentioned this pull request Sep 27, 2024
Revert "Bump cc dependency" rust-lang/compiler-builtins#695
Merged

Bump cc dependency
522a53d

tgross35 mentioned this pull request Oct 22, 2024
Unpin cc and upgrade to the latest version #131070
Merged

Uh oh!

Uh oh!

Conversation

arttet commented Sep 22, 2024• edited by onur-ozkan Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Sep 22, 2024

Uh oh!

This comment has been minimized.

rustbot commented Sep 22, 2024

Uh oh!

This comment has been minimized.

rustbot commented Sep 23, 2024

Uh oh!

arttet commented Sep 23, 2024

Uh oh!

onur-ozkan commented Sep 23, 2024

Uh oh!

rustbot commented Sep 23, 2024

Uh oh!

onur-ozkan commented Sep 23, 2024

Uh oh!

Amanieu commented Sep 23, 2024

Uh oh!

bors commented Sep 23, 2024

Uh oh!

bors commented Sep 24, 2024

Uh oh!

This comment has been minimized.

bors commented Sep 24, 2024

Uh oh!

arttet commented Sep 26, 2024

Uh oh!

This comment has been minimized.

bors commented Sep 26, 2024

Uh oh!

workingjubilee commented Sep 26, 2024

Uh oh!

workingjubilee commented Sep 26, 2024

Uh oh!

arttet commented Sep 27, 2024

Uh oh!

bors commented Sep 27, 2024

Uh oh!

tgross35 commented Sep 27, 2024

Uh oh!

bors commented Sep 27, 2024

Uh oh!

tgross35 commented Sep 28, 2024

Uh oh!

arttet commented Sep 28, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

arttet commented Sep 22, 2024•
edited by onur-ozkan
Loading