Skip to content

Parser: better error messages for @ in struct patterns - #130725

Merged
bors merged 1 commit into
rust-lang:masterfrom
GrigorenkoPV:@-in-struct-patterns
Oct 3, 2024
Merged

Parser: better error messages for @ in struct patterns#130725
bors merged 1 commit into
rust-lang:masterfrom
GrigorenkoPV:@-in-struct-patterns

Conversation

@GrigorenkoPV

@GrigorenkoPVGrigorenkoPV commented Sep 22, 2024•
edited by workingjubilee
Loading

Copy link
Copy Markdown
Contributor

Fixes#74701

@rustbot

rustbot commented Sep 22, 2024

Copy link
Copy Markdown
Collaborator

r? @Nadrieril

rustbot has assigned @Nadrieril.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 22, 2024
@Nadrieril

Nadrieril commented Oct 2, 2024

Copy link
Copy Markdown
Member

Pardon the delay, I was swamped.

This looks good! Thank you

@bors r+

@bors

bors commented Oct 2, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit 9cd668b has been approved by Nadrieril

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 2, 2024
@workingjubileeworkingjubilee mentioned this pull request Oct 3, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 3, 2024
@bors
Auto merge ofrust-lang#131185- workingjubilee:rollup-wkcqe2j, r=wor…
8885239
…kingjubilee
Rollup of 3 pull requests
Successful merges:
- rust-lang#126930 (Add unstable support for outputting file checksums for use in cargo)
- rust-lang#130725 (Parser: better error messages for ``@`` in struct patterns)
- rust-lang#131166 (Fix `target_vendor` for `aarch64-nintendo-switch-freestanding`)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit b7c33e2 into rust-lang:masterOct 3, 2024
@rustbotrustbot added this to the 1.83.0 milestone Oct 3, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 3, 2024
@rust-timer
Unrolled build forrust-lang#130725
d659fa4
Rollup merge of rust-lang#130725 - GrigorenkoPV:@-in-struct-patterns, r=Nadrieril
Parser: better error messages for `@` in struct patterns
@GrigorenkoPV
GrigorenkoPV deleted the @-in-struct-patterns branch October 5, 2024 08:45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@NadrierilNadrieril

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.83.0

Development

Successfully merging this pull request may close these issues.

Confusing error message for Foo{ bar @ .. } pattern

4 participants

@GrigorenkoPV@rustbot@Nadrieril@bors