Skip to content

Reorganize Test Headers - #130730

Merged
bors merged 1 commit into
rust-lang:masterfrom
veera-sivarajan:clean-test-headers
Sep 28, 2024
Merged

Reorganize Test Headers#130730
bors merged 1 commit into
rust-lang:masterfrom
veera-sivarajan:clean-test-headers

Conversation

@veera-sivarajan

@veera-sivarajanveera-sivarajan commented Sep 23, 2024

Copy link
Copy Markdown
Contributor

This PR moves the test headers to the top in a couple of test files to maintain consistent style.

Based on this comment: #130665 (comment)

@rustbot

rustbot commented Sep 23, 2024

Copy link
Copy Markdown
Collaborator

r? @cjgillot

rustbot has assigned @cjgillot.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 23, 2024
@compiler-errors

compiler-errors commented Sep 23, 2024

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Sep 23, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit ca450e1 has been approved by compiler-errors

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 23, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@compiler-errors

compiler-errors commented Sep 23, 2024

Copy link
Copy Markdown
Contributor

@bors r-

test needs blessed

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 23, 2024
@veera-sivarajan

veera-sivarajan commented Sep 26, 2024

Copy link
Copy Markdown
ContributorAuthor

@bors r=compiler-errors

@bors

bors commented Sep 26, 2024

Copy link
Copy Markdown
Collaborator

@veera-sivarajan: 🔑 Insufficient privileges: Not in reviewers

@jieyouxu

jieyouxu commented Sep 27, 2024

Copy link
Copy Markdown
Member

@bors r=compiler-errors

@bors

bors commented Sep 27, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit 8cf861d has been approved by compiler-errors

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 27, 2024
@matthiaskrgrmatthiaskrgr mentioned this pull request Sep 27, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2024
@bors
Auto merge ofrust-lang#130946- matthiaskrgr:rollup-ia4mf0y, r=matth…
442bdde
…iaskrgr
Rollup of 6 pull requests
Successful merges:
- rust-lang#130718 (Cleanup some known-bug issues)
- rust-lang#130730 (Reorganize Test Headers)
- rust-lang#130826 (Compiler: Rename "object safe" to "dyn compatible")
- rust-lang#130915 (fix typo in triagebot.toml)
- rust-lang#130926 (Update cc to 1.1.22 in library/)
- rust-lang#130932 (etc: Add sample rust-analyzer configs for eglot & helix)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2024
@bors
Auto merge ofrust-lang#130946- matthiaskrgr:rollup-ia4mf0y, r=matth…
784b6f7
…iaskrgr
Rollup of 6 pull requests
Successful merges:
- rust-lang#130718 (Cleanup some known-bug issues)
- rust-lang#130730 (Reorganize Test Headers)
- rust-lang#130826 (Compiler: Rename "object safe" to "dyn compatible")
- rust-lang#130915 (fix typo in triagebot.toml)
- rust-lang#130926 (Update cc to 1.1.22 in library/)
- rust-lang#130932 (etc: Add sample rust-analyzer configs for eglot & helix)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2024
@bors
Auto merge ofrust-lang#130946- matthiaskrgr:rollup-ia4mf0y, r=matth…
83e4e18
…iaskrgr
Rollup of 6 pull requests
Successful merges:
- rust-lang#130718 (Cleanup some known-bug issues)
- rust-lang#130730 (Reorganize Test Headers)
- rust-lang#130826 (Compiler: Rename "object safe" to "dyn compatible")
- rust-lang#130915 (fix typo in triagebot.toml)
- rust-lang#130926 (Update cc to 1.1.22 in library/)
- rust-lang#130932 (etc: Add sample rust-analyzer configs for eglot & helix)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit ae43f27 into rust-lang:masterSep 28, 2024
@rustbotrustbot added this to the 1.83.0 milestone Sep 28, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 28, 2024
@rust-timer
Unrolled build forrust-lang#130730
a388267
Rollup merge of rust-lang#130730 - veera-sivarajan:clean-test-headers, r=compiler-errors
Reorganize Test Headers
This PR moves the test headers to the top in a couple of test files to maintain consistent style.
Based on this comment: rust-lang#130665 (comment)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieyouxujieyouxujieyouxu approved these changes
+1 more reviewer
@compiler-errorscompiler-errorscompiler-errors approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@compiler-errorscompiler-errors

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.83.0

Development

Successfully merging this pull request may close these issues.

7 participants

@veera-sivarajan@rustbot@compiler-errors@bors@rust-log-analyzer@jieyouxu@cjgillot