Fix linking for symbols starting with ? on i686-pc-windows-msvc by checkraisefold · Pull Request #130808 · rust-lang/rust

checkraisefold · 2024-09-25T02:39:00Z

When using the export_name attribute to specifically export a symbol beginning with a question mark on the i686-pc-windows-msvc target, that symbol will fail to link and throw a linker error 100% of the time.
Issue writeup.

Closes#44282

I'm not sure if this is a proper solution, but LLVM does the same check which causes this issue, and is applied to all 32- and 64-bit Windows COFF objects (maybe the same patch should be applied for 64 bit windows as well then?). I am more unsure of whether this is the proper place for such a solution (and if the exact conditions of is_like_windows are proper for this usecase), or if the underscore should be stripped elsewhere, but it seems like the most correct place.

I'm also unsure if there are any backwards compatibility ramifications here. There shouldn't be, because binaries with exported symbols starting with ? for this target failed to link because of this issue anyway, but still.

rustbot · 2024-09-25T02:39:08Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @TaKO8Ki (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

@rustbot author: the review is finished, PR author should check the comments and take action accordingly
@rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

checkraisefold · 2024-09-25T02:54:20Z

Just tested this patch with rust-lld; the original issue exists with lld being used as well, not just MSVC's linker, and is fixed by this patch.

jieyouxu · 2024-09-25T06:18:21Z

cc @bjorn3, @petrochenkov and @ChrisDenton, in case anyone has any clues about this 😅

jieyouxu · 2024-11-16T08:50:37Z

Rerolling a reviewer. r? compiler

alex-semenyuk · 2024-12-28T09:42:34Z

@checkraisefold
From wg-triage. Could you please take a look question above

rustbot · 2024-12-31T05:30:55Z

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

checkraisefold · 2024-12-31T05:36:18Z

Apologies for the time it took to get to this - aside from being busy, for a relative Rust newbie (and contributing to the compiler, lol) especially the testing harness is very intimidating and it takes a while to iterate on my beautiful Ryzen 5 3600.

I was hoping to be able to fit this into a codegen or assembly test with some FileCheck annotations, but the technical difficulties of that are very annoying compared to a general run-make test - the compilation fails without this fix, which I tested, and it's a whole lot easier to implement.

checkraisefold · 2024-12-31T08:33:47Z

Seeing as the test no longer sucks-
@rustbot review

Additionally, run-make label can be removed

matthiaskrgr · 2025-01-25T14:10:50Z

Hm, I guess that this will clash with #135707 then 🤔
@bors=davidtwco

jyn514 · 2025-01-25T20:59:15Z

Hm, I guess that this will clash with #135707 then 🤔

it shouldn't, #135707 only compares the linker invocation on x64 linux because it's too fragile to do anything else.

jieyouxu · 2025-01-31T11:00:50Z

Oh I guess this wasn't actually r+'d

@bors r=davidtwco

bors · 2025-01-31T11:00:53Z

📌 Commit 9c3b53d has been approved by davidtwco

It is now in the queue for this repository.

…ing, r=davidtwco Fix linking for symbols starting with ? on i686-pc-windows-msvc When using the `export_name` attribute to specifically export a symbol beginning with a question mark on the `i686-pc-windows-msvc` target, that symbol will fail to link and throw a linker error 100% of the time. [Issue writeup.](rust-lang#44282 (comment)) Closesrust-lang#44282 I'm not sure if this is a proper solution, but [LLVM does the same check](https://github.com/llvm/llvm-project/blob/main/llvm/lib/IR/Mangler.cpp#L48-L49) which causes this issue, and is applied to [all 32- and 64-bit Windows COFF objects](https://github.com/llvm/llvm-project/blob/main/llvm/include/llvm/IR/DataLayout.h#L255-L257) (maybe the same patch should be applied for 64 bit windows as well then?). I am *more* unsure of whether this is the proper place for such a solution (and if the exact conditions of is_like_windows are proper for this usecase), or if the underscore should be stripped elsewhere, but it seems like the most correct place. I'm also unsure if there are any backwards compatibility ramifications here. There shouldn't be, because binaries with exported symbols starting with `?` for this target failed to link because of this issue anyway, but still. try-job: i686-mingw

bors · 2025-01-31T12:31:18Z

⌛ Testing commit 9c3b53d with merge 794a00d...

bors · 2025-01-31T13:48:24Z

💔 Test failed - checks-actions

…nking, r=davidtwco Fix linking for symbols starting with ? on i686-pc-windows-msvc When using the `export_name` attribute to specifically export a symbol beginning with a question mark on the `i686-pc-windows-msvc` target, that symbol will fail to link and throw a linker error 100% of the time. [Issue writeup.](rust-lang#44282 (comment)) Closesrust-lang#44282 I'm not sure if this is a proper solution, but [LLVM does the same check](https://github.com/llvm/llvm-project/blob/main/llvm/lib/IR/Mangler.cpp#L48-L49) which causes this issue, and is applied to [all 32- and 64-bit Windows COFF objects](https://github.com/llvm/llvm-project/blob/main/llvm/include/llvm/IR/DataLayout.h#L255-L257) (maybe the same patch should be applied for 64 bit windows as well then?). I am *more* unsure of whether this is the proper place for such a solution (and if the exact conditions of is_like_windows are proper for this usecase), or if the underscore should be stripped elsewhere, but it seems like the most correct place. I'm also unsure if there are any backwards compatibility ramifications here. There shouldn't be, because binaries with exported symbols starting with `?` for this target failed to link because of this issue anyway, but still. try-job: i686-mingw

jieyouxu · 2025-05-09T12:33:02Z

@bors r-

checkraisefold · 2025-05-09T21:18:11Z

Haven't gotten around to looking into this yet - my test fails with and without the actual compiler changes on that target. Will have to take a closer look at what the linker is doing

rustbot · 2025-05-11T11:15:37Z

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

rustbot · 2025-05-11T11:15:38Z

⚠️Warning⚠️

The following commits have merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.
- b9245bd
You can start a rebase with the following commands:
```
$ # rebase
$ git pull --rebase https://github.com/rust-lang/rust.git master
$ git push --force-with-lease
```

alex-semenyuk · 2025-10-02T18:24:14Z

@checkraisefold
Thanks for your contribution
From wg-triage. Any updates on this PR?

bors · 2025-11-05T07:37:51Z

☔ The latest upstream changes (presumably #147645) made this pull request unmergeable. Please resolve the merge conflicts.

alex-semenyuk · 2025-11-23T17:02:14Z

@checkraisefold
Thanks for your contribution
From wg-triage. Close this PR due to inactivity, please reopen or create new one.

rustbot assigned TaKO8Ki Sep 25, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 25, 2024

jieyouxu added O-windows-msvc Toolchain: MSVC, Operating system: Windows A-linkage Area: linking into static, shared libraries and binaries labels Sep 25, 2024

jieyouxu reviewed Sep 25, 2024
View reviewed changes

Comment threadcompiler/rustc_codegen_ssa/src/back/symbol_export.rs Outdated

rustbot assigned nnethercote and unassigned TaKO8Ki Nov 16, 2024

nnethercote added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 18, 2024

rustbot added the has-merge-commits PR has merge commits, merge with caution. label Dec 30, 2024

This comment has been minimized.
Sign in to view

checkraisefold force-pushed the fix-questionmark-linking branch from a79b6c2 to 2ec1dceCompare December 30, 2024 05:44

rustbot removed the has-merge-commits PR has merge commits, merge with caution. label Dec 30, 2024

checkraisefold force-pushed the fix-questionmark-linking branch from 2ec1dce to 6994ee3Compare December 30, 2024 05:47

rustbot added the A-run-make Area: port run-make Makefiles to rmake.rs label Dec 31, 2024

This comment has been minimized.
Sign in to view

checkraisefold added 3 commits December 31, 2024 00:31

Fix linking for symbols starting with ?
8099510

Add a test
784d47b

Significant test improvements
a4c628c

checkraisefold force-pushed the fix-questionmark-linking branch from c84f1b7 to a4c628cCompare December 31, 2024 08:33

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Dec 31, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 31, 2025

This comment has been minimized.
Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 31, 2025

workingjubilee added the O-x86_32 Target: x86 processors, 32 bit (like i686-*) (also known as IA-32, i386, i586, i686) label Feb 10, 2025

davidtwco added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 18, 2025

Noratrieb mentioned this pull request Mar 6, 2025
Rollup of 42 pull requests #138086
Closed

VlaDexa mentioned this pull request May 2, 2025
Rollup of 40 pull requests #140573
Closed

Merge branch 'rust-lang:master' into fix-questionmark-linking
b9245bd

rustbot added the has-merge-commits PR has merge commits, merge with caution. label May 11, 2025

alex-semenyuk closed this Nov 23, 2025

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Nov 23, 2025

Uh oh!

Uh oh!

Conversation

checkraisefold commented Sep 25, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Sep 25, 2024

Uh oh!

checkraisefold commented Sep 25, 2024

Uh oh!

jieyouxu commented Sep 25, 2024

Uh oh!

Uh oh!

jieyouxu commented Nov 16, 2024

Uh oh!

alex-semenyuk commented Dec 28, 2024

Uh oh!

This comment has been minimized.

rustbot commented Dec 31, 2024

Uh oh!

checkraisefold commented Dec 31, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

checkraisefold commented Dec 31, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matthiaskrgr commented Jan 25, 2025

Uh oh!

jyn514 commented Jan 25, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jieyouxu commented Jan 31, 2025

Uh oh!

bors commented Jan 31, 2025

Uh oh!

bors commented Jan 31, 2025

Uh oh!

This comment has been minimized.

bors commented Jan 31, 2025

Uh oh!

jieyouxu commented May 9, 2025

Uh oh!

checkraisefold commented May 9, 2025

Uh oh!

rustbot commented May 11, 2025

Uh oh!

rustbot commented May 11, 2025

Uh oh!

alex-semenyuk commented Oct 2, 2025

Uh oh!

bors commented Nov 5, 2025

Uh oh!

alex-semenyuk commented Nov 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

checkraisefold commented Sep 25, 2024•
edited
Loading

checkraisefold commented Dec 31, 2024•
edited
Loading

checkraisefold commented Dec 31, 2024•
edited
Loading

jyn514 commented Jan 25, 2025•
edited
Loading