Skip to content

rustdoc: do not animate :target when user prefers reduced motion - #130862

Merged
bors merged 2 commits into
rust-lang:masterfrom
zopsicle:patch-1
Sep 27, 2024
Merged

rustdoc: do not animate :target when user prefers reduced motion#130862
bors merged 2 commits into
rust-lang:masterfrom
zopsicle:patch-1

Conversation

@zopsicle

@zopsiclezopsicle commented Sep 25, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

This accessibility improvement gates #129284 behind an inverted prefers-reduced-motion media query.

@rustbot

rustbot commented Sep 25, 2024

Copy link
Copy Markdown
Collaborator

r? @notriddle

rustbot has assigned @notriddle.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Sep 25, 2024
@rustbot

rustbot commented Sep 25, 2024

Copy link
Copy Markdown
Collaborator

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @jsha

@zopsicle
zopsicleforce-pushed the patch-1 branch 2 times, most recently from f70ea82 to 9a0c685CompareSeptember 25, 2024 23:51
@notriddle

notriddle commented Sep 26, 2024

Copy link
Copy Markdown
Contributor

Fair enough. Can you also put the tooltip fade-out behind the flag, too?

rust/src/librustdoc/html/static/css/rustdoc.css

Lines 1715 to 1721 in 9e394f5

/* This animation is layered onto the mistake-proofing delay for dismissing
a hovered tooltip, to ensure it feels responsive even with the delay.
*/
.fade-out {
opacity:0;
transition: opacity 0.45scubic-bezier(0,0,0.1,1.0);
}

@zopsiclezopsicle
rustdoc: do not animate when user prefers reduced motion
cdd3371
This accessibility improvement gates the target flashing and tooltip fade-out
behind an inverted prefers-reduced-motion media query.
@zopsicle

zopsicle commented Sep 26, 2024•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Done, thanks for bringing it up.

GuillaumeGomez
GuillaumeGomez reviewed Sep 26, 2024
View reviewed changes
Comment threadsrc/librustdoc/html/static/css/rustdoc.css
@notriddle

notriddle commented Sep 26, 2024

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Sep 26, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit cdd3371 has been approved by notriddle

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 26, 2024
@GuillaumeGomez

GuillaumeGomez commented Sep 26, 2024

Copy link
Copy Markdown
Member

Still a comment of mine remaining. I'd prefer for it to be done before merging if you don't mind.

@bors r-

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 26, 2024
@GuillaumeGomez

GuillaumeGomez commented Sep 26, 2024

Copy link
Copy Markdown
Member

Thanks!

@bors r=notriddle,GuillaumeGomez rollup

@bors

bors commented Sep 26, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit 5b58481 has been approved by notriddle,GuillaumeGomez

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 26, 2024
@GuillaumeGomezGuillaumeGomez mentioned this pull request Sep 26, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 26, 2024
@bors
Auto merge ofrust-lang#130907- GuillaumeGomez:rollup-423r4i4, r=Gui…
58420a0
…llaumeGomez
Rollup of 11 pull requests
Successful merges:
- rust-lang#130279 (Document subtleties of `ManuallyDrop`)
- rust-lang#130517 (Add the library workspace to the suggested rust-analyzer config)
- rust-lang#130820 (Fix diagnostics for coroutines with () as input.)
- rust-lang#130833 (Fix the misleading diagnostic for `let_underscore_drop` on type without `Drop` implementation)
- rust-lang#130845 (Utf8Chunks: add link to Utf8Chunk)
- rust-lang#130850 (Pass Module Analysis Manager to Standard Instrumentations)
- rust-lang#130861 (Use `mem::offset_of!` for `sockaddr_un.sun_path`)
- rust-lang#130862 (rustdoc: do not animate :target when user prefers reduced motion)
- rust-lang#130868 (Update FIXME comment in s390x_unknown_linux_*.rs)
- rust-lang#130879 (Pass correct HirId to late_bound_vars in diagnostic code)
- rust-lang#130880 (add missing FIXME(const-hack))
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 432b1ff into rust-lang:masterSep 27, 2024
@rustbotrustbot added this to the 1.83.0 milestone Sep 27, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2024
@rust-timer
Unrolled build forrust-lang#130862
cb6d70d
Rollup merge of rust-lang#130862 - zopsicle:patch-1, r=notriddle,GuillaumeGomez
rustdoc: do not animate :target when user prefers reduced motion
This accessibility improvement gates rust-lang#129284 behind an inverted [prefers-reduced-motion](https://developer.mozilla.org/en-US/docs/Web/CSS/`@media/prefers-reduced-motion)` media query.
@zopsicle
zopsicle deleted the patch-1 branch October 17, 2024 21:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomezGuillaumeGomezGuillaumeGomez approved these changes

Assignees

@notriddlenotriddle

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.83.0

Development

Successfully merging this pull request may close these issues.

5 participants

@zopsicle@rustbot@notriddle@bors@GuillaumeGomez