Don't check unsize goal in MIR validation when opaques remain by compiler-errors · Pull Request #130989 · rust-lang/rust

compiler-errors · 2024-09-28T17:38:59Z

Similarly to mir_assign_valid_types, let's just skip when there are opaques. Fixes#130921.

rustbot · 2024-09-28T17:39:06Z

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2024-09-28T17:39:08Z

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

compiler-errors · 2024-10-09T18:21:49Z

It has been two weeks, so I'm gonna re-roll

r? compiler

estebank · 2024-10-09T21:34:56Z

+ // We sometimes have to use `defining_opaque_types` for predicates
+ // to succeed here and figuring out how exactly that should work
+ // is annoying. It is harmless enough to just not validate anything
+ // in that case. We still check this after analysis as all opaque
+ // types have been revealed at this point.


Should we not enforce this in some way?

We don't enforce it anyways for mir_assign_valid_types, so I don't see any reason to do so. I also don't think it would be easy to do.

estebank · 2024-10-09T21:37:37Z

+ if pred.has_opaque_types() {
+ return true;
+ }


I'm slightly concerned because we use predicate_must_hold_modulo_regions in several places that don't necessarily have additional later checks. Are there negative tests where we can cause compilation failures even when triggering this code-path?

Remember that this is just validation I added, and we validate MIR after opaques are revealed. I'm not totally certain if I understand the concern here.

estebank · 2024-10-09T21:37:56Z

r=me, with answers to the above, one way or another.

compiler-errors · 2024-10-10T11:08:27Z

This is a fix for validation that I just added, so I'm not too worried that the check is now relaxed, since fully validating pre-revealed opaque MIR is not really possible to do.

@bors r=estebank rollup

bors · 2024-10-10T11:08:29Z

📌 Commit 4af6137 has been approved by estebank

It is now in the queue for this repository.

…stebank Don't check unsize goal in MIR validation when opaques remain Similarly to `mir_assign_valid_types`, let's just skip when there are opaques. Fixesrust-lang#130921.

matthiaskrgr · 2024-10-10T16:05:22Z

needs a git rm tests/crashes/130921.rs I think
#131500 (comment)

…stebank Don't check unsize goal in MIR validation when opaques remain Similarly to `mir_assign_valid_types`, let's just skip when there are opaques. Fixesrust-lang#130921.

matthiaskrgr · 2024-10-10T20:01:43Z

@bors r-

compiler-errors · 2024-10-16T01:02:13Z

@bors r=estebank

bors · 2024-10-16T01:02:16Z

📌 Commit c773098 has been approved by estebank

It is now in the queue for this repository.

…stebank Don't check unsize goal in MIR validation when opaques remain Similarly to `mir_assign_valid_types`, let's just skip when there are opaques. Fixesrust-lang#130921.

Rollup of 10 pull requests Successful merges: - rust-lang#129181 (Pass end position of span through inline ASM cookie) - rust-lang#130989 (Don't check unsize goal in MIR validation when opaques remain) - rust-lang#131657 (Rustfmt `for<'a> async` correctly) - rust-lang#131691 (Delay ambiguous intra-doc link resolution after `Cache` has been populated) - rust-lang#131730 (Refactor some `core::fmt` macros) - rust-lang#131751 (Rename `can_coerce` to `may_coerce`, and then structurally resolve correctly in the probe) - rust-lang#131753 (Unify `secondary_span` and `swap_secondary_and_primary` args in `note_type_err`) - rust-lang#131776 (Emscripten: Xfail backtrace ui tests) - rust-lang#131777 (Fix trivially_copy_pass_by_ref in stable_mir) - rust-lang#131778 (Fix needless_lifetimes in stable_mir) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#130989 (Don't check unsize goal in MIR validation when opaques remain) - rust-lang#131657 (Rustfmt `for<'a> async` correctly) - rust-lang#131691 (Delay ambiguous intra-doc link resolution after `Cache` has been populated) - rust-lang#131730 (Refactor some `core::fmt` macros) - rust-lang#131751 (Rename `can_coerce` to `may_coerce`, and then structurally resolve correctly in the probe) - rust-lang#131753 (Unify `secondary_span` and `swap_secondary_and_primary` args in `note_type_err`) - rust-lang#131776 (Emscripten: Xfail backtrace ui tests) - rust-lang#131777 (Fix trivially_copy_pass_by_ref in stable_mir) - rust-lang#131778 (Fix needless_lifetimes in stable_mir) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#130989 - compiler-errors:unsize-opaque, r=estebank Don't check unsize goal in MIR validation when opaques remain Similarly to `mir_assign_valid_types`, let's just skip when there are opaques. Fixesrust-lang#130921.

rustbot assigned wesleywiser Sep 28, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 28, 2024

fmease reviewed Sep 28, 2024
View reviewed changes

Comment threadtests/ui/impl-trait/unsize-cast-validation-rpit.rs

compiler-errors force-pushed the unsize-opaque branch from 6a02453 to 4af6137Compare September 28, 2024 17:50

rustbot assigned estebank and unassigned wesleywiser Oct 9, 2024

estebank reviewed Oct 9, 2024
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 10, 2024

matthiaskrgr mentioned this pull request Oct 10, 2024
Rollup of 7 pull requests #131500
Closed

workingjubilee mentioned this pull request Oct 10, 2024
Rollup of 9 pull requests #131508
Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 10, 2024

Don't check unsize goal in MIR validation when opaques remain
c773098

compiler-errors force-pushed the unsize-opaque branch from 4af6137 to c773098Compare October 16, 2024 01:01

bors removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 16, 2024

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 16, 2024

matthiaskrgr mentioned this pull request Oct 16, 2024
Rollup of 8 pull requests #131768
Closed

Urgau mentioned this pull request Oct 16, 2024
Rollup of 10 pull requests #131785
Closed

matthiaskrgr mentioned this pull request Oct 16, 2024
Rollup of 9 pull requests #131797
Merged

bors merged commit b6a085a into rust-lang:masterOct 16, 2024

rustbot added this to the 1.84.0 milestone Oct 16, 2024

Uh oh!

Uh oh!

Conversation

compiler-errors commented Sep 28, 2024

Uh oh!

rustbot commented Sep 28, 2024

Uh oh!

rustbot commented Sep 28, 2024

Uh oh!

Uh oh!

compiler-errors commented Oct 9, 2024

Uh oh!

estebankOct 9, 2024

Choose a reason for hiding this comment

Uh oh!

compiler-errorsOct 10, 2024

Choose a reason for hiding this comment

Uh oh!

estebankOct 9, 2024

Choose a reason for hiding this comment

Uh oh!

compiler-errorsOct 10, 2024

Choose a reason for hiding this comment

Uh oh!

estebank commented Oct 9, 2024

Uh oh!

compiler-errors commented Oct 10, 2024

Uh oh!

bors commented Oct 10, 2024

Uh oh!

matthiaskrgr commented Oct 10, 2024

Uh oh!

matthiaskrgr commented Oct 10, 2024

Uh oh!

compiler-errors commented Oct 16, 2024

Uh oh!

bors commented Oct 16, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants