Skip to content

add clarity for custom path installation - #131001

Merged
bors merged 1 commit into
rust-lang:masterfrom
iyernaveenr:naveen_iyer/installation_clarity
Oct 6, 2024
Merged

add clarity for custom path installation#131001
bors merged 1 commit into
rust-lang:masterfrom
iyernaveenr:naveen_iyer/installation_clarity

Conversation

@iyernaveenr

Copy link
Copy Markdown
Contributor

install.sysconfdir is another value, in addition to install.prefix, that could be set for custom path installation.

@rustbot

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbotrustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 29, 2024
@iyernaveenr
iyernaveenrforce-pushed the naveen_iyer/installation_clarity branch from cd2aab6 to e69c242CompareSeptember 29, 2024 02:20
@jieyouxujieyouxu added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Sep 29, 2024
Comment threadINSTALL.md Outdated
@iyernaveenr
iyernaveenrforce-pushed the naveen_iyer/installation_clarity branch 3 times, most recently from 8a7a03a to a05938fCompareOctober 1, 2024 01:20
Comment threadINSTALL.md Outdated
install.sysconfdir is another value, in addition to install.prefix,
that could be set for custom path installation.
Signed-off-by: Naveen R. Iyer <iyernaveenr@gmail.com>
@iyernaveenr
iyernaveenrforce-pushed the naveen_iyer/installation_clarity branch from a05938f to 0df736cCompareOctober 6, 2024 12:37
@onur-ozkan

Copy link
Copy Markdown
Contributor

Thanks!

@bors r+

@bors

bors commented Oct 6, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit 0df736c has been approved by onur-ozkan

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 6, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 6, 2024
…iaskrgr
Rollup of 4 pull requests
Successful merges:
- rust-lang#131001 (add clarity for custom path installation)
- rust-lang#131307 (Android: Debug assertion after setting thread name)
- rust-lang#131322 (Update out-dated link)
- rust-lang#131335 (grammar fix)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 1e2b77d into rust-lang:masterOct 6, 2024
@rustbotrustbot added this to the 1.83.0 milestone Oct 6, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 6, 2024
Rollup merge of rust-lang#131001 - iyernaveenr:naveen_iyer/installation_clarity, r=onur-ozkan
add clarity for custom path installation
install.sysconfdir is another value, in addition to install.prefix, that could be set for custom path installation.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@iyernaveenr@rustbot@onur-ozkan@bors@Mark-Simulacrum@jieyouxu