Skip to content

File checksum hint follow up - #131139

Closed
Xaeroxe wants to merge 11 commits into
rust-lang:masterfrom
Xaeroxe:file-checksum-hint-follow-up
Closed

File checksum hint follow up#131139
Xaeroxe wants to merge 11 commits into
rust-lang:masterfrom
Xaeroxe:file-checksum-hint-follow-up

Conversation

@Xaeroxe

Copy link
Copy Markdown
Contributor

@weihanglo This is the follow-up PR to #126930 which addresses your comment #126930 (comment)

I'll rebase it onto the new master once #126930 is merged. The commit of interest is b48c5f1

@rustbot

Copy link
Copy Markdown
Collaborator

r? @cjgillot

rustbot has assigned @cjgillot.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 2, 2024
@rustbot

Copy link
Copy Markdown
Collaborator

The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging.

cc @davidtwco, @wesleywiser

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

@Xaeroxe

Copy link
Copy Markdown
ContributorAuthor

Let's see if I have permission to do this

@bors r? @weihanglo

@Xaeroxe

Copy link
Copy Markdown
ContributorAuthor

Disregard, moving this commit over to the beginning PR

@XaeroxeXaeroxe closed this Oct 2, 2024
@Xaeroxe
Xaeroxe deleted the file-checksum-hint-follow-up branch October 2, 2024 06:39
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-query-systemArea: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)A-run-makeArea: port run-make Makefiles to rmake.rsA-testsuiteArea: The testsuite used to check the correctness of rustcS-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Xaeroxe@rustbot@cjgillot@weihanglo