Uh oh!
There was an error while loading. Please reload this page.
Introduce SolverRelating type relation to the new solver - #131263
Conversation
rustbot
commented
Oct 4, 2024
changes to the core type system |
3c2a620 to
d543f4eCompare
This comment has been minimized.
This comment has been minimized.
d543f4e to
09afb0fCompare
This comment has been minimized.
This comment has been minimized.
09afb0f to
bac2557Comparecompiler-errors
commented
Oct 5, 2024
We could also, perhaps, get rid of |
Uh oh!
There was an error while loading. Please reload this page.
bors
commented
Oct 7, 2024
☔ The latest upstream changes (presumably #131226) made this pull request unmergeable. Please resolve the merge conflicts. |
…s, r=<try> Remove `CombineFields` This conflicts with rust-lang#131263, but if this one lands first then perhaps rust-lang#131263 could then go ahead and remove all the branching on solver in `TypeRelating`. We could perhaps then rename `TypeRelating` to `OldSolverRelating` or something, idk. r? lcnr
5fa0570 to
7ac5804Compare
This comment has been minimized.
This comment has been minimized.
7ac5804 to
747a3c6Compare
This comment has been minimized.
This comment has been minimized.
747a3c6 to
6673e4aCompare…s, r=lcnr Remove `CombineFields` This conflicts with rust-lang#131263, but if this one lands first then perhaps rust-lang#131263 could then go ahead and remove all the branching on solver in `TypeRelating`. We could perhaps then rename `TypeRelating` to `OldSolverRelating` or something, idk. r? lcnr
…s, r=lcnr Remove `CombineFields` This conflicts with rust-lang#131263, but if this one lands first then perhaps rust-lang#131263 could then go ahead and remove all the branching on solver in `TypeRelating`. We could perhaps then rename `TypeRelating` to `OldSolverRelating` or something, idk. r? lcnr
compiler-errors
commented
Oct 9, 2024
Now that the other PR landed, I believe this is ready |
6673e4a to
3fb3f4fCompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
lcnr
commented
Oct 10, 2024
r=me after review |
3fb3f4f to
8715bfbComparelcnr
commented
Oct 10, 2024
@bors r+ rollup=never |
bors
commented
Oct 10, 2024
bors
commented
Oct 10, 2024
bors
commented
Oct 10, 2024
☀️ Test successful - checks-actions |
rust-timer
commented
Oct 10, 2024
Finished benchmarking commit (8d94e06): comparison URL. Overall result: ❌ regressions - please read the text belowOur benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary -1.2%, secondary -0.1%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary 0.7%, secondary -2.1%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 774.326s -> 779.131s (0.62%) |
Redux of #128744.
Splits out relate for the new solver so that implementors don't need to implement it themselves.
r? lcnr