Skip to content

Update to LLVM 19.1.1 - #131293

Merged
bors merged 1 commit into
rust-lang:masterfrom
dianqk:llvm-19.1.1
Oct 6, 2024
Merged

Update to LLVM 19.1.1#131293
bors merged 1 commit into
rust-lang:masterfrom
dianqk:llvm-19.1.1

Conversation

@dianqk

Copy link
Copy Markdown
Member

No known issues are fixed this time.

r? @rust-lang/wg-llvm

@rustbot

Copy link
Copy Markdown
Collaborator

⚠️Warning⚠️

  • These commits modify submodules.

@rustbotrustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 5, 2024
@nikic

nikic commented Oct 5, 2024

Copy link
Copy Markdown
Contributor

@bors r+ rollup=never

@bors

bors commented Oct 5, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit 70260db has been approved by nikic

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 5, 2024
@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

The job x86_64-gnu-llvm-18 failed! Check out the build log: (web)(plain)

Click to see the possible cause of the failure (guessed by this bot)
------
> importing cache manifest from ghcr.io/rust-lang/rust-ci-cache:20950f2ccee3dff53a038adf5c1cf05231c0b30772617126a5f6478a66316a29cba9aead69f7bb0004886d32c1f8e6287542cf6d25130711c82d16a66201d4fe:
------
##[endgroup]
Setting extra environment values for docker: --env ENABLE_GCC_CODEGEN=1 --env GCC_EXEC_PREFIX=/usr/lib/gcc/
[CI_JOB_NAME=x86_64-gnu-llvm-18]
---
sccache: Starting the server...
##[group]Configure the build
configure: processing command line
configure: configure: build.configure-args := ['--build=x86_64-unknown-linux-gnu', '--llvm-root=/usr/lib/llvm-18', '--enable-llvm-link-shared', '--set', 'rust.randomize-layout=true', '--set', 'rust.thin-lto-import-instr-limit=10', '--set', 'change-id=99999999', '--enable-verbose-configure', '--enable-sccache', '--disable-manage-submodules', '--enable-locked-deps', '--enable-cargo-native-static', '--set', 'rust.codegen-units-std=1', '--set', 'dist.compression-profile=balanced', '--dist-compression-formats=xz', '--set', 'rust.lld=false', '--disable-dist-src', '--release-channel=nightly', '--enable-debug-assertions', '--enable-overflow-checks', '--enable-llvm-assertions', '--set', 'rust.verify-llvm-ir', '--set', 'rust.codegen-backends=llvm,cranelift,gcc', '--set', 'llvm.static-libstdcpp', '--enable-new-symbol-mangling']
configure: target.x86_64-unknown-linux-gnu.llvm-config := /usr/lib/llvm-18/bin/llvm-config
configure: llvm.link-shared := True
configure: rust.randomize-layout := True
configure: rust.thin-lto-import-instr-limit := 10
---
Downloaded boml v0.3.1
Compiling boml v0.3.1
Compiling y v0.1.0 (/checkout/compiler/rustc_codegen_gcc/build_system)
Finished `release` profile [optimized] target(s) in 3.70s
Running `/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-codegen/x86_64-unknown-linux-gnu/release/y test --use-system-gcc --use-backend gcc --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/cg_gcc --release --mini-tests --std-tests`
Using system GCC
[BUILD] example
[AOT] mini_core_hello_world
/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools/cg_gcc/mini_core_hello_world
abc

@nikic

nikic commented Oct 5, 2024

Copy link
Copy Markdown
Contributor
2024-10-05T14:07:30.4627940Z failures:
2024-10-05T14:07:30.4628774Z 2024-10-05T14:07:30.4629533Z ---- core::config::tests::download_ci_llvm stdout ----
2024-10-05T14:07:30.4630298Z thread 'core::config::tests::download_ci_llvm' panicked at src/core/config/tests.rs:33:5:
2024-10-05T14:07:30.4630892Z assertion `left == right` failed
2024-10-05T14:07:30.4631199Z left: true
2024-10-05T14:07:30.4632659Z right: false
2024-10-05T14:07:30.4632897Z 2024-10-05T14:07:30.4632913Z 2024-10-05T14:07:30.4633046Z failures:
2024-10-05T14:07:30.4633383Z core::config::tests::download_ci_llvm

This also happened during the last LLVM update but didn't affect bors, so I'm keeping this in the queue.

@bors

bors commented Oct 5, 2024

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 70260db with merge 85e2f55...

@bors

bors commented Oct 6, 2024

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: nikic
Pushing 85e2f55 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Oct 6, 2024
@bors
bors merged commit 85e2f55 into rust-lang:masterOct 6, 2024
@rustbotrustbot added this to the 1.83.0 milestone Oct 6, 2024
@dianqk
dianqk deleted the llvm-19.1.1 branch October 6, 2024 01:49
@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (85e2f55): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-6.7%[-6.7%, -6.7%]1
All ❌✅ (primary)--0

Max RSS (memory usage)

Results (primary -1.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-1.9%[-1.9%, -1.9%]1
Improvements ✅
(secondary)
--0
All ❌✅ (primary)-1.9%[-1.9%, -1.9%]1

Cycles

Results (primary -1.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-1.1%[-1.1%, -1.1%]1
Improvements ✅
(secondary)
--0
All ❌✅ (primary)-1.1%[-1.1%, -1.1%]1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 774.047s -> 774.072s (0.00%)
Artifact size: 329.49 MiB -> 329.50 MiB (0.00%)

@dianqkdianqk mentioned this pull request Oct 9, 2024
@workingjubileeworkingjubilee added the A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. label May 26, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@dianqk@rustbot@nikic@bors@rust-log-analyzer@rust-timer@nagisa@workingjubilee