Skip to content

Suppress import errors for traits that couldve applied for method lookup error - #131702

Merged
bors merged 1 commit into
rust-lang:masterfrom
compiler-errors:method-lookup-trait-warning
Oct 15, 2024
Merged

Suppress import errors for traits that couldve applied for method lookup error#131702
bors merged 1 commit into
rust-lang:masterfrom
compiler-errors:method-lookup-trait-warning

Conversation

@compiler-errors

Copy link
Copy Markdown
Contributor

Self-explanatory. I hit this quite often when refactoring in rustc, so even though this isn't really showing up as significant in the UI test suite, it probably will matter more for multi-module projects.

@rustbot

Copy link
Copy Markdown
Collaborator

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 14, 2024

@jieyouxujieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable, thanks!

@jieyouxu

Copy link
Copy Markdown
Member

ferrisCatRPlusRollup-200px

@bors

bors commented Oct 15, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit c3b696d has been approved by jieyouxu

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 15, 2024
@jieyouxujieyouxu assigned jieyouxu and unassigned wesleywiserOct 15, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 15, 2024
…iaskrgr
Rollup of 9 pull requests
Successful merges:
- rust-lang#122670 (Fix bug where `option_env!` would return `None` when env var is present but not valid Unicode)
- rust-lang#131095 (Use environment variables instead of command line arguments for merged doctests)
- rust-lang#131339 (Expand set_ptr_value / with_metadata_of docs)
- rust-lang#131652 (Move polarity into `PolyTraitRef` rather than storing it on the side)
- rust-lang#131675 (Update lint message for ABI not supported)
- rust-lang#131681 (Fix up-to-date checking for run-make tests)
- rust-lang#131702 (Suppress import errors for traits that couldve applied for method lookup error)
- rust-lang#131703 (Resolved python deprecation warning in publish_toolstate.py)
- rust-lang#131710 (Remove `'apostrophes'` from `rustc_parse_format`)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 15, 2024
…iaskrgr
Rollup of 9 pull requests
Successful merges:
- rust-lang#122670 (Fix bug where `option_env!` would return `None` when env var is present but not valid Unicode)
- rust-lang#131095 (Use environment variables instead of command line arguments for merged doctests)
- rust-lang#131339 (Expand set_ptr_value / with_metadata_of docs)
- rust-lang#131652 (Move polarity into `PolyTraitRef` rather than storing it on the side)
- rust-lang#131675 (Update lint message for ABI not supported)
- rust-lang#131681 (Fix up-to-date checking for run-make tests)
- rust-lang#131702 (Suppress import errors for traits that couldve applied for method lookup error)
- rust-lang#131703 (Resolved python deprecation warning in publish_toolstate.py)
- rust-lang#131710 (Remove `'apostrophes'` from `rustc_parse_format`)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 15, 2024
…iaskrgr
Rollup of 9 pull requests
Successful merges:
- rust-lang#122670 (Fix bug where `option_env!` would return `None` when env var is present but not valid Unicode)
- rust-lang#131095 (Use environment variables instead of command line arguments for merged doctests)
- rust-lang#131339 (Expand set_ptr_value / with_metadata_of docs)
- rust-lang#131652 (Move polarity into `PolyTraitRef` rather than storing it on the side)
- rust-lang#131675 (Update lint message for ABI not supported)
- rust-lang#131681 (Fix up-to-date checking for run-make tests)
- rust-lang#131702 (Suppress import errors for traits that couldve applied for method lookup error)
- rust-lang#131703 (Resolved python deprecation warning in publish_toolstate.py)
- rust-lang#131710 (Remove `'apostrophes'` from `rustc_parse_format`)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 2e2c433 into rust-lang:masterOct 15, 2024
@rustbotrustbot added this to the 1.84.0 milestone Oct 15, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 15, 2024
Rollup merge of rust-lang#131702 - compiler-errors:method-lookup-trait-warning, r=jieyouxu
Suppress import errors for traits that couldve applied for method lookup error
Self-explanatory. I hit this quite often when refactoring in rustc, so even though this isn't really showing up as significant in the UI test suite, it probably will matter more for multi-module projects.
flip1995 pushed a commit to flip1995/rust that referenced this pull request Oct 18, 2024
…iaskrgr
Rollup of 9 pull requests
Successful merges:
- rust-lang#122670 (Fix bug where `option_env!` would return `None` when env var is present but not valid Unicode)
- rust-lang#131095 (Use environment variables instead of command line arguments for merged doctests)
- rust-lang#131339 (Expand set_ptr_value / with_metadata_of docs)
- rust-lang#131652 (Move polarity into `PolyTraitRef` rather than storing it on the side)
- rust-lang#131675 (Update lint message for ABI not supported)
- rust-lang#131681 (Fix up-to-date checking for run-make tests)
- rust-lang#131702 (Suppress import errors for traits that couldve applied for method lookup error)
- rust-lang#131703 (Resolved python deprecation warning in publish_toolstate.py)
- rust-lang#131710 (Remove `'apostrophes'` from `rustc_parse_format`)
r? `@ghost`
`@rustbot` modify labels: rollup
rust-borsBot pushed a commit that referenced this pull request Feb 27, 2026
Rollup of 9 pull requests
Successful merges:
- #122670 (Fix bug where `option_env!` would return `None` when env var is present but not valid Unicode)
- #131095 (Use environment variables instead of command line arguments for merged doctests)
- #131339 (Expand set_ptr_value / with_metadata_of docs)
- #131652 (Move polarity into `PolyTraitRef` rather than storing it on the side)
- #131675 (Update lint message for ABI not supported)
- #131681 (Fix up-to-date checking for run-make tests)
- #131702 (Suppress import errors for traits that couldve applied for method lookup error)
- #131703 (Resolved python deprecation warning in publish_toolstate.py)
- #131710 (Remove `'apostrophes'` from `rustc_parse_format`)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@compiler-errors@rustbot@jieyouxu@bors@wesleywiser