Uh oh!
There was an error while loading. Please reload this page.
Fix uninlined_format_args in stable_mir - #131733
Merged
Merged
Conversation
rustbot
commented
Oct 15, 2024
Collaborator
Failed to set assignee to
|
rustbot
commented
Oct 15, 2024
Collaborator
rustbot
commented
Oct 15, 2024
Collaborator
jieyouxu
commented
Oct 15, 2024
Member
r? jieyouxu |
bors
commented
Oct 15, 2024
Collaborator
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 15, 2024
…mpiler-errors Rollup of 7 pull requests Successful merges: - rust-lang#129794 (uefi: Implement getcwd and chdir) - rust-lang#130568 (Make some float methods unstable `const fn`) - rust-lang#131521 (rename RcBox to RcInner for consistency) - rust-lang#131701 (Don't report `on_unimplemented` message for negative traits) - rust-lang#131705 (Fix most ui tests on emscripten target) - rust-lang#131733 (Fix uninlined_format_args in stable_mir) - rust-lang#131734 (Update `arm64e-apple-tvos` maintainer) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 15, 2024
Rollup merge of rust-lang#131733 - practicalrs:fix_uninlined_format_args, r=jieyouxu Fix uninlined_format_args in stable_mir Hi, This PR fixes some clippy warnings ``` warning: variables can be used directly in the `format!` string --> compiler/stable_mir/src/mir/pretty.rs:362:13 | 362 | write!(writer, "{kind}{:?}", place) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args = note: requested on the command line with `-W clippy::uninlined-format-args` help: change this to | 362 - write!(writer, "{kind}{:?}", place) 362 + write!(writer, "{kind}{place:?}") | ``` Best regards, Michal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This PR fixes some clippy warnings
Best regards,
Michal