Skip to content

abi/compatibility: also test Option-like types - #132002

Merged
bors merged 1 commit into
rust-lang:masterfrom
RalfJung:abi-compat-option-like
Oct 23, 2024
Merged

abi/compatibility: also test Option-like types#132002
bors merged 1 commit into
rust-lang:masterfrom
RalfJung:abi-compat-option-like

Conversation

@RalfJung

Copy link
Copy Markdown
Member

Adds tests for the decision here.

Cc @workingjubilee

@rustbot

Copy link
Copy Markdown
Collaborator

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 21, 2024
@RalfJung
RalfJungforce-pushed the abi-compat-option-like branch from d6c85a0 to b31b595CompareOctober 21, 2024 15:24
Comment threadtests/ui/abi/compatibility.rs Outdated
@RalfJung
RalfJungforce-pushed the abi-compat-option-like branch from b31b595 to d567fccCompareOctober 21, 2024 17:24
@workingjubileeworkingjubilee added the A-ABI Area: Concerning the application binary interface (ABI) label Oct 21, 2024
@compiler-errors

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Oct 22, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit d567fcc has been approved by compiler-errors

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 22, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 22, 2024
…=compiler-errors
abi/compatibility: also test Option-like types
Adds tests for the decision [here](rust-lang#130628 (comment)).
Cc `@workingjubilee`
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 22, 2024
…iaskrgr
Rollup of 4 pull requests
Successful merges:
- rust-lang#132002 (abi/compatibility: also test Option-like types)
- rust-lang#132026 (analyse: remove unused uncanonicalized field)
- rust-lang#132036 (Add a test case for rust-lang#131164)
- rust-lang#132040 (relnotes: fix stabilizations of `assume_init`)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 23, 2024
…iaskrgr
Rollup of 5 pull requests
Successful merges:
- rust-lang#131707 (Run most `core::num` tests in const context too)
- rust-lang#132002 (abi/compatibility: also test Option-like types)
- rust-lang#132026 (analyse: remove unused uncanonicalized field)
- rust-lang#132031 (Optimize `Rc<T>::default`)
- rust-lang#132040 (relnotes: fix stabilizations of `assume_init`)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 7e1dbae into rust-lang:masterOct 23, 2024
@rustbotrustbot added this to the 1.84.0 milestone Oct 23, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 23, 2024
Rollup merge of rust-lang#132002 - RalfJung:abi-compat-option-like, r=compiler-errors
abi/compatibility: also test Option-like types
Adds tests for the decision [here](rust-lang#130628 (comment)).
Cc ``@workingjubilee``
@RalfJung
RalfJung deleted the abi-compat-option-like branch October 23, 2024 17:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ABIArea: Concerning the application binary interface (ABI)S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@RalfJung@rustbot@compiler-errors@bors@Noratrieb@davidtwco@workingjubilee