Skip to content

Rollup of 3 pull requests - #132171

Merged
bors merged 7 commits into
rust-lang:masterfrom
matthiaskrgr:rollup-tp75ge7
Oct 26, 2024
Merged

Rollup of 3 pull requests#132171
bors merged 7 commits into
rust-lang:masterfrom
matthiaskrgr:rollup-tp75ge7

Conversation

@matthiaskrgr

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

jieyouxuand others added 7 commits October 25, 2024 10:30
Instead of passing around random n-tuples of e.g. `(gate_name, attr_sp,
since)`.
This updates the "start" and "stop" methods
of the test runner to use the standalone package
server.
- removed extra bits from predicates queries that are no longer needed in the new system
- removed the need for `non_erasable_generics` to take in tcx and DefId, removed unused arguments in callers
Use `Enabled{Lang,Lib}Feature` instead of n-tuples
Instead of passing around e.g. `(gate_name, attr_span, stable_since)` 3-tuples for enabled lang features or `(gate_name, attr_span)` 2-tuples for enabled lib features, use `Enabled{Lang,Lib}Feature` structs with named fields.
Also did some minor code-golfing of involved iterator chains to hopefully make them easier to follow.
Follow-up to rust-lang#132098 (comment) cc `@RalfJung.`
Update Fuchsia CI script for package serving
This updates the "start" and "stop" methods
of the test runner to use the standalone package
server.
r? `@tmandry`
…ler-errors
Effects cleanup
- removed extra bits from predicates queries that are no longer needed in the new system
- removed the need for `non_erasable_generics` to take in tcx and DefId, removed unused arguments in callers
r? compiler-errors
@rustbotrustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Oct 26, 2024
@matthiaskrgr

Copy link
Copy Markdown
MemberAuthor

@bors r+ rollup=never p=3

@bors

bors commented Oct 26, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit 56463df has been approved by matthiaskrgr

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 26, 2024
@bors

bors commented Oct 26, 2024

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 56463df with merge 80d0d92...

@bors

bors commented Oct 26, 2024

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 80d0d92 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Oct 26, 2024
@bors
bors merged commit 80d0d92 into rust-lang:masterOct 26, 2024
@rustbotrustbot added this to the 1.84.0 milestone Oct 26, 2024
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#132114Use Enabled{Lang,Lib}Feature instead of n-tuples7cad740232c1e867266ab23d4dc3567171c2844e (link)
#132163Update Fuchsia CI script for package serving9e1623c780cc2eb6aeed36a8020f5ecb3451d913 (link)
#132168Effects cleanup68dfeba9119353271962448991f64cbe874ea1b3 (link)

previous master: ae4c6b6640

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@ZalatharZalathar mentioned this pull request Oct 26, 2024
@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (80d0d92): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-0.3%[-0.3%, -0.2%]2
Improvements ✅
(secondary)
-0.3%[-0.4%, -0.2%]16
All ❌✅ (primary)-0.3%[-0.3%, -0.2%]2

Max RSS (memory usage)

Results (primary -0.8%, secondary 1.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
2.9%[1.7%, 5.3%]3
Improvements ✅
(primary)
-0.8%[-0.8%, -0.8%]1
Improvements ✅
(secondary)
-2.5%[-2.5%, -2.5%]1
All ❌✅ (primary)-0.8%[-0.8%, -0.8%]1

Cycles

Results (secondary -3.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-3.9%[-4.7%, -3.0%]2
All ❌✅ (primary)--0

Binary size

Results (primary -0.1%, secondary -0.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-0.1%[-0.4%, -0.0%]105
Improvements ✅
(secondary)
-0.4%[-0.5%, -0.0%]33
All ❌✅ (primary)-0.1%[-0.4%, -0.0%]105

Bootstrap: 785.03s -> 782.08s (-0.38%)
Artifact size: 333.74 MiB -> 333.70 MiB (-0.01%)

@matthiaskrgr
matthiaskrgr deleted the rollup-tp75ge7 branch January 25, 2025 09:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-query-systemArea: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)A-testsuiteArea: The testsuite used to check the correctness of rustcmerged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@matthiaskrgr@bors@rust-timer@rustbot@jieyouxu@claywilkinson@tmandry@fee1-dead