Uh oh!
There was an error while loading. Please reload this page.
expand: Stop using artificial ast::Item for macros loaded from metadata - #132192
Merged
Conversation
rustbot
commented
Oct 26, 2024
Collaborator
Merged
compiler-errors
approved these changes
Oct 26, 2024
compiler-errors
commented
Oct 26, 2024
Contributor
very nice, r=me when green |
This comment has been minimized.
This comment has been minimized.
compiler-errors
commented
Oct 26, 2024
Contributor
gotta fix tools it seems, those should be trivial i think. r=me or pass back over to me if you think it needs a re-review. @rustbot author |
klensy
reviewed
Oct 26, 2024
Uh oh!
There was an error while loading. Please reload this page.
compiler-errors
commented
Oct 27, 2024
Contributor
Thanks! @bors r+ rollup |
bors
commented
Oct 27, 2024
Collaborator
workingjubilee added a commit
to workingjubilee/rustc
that referenced
this pull request
Oct 27, 2024
expand: Stop using artificial `ast::Item` for macros loaded from metadata You don't need a full `Item` for that, and not using a piece of AST helps with rust-lang#131808.
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 27, 2024
…kingjubilee Rollup of 5 pull requests Successful merges: - rust-lang#132123 (allow type-based search on foreign functions) - rust-lang#132170 (Add a Few Codegen Tests) - rust-lang#132183 (Fix code HTML items making big blocks if too long) - rust-lang#132192 (expand: Stop using artificial `ast::Item` for macros loaded from metadata) - rust-lang#132205 (docs: Correctly link riscv32e from platform-support.md) r? `@ghost` `@rustbot` modify labels: rollup
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 27, 2024
…kingjubilee Rollup of 4 pull requests Successful merges: - rust-lang#132123 (allow type-based search on foreign functions) - rust-lang#132183 (Fix code HTML items making big blocks if too long) - rust-lang#132192 (expand: Stop using artificial `ast::Item` for macros loaded from metadata) - rust-lang#132205 (docs: Correctly link riscv32e from platform-support.md) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 27, 2024
Rollup merge of rust-lang#132192 - petrochenkov:macfa, r=compiler-errors expand: Stop using artificial `ast::Item` for macros loaded from metadata You don't need a full `Item` for that, and not using a piece of AST helps with rust-lang#131808.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You don't need a full
Itemfor that, and not using a piece of AST helps with #131808.