Uh oh!
There was an error while loading. Please reload this page.
Use protected visibility for librustc_driver.so when possible - #132219
Use protected visibility for librustc_driver.so when possible#132219bjorn3 wants to merge 1 commit into
Conversation
This should make rustc faster to start by reducing the load on the dynamic linker.
bjorn3
commented
Oct 27, 2024
@bors try @rust-timer queue |
rustbot
commented
Oct 27, 2024
This comment has been minimized.
This comment has been minimized.
bjorn3
commented
Oct 27, 2024
Missed #131634 which already does this and more. |
bors
commented
Oct 27, 2024
…=<try> Use protected visibility for librustc_driver.so when possible This should make rustc faster to start by reducing the load on the dynamic linker.
saethlin
commented
Oct 28, 2024
This has been trying for 14 hours? Wat? |
jieyouxu
commented
Oct 28, 2024
@bors r- retry |
jieyouxu
commented
Oct 28, 2024
@bors r- |
…=<try> Use protected visibility for librustc_driver.so when possible This should make rustc faster to start by reducing the load on the dynamic linker.
bors
commented
Oct 28, 2024
jieyouxu
commented
Oct 28, 2024
@bors r- retry |
jieyouxu
commented
Oct 28, 2024
@bors r- |
bors
commented
Oct 28, 2024
…=<try> Use protected visibility for librustc_driver.so when possible This should make rustc faster to start by reducing the load on the dynamic linker.
jieyouxu
commented
Oct 28, 2024
? |
bors
commented
Oct 28, 2024
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
rust-timer
commented
Oct 28, 2024
Finished benchmarking commit (b3bffc2): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary -2.0%, secondary -2.8%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary -6.2%, secondary -6.6%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 783.63s -> 780.424s (-0.41%) |
This should make rustc faster to start by reducing the load on the dynamic linker.