Also treat `impl` definition parent as transparent regarding modules by Urgau · Pull Request #132453 · rust-lang/rust

Urgau · 2024-11-01T11:49:27Z

This PR changes the non_local_definitions lint logic to also consider impl definition parent as transparent regarding modules.

See tests and explanation in the changes.

@rustbot label +L-non_local_definitions
Fixes (after beta-backport)#132427
cc @leighmcculloch
r? @jieyouxu

jieyouxu · 2024-11-01T12:12:35Z

(Nit: did u mean threat -> thread in PR title and commit msg?)

Urgau · 2024-11-01T12:14:52Z

(Nit: did u mean threat -> thread in PR title and commit msg?)

Nope, I meant treat.

jieyouxu

Thanks, this looks reasonable to me, one question about uhh more "exotic" code patterns.

jieyouxu

Thanks, this LGTM, feel free to r=me after PR CI is green.

jieyouxu · 2024-11-01T12:36:02Z

Nominating for beta-backport: this PR fixes non_local_definitions lint to not mistakenly fire on a code pattern such as:

pubmod auth {const _:() = {pubenumArbitraryContext{}const _:() = {implArbitraryContext{}};};}

where the anon-const was nested inside modules but to the impl, we only considered it to be transparent to the anon-const but not the module. This PR fixes that by considering impl definition parent as transparent with respect to modules. This was reported as a regression in #132427.

(When I say "anon-const" I mean a const with an anonymous name const _, not the anon const in types)

@rustbot label +beta-nominated

Urgau · 2024-11-01T16:26:28Z

@bors r=jieyouxu

bors · 2024-11-01T16:26:31Z

📌 Commit 37db365 has been approved by jieyouxu

It is now in the queue for this repository.

…sparent, r=jieyouxu Also treat `impl` definition parent as transparent regarding modules This PR changes the `non_local_definitions` lint logic to also consider `impl` definition parent as transparent regarding modules. See tests and explanation in the changes. `@rustbot` label +L-non_local_definitions Fixes *(after beta-backport)* rust-lang#132427 cc `@leighmcculloch` r? `@jieyouxu`

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#131037 (Move versioned Apple LLVM targets from `rustc_target` to `rustc_codegen_ssa`) - rust-lang#132147 (Tweak E0277 output when a candidate is available) - rust-lang#132398 (Add a couple of intra-doc links to str) - rust-lang#132453 (Also treat `impl` definition parent as transparent regarding modules) - rust-lang#132457 (Remove needless #![feature(asm_experimental_arch)] from loongarch64 inline assembly test) - rust-lang#132465 (refactor(config): remove FIXME statement in comment of `omit-git-hash`) - rust-lang#132471 (Add a bunch of mailmap entries) r? `@ghost` `@rustbot` modify labels: rollup

…sparent, r=jieyouxu Also treat `impl` definition parent as transparent regarding modules This PR changes the `non_local_definitions` lint logic to also consider `impl` definition parent as transparent regarding modules. See tests and explanation in the changes. ``@rustbot`` label +L-non_local_definitions Fixes *(after beta-backport)* rust-lang#132427 cc ``@leighmcculloch`` r? ``@jieyouxu``

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#125579 (Add `--print host-tuple` to print host target tuple) - rust-lang#132398 (Add a couple of intra-doc links to str) - rust-lang#132453 (Also treat `impl` definition parent as transparent regarding modules) - rust-lang#132457 (Remove needless #![feature(asm_experimental_arch)] from loongarch64 inline assembly test) - rust-lang#132465 (refactor(config): remove FIXME statement in comment of `omit-git-hash`) - rust-lang#132471 (Add a bunch of mailmap entries) Failed merges: - rust-lang#131037 (Move versioned Apple LLVM targets from `rustc_target` to `rustc_codegen_ssa`) r? `@ghost` `@rustbot` modify labels: rollup

…sparent, r=jieyouxu Also treat `impl` definition parent as transparent regarding modules This PR changes the `non_local_definitions` lint logic to also consider `impl` definition parent as transparent regarding modules. See tests and explanation in the changes. ```@rustbot``` label +L-non_local_definitions Fixes *(after beta-backport)* rust-lang#132427 cc ```@leighmcculloch``` r? ```@jieyouxu```

…sparent, r=jieyouxu Also treat `impl` definition parent as transparent regarding modules This PR changes the `non_local_definitions` lint logic to also consider `impl` definition parent as transparent regarding modules. See tests and explanation in the changes. ````@rustbot```` label +L-non_local_definitions Fixes *(after beta-backport)* rust-lang#132427 cc ````@leighmcculloch```` r? ````@jieyouxu````

…sparent, r=jieyouxu Also treat `impl` definition parent as transparent regarding modules This PR changes the `non_local_definitions` lint logic to also consider `impl` definition parent as transparent regarding modules. See tests and explanation in the changes. `````@rustbot````` label +L-non_local_definitions Fixes *(after beta-backport)* rust-lang#132427 cc `````@leighmcculloch````` r? `````@jieyouxu`````

…iaskrgr Rollup of 11 pull requests Successful merges: - rust-lang#131037 (Move versioned Apple LLVM targets from `rustc_target` to `rustc_codegen_ssa`) - rust-lang#132170 (Add a Few Codegen Tests) - rust-lang#132333 (rust_analyzer_helix.toml: add library/ manifest) - rust-lang#132398 (Add a couple of intra-doc links to str) - rust-lang#132411 (CI: switch dist-x86_64-musl to free runner) - rust-lang#132453 (Also treat `impl` definition parent as transparent regarding modules) - rust-lang#132457 (Remove needless #![feature(asm_experimental_arch)] from loongarch64 inline assembly test) - rust-lang#132465 (refactor(config): remove FIXME statement in comment of `omit-git-hash`) - rust-lang#132466 (Account for late-bound depth when capturing all opaque lifetimes.) - rust-lang#132471 (Add a bunch of mailmap entries) - rust-lang#132488 (Remove or fix some more `FIXME(async_closure)`) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#131037 (Move versioned Apple LLVM targets from `rustc_target` to `rustc_codegen_ssa`) - rust-lang#132398 (Add a couple of intra-doc links to str) - rust-lang#132453 (Also treat `impl` definition parent as transparent regarding modules) - rust-lang#132457 (Remove needless #![feature(asm_experimental_arch)] from loongarch64 inline assembly test) - rust-lang#132465 (refactor(config): remove FIXME statement in comment of `omit-git-hash`) - rust-lang#132466 (Account for late-bound depth when capturing all opaque lifetimes.) - rust-lang#132471 (Add a bunch of mailmap entries) - rust-lang#132488 (Remove or fix some more `FIXME(async_closure)`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#132453 - Urgau:non_local_defs-impl-mod-transparent, r=jieyouxu Also treat `impl` definition parent as transparent regarding modules This PR changes the `non_local_definitions` lint logic to also consider `impl` definition parent as transparent regarding modules. See tests and explanation in the changes. ``````@rustbot`````` label +L-non_local_definitions Fixes *(after beta-backport)* rust-lang#132427 cc ``````@leighmcculloch`````` r? ``````@jieyouxu``````

apiraino · 2024-11-07T15:14:17Z

Beta backport accepted as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle.

@rustbot label +beta-accepted

[beta] backports - rustdoc: skip stability inheritance for some item kinds rust-lang#132481 - Avoid use imports in thread_local_inner! in static rust-lang#132101 - Also treat `impl` definition parent as transparent regarding modules rust-lang#132453 - Revert "Avoid nested replacement ranges" from rust-lang#129346. rust-lang#132587 r? cuviper

rustbot assigned jieyouxu Nov 1, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. L-non_local_definitions Lint: non_local_definitions labels Nov 1, 2024

Urgau mentioned this pull request Nov 1, 2024
Issue between non_local_definitions and soroban-sdk #132427
Closed

Urgau changed the title ~~Also threat impl definition parent as transparent regarding modules~~Also treat impl definition parent as transparent regarding modulesNov 1, 2024

jieyouxu approved these changes Nov 1, 2024
View reviewed changes

Comment threadtests/ui/lint/non-local-defs/convoluted-locals-131474-with-mods.rs Outdated

Urgau force-pushed the non_local_defs-impl-mod-transparent branch 2 times, most recently from 0dda46d to 6ae4697Compare November 1, 2024 12:30

jieyouxu approved these changes Nov 1, 2024
View reviewed changes

rustbot added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Nov 1, 2024

jieyouxu reviewed Nov 1, 2024
View reviewed changes

Comment threadtests/ui/lint/non-local-defs/convoluted-locals-132427.rs

Urgau force-pushed the non_local_defs-impl-mod-transparent branch from 6ae4697 to 54c46c0Compare November 1, 2024 14:39

Also treat impl definition parent as transparent regarding modules
37db365

Urgau force-pushed the non_local_defs-impl-mod-transparent branch from 54c46c0 to 37db365Compare November 1, 2024 15:07

jieyouxu approved these changes Nov 1, 2024
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 1, 2024

matthiaskrgr mentioned this pull request Nov 1, 2024
Rollup of 7 pull requests #132476
Closed

matthiaskrgr mentioned this pull request Nov 2, 2024
Rollup of 6 pull requests #132485
Closed

workingjubilee mentioned this pull request Nov 2, 2024
Rollup of 7 pull requests #132490
Closed

matthiaskrgr mentioned this pull request Nov 2, 2024
Rollup of 8 pull requests #132491
Closed

workingjubilee mentioned this pull request Nov 2, 2024
Rollup of 10 pull requests #132496
Closed

matthiaskrgr mentioned this pull request Nov 2, 2024
Rollup of 11 pull requests #132497
Merged

bors merged commit fa69b67 into rust-lang:masterNov 2, 2024

rustbot added this to the 1.84.0 milestone Nov 2, 2024

rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Nov 7, 2024

cuviper mentioned this pull request Nov 7, 2024
[beta] backports #132733
Merged

cuviper modified the milestones: 1.84.0, 1.83.0 Nov 7, 2024

cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Nov 7, 2024

Navigation Menu

Uh oh!

Uh oh!

Also treat `impl` definition parent as transparent regarding modules - #132453

Also treat `impl` definition parent as transparent regarding modules#132453
bors merged 1 commit into
rust-lang:masterfrom
Urgau:non_local_defs-impl-mod-transparent

Urgau commented Nov 1, 2024

Uh oh!

jieyouxu commented Nov 1, 2024

Uh oh!

Urgau commented Nov 1, 2024

Uh oh!

jieyouxu left a comment

Uh oh!

Uh oh!

jieyouxu left a comment

Uh oh!

jieyouxu commented Nov 1, 2024•
edited
Loading

Uh oh!

Uh oh!

Urgau commented Nov 1, 2024

Uh oh!

bors commented Nov 1, 2024

Uh oh!

apiraino commented Nov 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Uh oh!

Conversation

Urgau commented Nov 1, 2024

Uh oh!

jieyouxu commented Nov 1, 2024

Uh oh!

Urgau commented Nov 1, 2024

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

jieyouxu commented Nov 1, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Urgau commented Nov 1, 2024

Uh oh!

bors commented Nov 1, 2024

Uh oh!

apiraino commented Nov 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jieyouxu commented Nov 1, 2024•
edited
Loading