Uh oh!
There was an error while loading. Please reload this page.
Simplify FFI calls for -Ztime-llvm-passes and -Zprint-codegen-stats - #132590
Merged
Conversation
rustbot
commented
Nov 4, 2024
Collaborator
r? @Nadrieril rustbot has assigned @Nadrieril. Use |
Zalathar
commented
Nov 4, 2024
MemberAuthor
(Alternatively we could just delete these, but they do seem plausibly useful to somebody, and with the new implementation they’re not so bad.) |
Zalatharforce-pushed
the
z-timings-stats
branch
from
November 4, 2024 09:31
8f901e5 to
5bfa0b1CompareNadrieril
commented
Nov 4, 2024
Member
Looks reasonable enough, but r? compiler |
fee1-dead
commented
Nov 6, 2024
Member
r? compiler |
jieyouxu
commented
Nov 7, 2024
Member
r? jieyouxu |
jieyouxu
commented
Nov 8, 2024
Member
@bors r+ rollup |
bors
commented
Nov 8, 2024
Collaborator
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 8, 2024
Rollup of 5 pull requests Successful merges: - rust-lang#132161 ([StableMIR] A few fixes to pretty printing) - rust-lang#132389 (coverage: Simplify parts of coverage graph creation) - rust-lang#132452 (coverage: Extract safe FFI wrapper functions to `llvm_cov`) - rust-lang#132590 (Simplify FFI calls for `-Ztime-llvm-passes` and `-Zprint-codegen-stats`) - rust-lang#132738 (Initialize channel `Block`s directly on the heap) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 8, 2024
Rollup merge of rust-lang#132590 - Zalathar:z-timings-stats, r=jieyouxu Simplify FFI calls for `-Ztime-llvm-passes` and `-Zprint-codegen-stats` The existing code for these unstable LLVM-infodump flags was jumping through hoops to pass an allocated C string across the FFI boundary, when it's much simpler to just write to a `&RustString` instead.
mati865 pushed a commit
to mati865/rust
that referenced
this pull request
Nov 12, 2024
Simplify FFI calls for `-Ztime-llvm-passes` and `-Zprint-codegen-stats` The existing code for these unstable LLVM-infodump flags was jumping through hoops to pass an allocated C string across the FFI boundary, when it's much simpler to just write to a `&RustString` instead.
mati865 pushed a commit
to mati865/rust
that referenced
this pull request
Nov 12, 2024
Rollup of 5 pull requests Successful merges: - rust-lang#132161 ([StableMIR] A few fixes to pretty printing) - rust-lang#132389 (coverage: Simplify parts of coverage graph creation) - rust-lang#132452 (coverage: Extract safe FFI wrapper functions to `llvm_cov`) - rust-lang#132590 (Simplify FFI calls for `-Ztime-llvm-passes` and `-Zprint-codegen-stats`) - rust-lang#132738 (Initialize channel `Block`s directly on the heap) r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing code for these unstable LLVM-infodump flags was jumping through hoops to pass an allocated C string across the FFI boundary, when it's much simpler to just write to a
&RustStringinstead.