Skip to content

document type_implements_trait - #132608

Merged
bors merged 2 commits into
rust-lang:masterfrom
mejrs:type_impls_trait
Nov 5, 2024
Merged

document type_implements_trait#132608
bors merged 2 commits into
rust-lang:masterfrom
mejrs:type_impls_trait

Conversation

@mejrs

@mejrsmejrs commented Nov 4, 2024

Copy link
Copy Markdown
Member

Rendered:

image

r? @compiler-errors

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 4, 2024
/// ```
///
/// In most cases you should instead create an [Obligation](traits::Obligation)
/// and check whether it holds, because it properly handles higher ranked traits

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// and check whether it holds, because it properly handles higher ranked traits
/// and check whether it holds via `evaluate_obligation` or one of its helper functions like `predicate_must_hold_modulo_regions`, because it properly handles higher ranked traits

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps

@compiler-errors

Copy link
Copy Markdown
Contributor

@rustbot author

please edit this to explain what to do instead, then r=me

@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 4, 2024
@mejrs

mejrs commented Nov 5, 2024

Copy link
Copy Markdown
MemberAuthor

@rustbot ready

Updated to:
image

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 5, 2024
@compiler-errors

Copy link
Copy Markdown
Contributor

thanks!

@bors r+ rollup

@bors

bors commented Nov 5, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit e37a3a8 has been approved by compiler-errors

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 5, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 5, 2024
…kingjubilee
Rollup of 11 pull requests
Successful merges:
- rust-lang#131153 (Improve duplicate derive Copy/Clone diagnostics)
- rust-lang#132025 (fix suggestion for diagnostic error E0027)
- rust-lang#132303 (More tests for non-exhaustive C-like enums in FFI)
- rust-lang#132492 (remove support for extern-block const intrinsics)
- rust-lang#132587 (Revert "Avoid nested replacement ranges" from rust-lang#129346.)
- rust-lang#132596 ([rustdoc] Fix `--show-coverage` when JSON output format is used)
- rust-lang#132598 (Clippy: Move some attribute lints to be early pass (post expansion))
- rust-lang#132601 (Update books)
- rust-lang#132606 (Improve example of `impl Pattern for &[char]`)
- rust-lang#132608 (document `type_implements_trait`)
- rust-lang#132609 (docs: fix grammar in doc comment at unix/process.rs)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 33ebfff into rust-lang:masterNov 5, 2024
@rustbotrustbot added this to the 1.84.0 milestone Nov 5, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 5, 2024
Rollup merge of rust-lang#132608 - mejrs:type_impls_trait, r=compiler-errors
document `type_implements_trait`
Rendered:
![image](https://github.com/user-attachments/assets/60c00e50-24fd-4b04-bb22-e71b479c0b29)
r? `@compiler-errors`
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@mejrs@compiler-errors@bors@rustbot