Skip to content

query/plumbing: adjust comment to reality - #132854

Merged
bors merged 1 commit into
rust-lang:masterfrom
RalfJung:query-key-limit
Nov 11, 2024
Merged

query/plumbing: adjust comment to reality#132854
bors merged 1 commit into
rust-lang:masterfrom
RalfJung:query-key-limit

Conversation

@RalfJung

@RalfJungRalfJung commented Nov 10, 2024

Copy link
Copy Markdown
Member

The limit for the query key size got changed recently in f51ec11 but the comment was not updated.

Though maybe it is time to intern CanonicalTypeOpAscribeUserTypeGoal rather than copying it everywhere?

r? @lcnr

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 10, 2024
@compiler-errors

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Nov 11, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit c8058c8 has been approved by compiler-errors

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 11, 2024
@bors

bors commented Nov 11, 2024

Copy link
Copy Markdown
Collaborator

⌛ Testing commit c8058c8 with merge 3a258d1...

@bors

bors commented Nov 11, 2024

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 3a258d1 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Nov 11, 2024
@bors
bors merged commit 3a258d1 into rust-lang:masterNov 11, 2024
@rustbotrustbot added this to the 1.84.0 milestone Nov 11, 2024
@RalfJung
RalfJung deleted the query-key-limit branch November 11, 2024 09:20
@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (3a258d1): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
3.8%[3.8%, 3.8%]1
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
--0
All ❌✅ (primary)--0

Max RSS (memory usage)

Results (primary -2.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-2.7%[-3.1%, -2.3%]2
Improvements ✅
(secondary)
--0
All ❌✅ (primary)-2.7%[-3.1%, -2.3%]2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 785.591s -> 786.407s (0.10%)
Artifact size: 335.31 MiB -> 335.32 MiB (0.00%)

mati865 pushed a commit to mati865/rust that referenced this pull request Nov 12, 2024
…-errors
query/plumbing: adjust comment to reality
The limit for the query key size got changed recently in rust-lang@f51ec11 but the comment was not updated.
Though maybe it is time to intern `CanonicalTypeOpAscribeUserTypeGoal` rather than copying it everywhere?
r? `@lcnr`
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@RalfJung@compiler-errors@bors@rust-timer@lcnr@rustbot