Skip to content

handle separate prefixes in clippy rules - #132873

Merged
bors merged 2 commits into
rust-lang:masterfrom
onur-ozkan:132867
Nov 11, 2024
Merged

handle separate prefixes in clippy rules#132873
bors merged 2 commits into
rust-lang:masterfrom
onur-ozkan:132867

Conversation

@onur-ozkan

@onur-ozkanonur-ozkan commented Nov 10, 2024

Copy link
Copy Markdown
Contributor

Fixes#132867

@onur-ozkan
handle separate prefixes in clippy args
6643586
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
add test coverage for separate clippy prefixes
469c8ba
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@rustbot

rustbot commented Nov 10, 2024

Copy link
Copy Markdown
Collaborator

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Nov 10, 2024
@rustbot

rustbot commented Nov 10, 2024

Copy link
Copy Markdown
Collaborator

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

jieyouxu
jieyouxu reviewed Nov 11, 2024
View reviewed changes

@jieyouxujieyouxu left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have a question, but the fix itself is very reasonable to me.

Comment threadsrc/bootstrap/src/core/build_steps/clippy.rs
jieyouxu
jieyouxu approved these changes Nov 11, 2024
View reviewed changes

@jieyouxujieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix itself is not related to lint level flag ordering, so this otherwise LGTM.

@jieyouxu

jieyouxu commented Nov 11, 2024

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Nov 11, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit 469c8ba has been approved by jieyouxu

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 11, 2024
@matthiaskrgrmatthiaskrgr mentioned this pull request Nov 11, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 11, 2024
@bors
Auto merge ofrust-lang#132902- matthiaskrgr:rollup-43qgg3t, r=matth…
2d8ab22
…iaskrgr
Rollup of 4 pull requests
Successful merges:
- rust-lang#129627 (Ensure that tail expr receive lifetime extension)
- rust-lang#130999 (Implement file_lock feature)
- rust-lang#132873 (handle separate prefixes in clippy rules)
- rust-lang#132891 (Remove `rustc_session::config::rustc_short_optgroups`)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 11, 2024
@bors
Auto merge ofrust-lang#132902- matthiaskrgr:rollup-43qgg3t, r=matth…
81eef2d
…iaskrgr
Rollup of 4 pull requests
Successful merges:
- rust-lang#129627 (Ensure that tail expr receive lifetime extension)
- rust-lang#130999 (Implement file_lock feature)
- rust-lang#132873 (handle separate prefixes in clippy rules)
- rust-lang#132891 (Remove `rustc_session::config::rustc_short_optgroups`)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 7319666 into rust-lang:masterNov 11, 2024
@rustbotrustbot added this to the 1.84.0 milestone Nov 11, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 11, 2024
@rust-timer
Unrolled build forrust-lang#132873
20a194e
Rollup merge of rust-lang#132873 - onur-ozkan:132867, r=jieyouxu
handle separate prefixes in clippy rules
Fixesrust-lang#132867
mati865 pushed a commit to mati865/rust that referenced this pull request Nov 12, 2024
@matthiaskrgr@mati865
Rollup merge ofrust-lang#132873- onur-ozkan:132867, r=jieyouxu
c365903
handle separate prefixes in clippy rules
Fixesrust-lang#132867
mati865 pushed a commit to mati865/rust that referenced this pull request Nov 12, 2024
@bors@mati865
Auto merge ofrust-lang#132902- matthiaskrgr:rollup-43qgg3t, r=matth…
cc1bfd8
…iaskrgr
Rollup of 4 pull requests
Successful merges:
- rust-lang#129627 (Ensure that tail expr receive lifetime extension)
- rust-lang#130999 (Implement file_lock feature)
- rust-lang#132873 (handle separate prefixes in clippy rules)
- rust-lang#132891 (Remove `rustc_session::config::rustc_short_optgroups`)
r? `@ghost`
`@rustbot` modify labels: rollup
@onur-ozkan
onur-ozkan deleted the 132867 branch November 12, 2024 06:33
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieyouxujieyouxujieyouxu approved these changes

Assignees

@jieyouxujieyouxu

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Milestone

1.84.0

Development

Successfully merging this pull request may close these issues.

./x clippy errors if lint levels are passed as multiple arguments

4 participants

@onur-ozkan@rustbot@jieyouxu@bors