Skip to content

Edit dangling pointers - #132983

Merged
bors merged 4 commits into
rust-lang:masterfrom
Anthony-Eid:dangling-pointers-lint
Jan 23, 2025
Merged

Edit dangling pointers #132983
bors merged 4 commits into
rust-lang:masterfrom
Anthony-Eid:dangling-pointers-lint

Conversation

@Anthony-Eid

@Anthony-EidAnthony-Eid commented Nov 13, 2024

Copy link
Copy Markdown
Contributor

Closes: #132283

@rustbot

rustbot commented Nov 13, 2024

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 13, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
Urgau
Urgau reviewed Nov 13, 2024
View reviewed changes
Comment threadcompiler/rustc_lint/messages.ftl Outdated
Comment threadcompiler/rustc_lint/src/lints.rs Outdated
@Urgau

Urgau commented Nov 13, 2024

Copy link
Copy Markdown
Member

After making the suggested changes, you will need to update the tests expectations, that can be done with ./x.py test --stage 1 tests/lint/ --bless.

@rustbot author
r? Urgau

@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 13, 2024
@rustbotrustbot assigned Urgau and unassigned pnkfelixNov 13, 2024
@Anthony-Eid

Anthony-Eid commented Nov 13, 2024

Copy link
Copy Markdown
ContributorAuthor

@Urgau Thank you for the fast feedback! I'll make the changes soon, I was having trouble understanding how everything worked. So I started reading the rust compiler book and was planning on fixing this once I was more confident in my understanding of the codebase.

@Urgau

Urgau commented Nov 13, 2024

Copy link
Copy Markdown
Member

The most relevant chapter is probably the one on #[derive(LintDiagnostic)], we also have a chapter on adding new tests which might be useful for updating the tests.

Anthony-Eidand others added 3 commits December 5, 2024 06:12
@Anthony-Eid
Start work on dangling pointers lint
de0cb6c
@Anthony-Eid@Urgau
Update compiler/rustc_lint/src/lints.rs
6d95b5b
Co-authored-by: Urgau <3616612+Urgau@users.noreply.github.com>
@Anthony-Eid@Urgau
Update compiler/rustc_lint/messages.ftl
bab8a41
Co-authored-by: Urgau <3616612+Urgau@users.noreply.github.com>
@Anthony-Eid
Anthony-Eidforce-pushed the dangling-pointers-lint branch from d605e95 to bab8a41CompareDecember 5, 2024 11:12
@Anthony-Eid
Anthony-Eid marked this pull request as ready for review December 5, 2024 11:12
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Urgau

Urgau commented Dec 5, 2024

Copy link
Copy Markdown
Member

@Anthony-Eid the test output also need to be updated, that can be done with ./x.py test --stage 1 tests/ui/lint/ --bless.

@alex-semenyuk

alex-semenyuk commented Jan 20, 2025

Copy link
Copy Markdown
Member

@Anthony-Eid
Thanks for your contribution
From wg-triage. Could you please take a look comments above?

@Anthony-Eid

Anthony-Eid commented Jan 22, 2025

Copy link
Copy Markdown
ContributorAuthor

@alex-semenyuk Thank you for the reminder! I just updated the lints with ./x test --stage 1 tests/ui/lint/ --bless. Is there anything else that I should do?

@Urgau

Urgau commented Jan 22, 2025

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Jan 22, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 12214db has been approved by Urgau

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 22, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 22, 2025
@matthiaskrgr
Rollup merge ofrust-lang#132983- Anthony-Eid:dangling-pointers-lint…
5a36359
…, r=Urgau
Edit dangling pointers
Closes: rust-lang#132283
@matthiaskrgrmatthiaskrgr mentioned this pull request Jan 22, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 22, 2025
@bors
Auto merge ofrust-lang#135891- matthiaskrgr:rollup-vqfwp83, r=matth…
1a60b67
…iaskrgr
Rollup of 10 pull requests
Successful merges:
- rust-lang#132983 (Edit dangling pointers )
- rust-lang#133154 (Reword resolve errors caused by likely missing crate in dep tree)
- rust-lang#135409 (Fix ICE-133117: multiple never-pattern arm doesn't have false_edge_start_block)
- rust-lang#135557 (Point at invalid utf-8 span on user's source code)
- rust-lang#135596 (Properly note when query stack is being cut off)
- rust-lang#135794 (Detect missing fields with default values and suggest `..`)
- rust-lang#135814 (ci: use ghcr buildkit image)
- rust-lang#135826 (Misc. `rustc_resolve` cleanups)
- rust-lang#135837 (Remove test panic from File::open)
- rust-lang#135856 (Library: Finalize dyn compatibility renaming)
r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgrmatthiaskrgr mentioned this pull request Jan 22, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 22, 2025
@bors
Auto merge ofrust-lang#135896- matthiaskrgr:rollup-g6rv7za, r=matth…
a30f915
…iaskrgr
Rollup of 9 pull requests
Successful merges:
- rust-lang#132983 (Edit dangling pointers )
- rust-lang#135409 (Fix ICE-133117: multiple never-pattern arm doesn't have false_edge_start_block)
- rust-lang#135557 (Point at invalid utf-8 span on user's source code)
- rust-lang#135596 (Properly note when query stack is being cut off)
- rust-lang#135794 (Detect missing fields with default values and suggest `..`)
- rust-lang#135814 (ci: use ghcr buildkit image)
- rust-lang#135826 (Misc. `rustc_resolve` cleanups)
- rust-lang#135837 (Remove test panic from File::open)
- rust-lang#135856 (Library: Finalize dyn compatibility renaming)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 9206ba5 into rust-lang:masterJan 23, 2025
@rustbotrustbot added this to the 1.86.0 milestone Jan 23, 2025
@jieyouxujieyouxu added the L-dangling_pointers_from_temporaries Lint: dangling_pointers_from_temporaries label May 1, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UrgauUrgauUrgau approved these changes

Assignees

@UrgauUrgau

Labels

L-dangling_pointers_from_temporariesLint: dangling_pointers_from_temporariesS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.86.0

Development

Successfully merging this pull request may close these issues.

Explore possible suggestions for dangling_pointers_from_temporaries lint

8 participants

@Anthony-Eid@rustbot@rust-log-analyzer@Urgau@alex-semenyuk@bors@pnkfelix@jieyouxu