Uh oh!
There was an error while loading. Please reload this page.
Rollup of 5 pull requests - #133032
Merged
Merged
Conversation
It will be slower to build and produce larger artifacts, but hopefully it will help catch debuginfo regressions sooner, especially for problems that LLVM assertions would uncover.
As described here UseOdrIndicator should be disabled on Windows since link.exe does not support duplicate weak definitions (https://reviews.llvm.org/D137227). Co-Authored-By: Bastian Kersting <bkersting@google.com>
…to contain files that do not have a "known-bug" directive Fixesrust-lang#133009
This file is copied from the rtems as initial implementation, and forgot to change the OS name in the comment. Signed-off-by: Huang Qi <huangqi3@xiaomi.com>
There's already `min-llvm-version`, and contributors were using `ignore-llvm-version: 20 - 99` to emulate `max-llvm-major-version: 19`.
…range like `N - 99` For tests that use `ignore-llvm-version: N - M`, replace that with `max-llvm-major-version: N-1`.
…-Simulacrum ci: Enable full `debuginfo-level=2` in `DEPLOY_ALT` It will be slower to build and produce larger artifacts, but hopefully it will help catch debuginfo regressions sooner, especially for problems that LLVM assertions would uncover. try-job: dist-x86_64-linux try-job: dist-x86_64-linux-alt
…ozkan compiletest: add `max-llvm-major-version` directive To complement existing `min-llvm-version` so contributors don't have to use `ignore-llvm-version: 20 - 99` to emulate `max-llvm-major-version: 19`. Closesrust-lang#132305. cc `@workingjubilee` who suggested this. ### Implementation steps - [x] 1. Implement the directive (this PR) - [x] 2. Open an accompanying dev-guide PR to describe the directive (rust-lang/rustc-dev-guide#2129) r? bootstrap
PassWrapper: disable UseOdrIndicator for Asan Win32 As described in https://reviews.llvm.org/D137227 UseOdrIndicator should be disabled on Windows since link.exe does not support duplicate weak definitions. Fixesrust-lang#124390. Credits also belong to `@1c3t3a` who worked with me on this. We are currently testing this on a Windows machine.
compiletest: known-bug / crashes: allow for an "auxiliary" directory to contain files that do not have a "known-bug" directive Fixesrust-lang#133009 r? `@jieyouxu`
Fix a copy-paste issue in the NuttX raw type definition This file is copied from the rtems as initial implementation, and forgot to change the OS name in the comment.
GuillaumeGomez
commented
Nov 14, 2024
MemberAuthor
@bors r+ p=5 rollup=never |
bors
commented
Nov 14, 2024
Collaborator
bors
commented
Nov 14, 2024
Collaborator
bors
commented
Nov 14, 2024
Collaborator
☀️ Test successful - checks-actions |
rust-timer
commented
Nov 14, 2024
Collaborator
📌 Perf builds for each rolled up PR:
previous master: dae7ac133b In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
rust-timer
commented
Nov 14, 2024
Collaborator
Finished benchmarking commit (a4cedec): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary 2.8%, secondary 1.9%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 786.305s -> 787.308s (0.13%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
debuginfo-level=2inDEPLOY_ALT#132010 (ci: Enable fulldebuginfo-level=2inDEPLOY_ALT)max-llvm-major-versiondirective #132310 (compiletest: addmax-llvm-major-versiondirective)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup