Skip to content

Change Visitor::visit_precise_capturing_arg so it returns a Visitor::Result - #133049

Merged
bors merged 1 commit into
rust-lang:masterfrom
maxcabrajac:visit_precise_capturing_arg
Nov 15, 2024
Merged

Change Visitor::visit_precise_capturing_arg so it returns a Visitor::Result#133049
bors merged 1 commit into
rust-lang:masterfrom
maxcabrajac:visit_precise_capturing_arg

Conversation

@maxcabrajac

@maxcabrajacmaxcabrajac commented Nov 14, 2024

Copy link
Copy Markdown
Contributor

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 14, 2024
@compiler-errors

Copy link
Copy Markdown
Contributor

r? compiler-errors @bors r+ rollup

@bors

bors commented Nov 15, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit 9fde49b has been approved by compiler-errors

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 15, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 15, 2024
…iaskrgr
Rollup of 4 pull requests
Successful merges:
- rust-lang#132817 (Recurse into APITs in `impl_trait_overcaptures`)
- rust-lang#133021 (Refactor `configure_annotatable`)
- rust-lang#133045 (tests: Test pac-ret flag merging on clang with LTO)
- rust-lang#133049 (Change Visitor::visit_precise_capturing_arg so it returns a Visitor::Result)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit a111716 into rust-lang:masterNov 15, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 15, 2024
Rollup merge of rust-lang#133049 - maxcabrajac:visit_precise_capturing_arg, r=compiler-errors
Change Visitor::visit_precise_capturing_arg so it returns a Visitor::Result
r? `@petrochenkov`
related to rust-lang#128974
@rustbotrustbot added this to the 1.84.0 milestone Nov 15, 2024
@workingjubilee

Copy link
Copy Markdown
Member

@bors r-

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 16, 2024
@maxcabrajac

Copy link
Copy Markdown
ContributorAuthor

Did this break something?

@compiler-errors

Copy link
Copy Markdown
Contributor

No, it just wasn't auto-closed by bors

@maxcabrajac

Copy link
Copy Markdown
ContributorAuthor

Ah now I get it! After getting merged, this still showed up in queue and messed things up

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@maxcabrajac@compiler-errors@bors@workingjubilee@petrochenkov@rustbot