Update cdb annotations for some debuginfo tests with cdb `10.0.26100.2161` by jieyouxu · Pull Request #133115 · rust-lang/rust

jieyouxu · 2024-11-16T16:57:31Z

GitHub CI runners recently updated to Windows Server 2022 (20241113) which included Windows Software Development Kit version 10.1.26100.1742, which transitively shipped a cdb version 10.0.26100.2161.

This changed some cdb output, causing 3 debuginfo tests to fail (see #133107, https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/msvc.20update.20causing.20debuginfo.20failures):

tests\debuginfo\numeric-types.rs
tests\debuginfo\range-types.rs
tests\debuginfo\unit-type.rs

I updated cdb annotations for these 3 tests locally with a matching cdb version. However, I am not by any means a cdb expert nor debuginfo expert, I just reblessed the tests to match whatever the new cdb version produces to unblock the tree. It is certainly possible that debuginfo improved/regressed/both with the newer cdb version.

try-job: x86_64-msvc

rustbot · 2024-11-16T16:57:38Z

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

jieyouxu · 2024-11-16T16:57:44Z

@bors try

Update cdb annotations for some debuginfo tests with cdb `10.0.26100.2161` GitHub CI runners [recently updated to Windows Server 2022 (20241113)](https://github.com/actions/runner-images/releases/tag/win22%2F20241113.3) which included Windows Software Development Kit version `10.1.26100.1742`, which transitively shipped a `cdb` version `10.0.26100.2161`. This changed some cdb output, causing 3 debuginfo tests to fail: ``` tests\debuginfo\numeric-types.rs tests\debuginfo\range-types.rs tests\debuginfo\unit-type.rs ``` I reblessed these 3 tests locally with a matching `cdb` version. However, I am not by any means a cdb expert nor debuginfo expert, I just reblessed the tests to match whatever the new cdb version produces to unblock the tree. try-job: x86_64-msvc

bors · 2024-11-16T16:58:55Z

⌛ Trying commit e70df09 with merge f0b30ab...

jieyouxu · 2024-11-16T17:01:09Z


-// cdb-only
-//@ min-cdb-version: 10.0.18317.1001
+//@ only-cdb


Remark: // cdb-only had no effect, but this test only contained cdb so this really doesn't change anything.

ChrisDenton

r=me if try comes back green

jieyouxu · 2024-11-16T18:25:43Z

Looks like they passed.

test [debuginfo-cdb] tests\debuginfo\numeric-types.rs ... ok
test [debuginfo-cdb] tests\debuginfo\range-types.rs ... ok
test [debuginfo-cdb] tests\debuginfo\unit-type.rs ... ok

bors · 2024-11-16T18:58:36Z

☀️ Try build successful - checks-actions
Build commit: f0b30ab (f0b30abab0ce27f5946baaa39dd1d7325e6f86c3)

ChrisDenton · 2024-11-16T18:59:18Z

@bors r+

bors · 2024-11-16T18:59:20Z

📌 Commit e70df09 has been approved by ChrisDenton

It is now in the queue for this repository.

bors · 2024-11-16T18:59:21Z

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

jieyouxu · 2024-11-16T18:59:41Z

@bors p=101 rollup=never

Update cdb annotations for some debuginfo tests with cdb `10.0.26100.2161` GitHub CI runners [recently updated to Windows Server 2022 (20241113)](https://github.com/actions/runner-images/releases/tag/win22%2F20241113.3) which included Windows Software Development Kit version `10.1.26100.1742`, which transitively shipped a `cdb` version `10.0.26100.2161`. This changed some cdb output, causing 3 debuginfo tests to fail (see rust-lang#133107, https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/msvc.20update.20causing.20debuginfo.20failures): ``` tests\debuginfo\numeric-types.rs tests\debuginfo\range-types.rs tests\debuginfo\unit-type.rs ``` I updated cdb annotations for these 3 tests locally with a matching `cdb` version. However, I am not by any means a cdb expert nor debuginfo expert, I just reblessed the tests to match whatever the new cdb version produces to unblock the tree. It is certainly possible that debuginfo improved/regressed/both with the newer cdb version. try-job: x86_64-msvc

bors · 2024-11-16T19:00:51Z

⌛ Testing commit e70df09 with merge f6afd1b...

bors · 2024-11-16T20:06:41Z

💔 Test failed - checks-actions

jieyouxu · 2024-11-16T20:07:02Z

Genuine failure

error: check directive(s) from `C:\a\rust\rust\tests\debuginfo\numeric-types.rs` not found in debugger output. errors:
(numeric-types.rs:86) ` [+0x000] __0 : 60 [Type: __int64]`
(numeric-types.rs:110) ` [+0x000] __0 : 0x78 [Type: unsigned __int64]`

jieyouxu · 2024-11-16T20:11:23Z

Of course, isize is different on 32-bit platforms

This is to unblock the tree, a proper fix will need to be investigated. I think the debuginfo test suite supports revisions, however debugger directives do not respect such revisions, which is problematic. It's that 32-bit and 64-bit msvc of course have different integer widths for `isize` and `usize`, meaning their underlying integer is different and thus printed differently.

jieyouxu · 2024-11-16T20:19:37Z

I'm going to mark this integer debuginfo test as //@ only-64bit to unblock the queue, proper fix can be a follow-up.

jieyouxu · 2024-11-16T20:23:39Z

@bors r=@ChrisDenton

bors · 2024-11-16T20:23:42Z

📌 Commit dccb6c0 has been approved by chrisdenton

It is now in the queue for this repository.

bors · 2024-11-16T20:24:51Z

⌛ Testing commit dccb6c0 with merge f2a3542...

cuviper · 2024-11-16T21:19:38Z

Nominating because such environmental changes will probably affect beta and the 1.83 release too.

@rustbot label beta-nominated

bors · 2024-11-16T23:28:31Z

☀️ Test successful - checks-actions
Approved by: chrisdenton
Pushing f2a3542 to master...

saethlin · 2024-11-16T23:31:03Z

@bors treeclosed-

Zalathar · 2024-11-16T23:59:04Z

I'm going to mark this integer debuginfo test as //@ only-64bit to unblock the queue, proper fix can be a follow-up.

Debuginfo commands used to support [rev], because they piggybacked on the main compiletest directive parser.

When I separated the debuginfo command parser from the compiletest directive parser in 1467dee, I didn't include revision support because it wasn't used by any tests that existed at the time.

rust-timer · 2024-11-17T00:45:57Z

Finished benchmarking commit (f2a3542): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (primary 4.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	4.3%	[4.3%, 4.3%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	4.3%	[4.3%, 4.3%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 788.11s -> 788.713s (0.08%)
Artifact size: 335.43 MiB -> 335.43 MiB (-0.00%)

apiraino · 2024-11-21T15:21:08Z

Beta backport accepted as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle.

@rustbot label +beta-accepted

[beta] backports - Enforce that raw lifetimes must be valid raw identifiers rust-lang#132363 - Update cdb annotations for some debuginfo tests with cdb `10.0.26100.2161` rust-lang#133115 r? cuviper

jieyouxu added 3 commits November 17, 2024 00:33

Update cdb annotations for numeric-types with cdb 10.0.26100.2161
1503279

Update cdb annotations for range-types.rs with cdb 10.0.26100.2161
94f3dcf

Update cdb annotations for unit-type.rs with cdb 10.0.26100.2161
e70df09

rustbot assigned Mark-Simulacrum Nov 16, 2024

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 16, 2024

jieyouxu added A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. O-windows-msvc Toolchain: MSVC, Operating system: Windows labels Nov 16, 2024

jieyouxu commented Nov 16, 2024
View reviewed changes

jieyouxu mentioned this pull request Nov 16, 2024
cdb debuginfo test failures #133107
Closed

ChrisDenton approved these changes Nov 16, 2024
View reviewed changes

jieyouxu assigned ChrisDenton and unassigned Mark-Simulacrum Nov 16, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 16, 2024

This comment has been minimized.
Sign in to view

bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 16, 2024

bors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 16, 2024

jieyouxu mentioned this pull request Nov 16, 2024
debuginfo: does the debugger annotations support revisions? #133121
Open

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 16, 2024

rustbot added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Nov 16, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 16, 2024

bors merged commit f2a3542 into rust-lang:masterNov 16, 2024

rustbot added this to the 1.84.0 milestone Nov 16, 2024

jieyouxu deleted the cdb branch November 17, 2024 06:45

rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Nov 21, 2024

cuviper mentioned this pull request Nov 21, 2024
[beta] backports #133305
Merged

cuviper modified the milestones: 1.84.0, 1.83.0 Nov 21, 2024

cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Nov 21, 2024

jieyouxu mentioned this pull request Dec 23, 2024
tests/debuginfo/numeric-types.rs test coverage became 64-bit only #134683
Open

Uh oh!

Uh oh!

Conversation

jieyouxu commented Nov 16, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Nov 16, 2024

Uh oh!

jieyouxu commented Nov 16, 2024

Uh oh!

bors commented Nov 16, 2024

Uh oh!

jieyouxuNov 16, 2024

Choose a reason for hiding this comment

Uh oh!

ChrisDenton left a comment

Choose a reason for hiding this comment

Uh oh!

jieyouxu commented Nov 16, 2024

Uh oh!

bors commented Nov 16, 2024

Uh oh!

ChrisDenton commented Nov 16, 2024

Uh oh!

bors commented Nov 16, 2024

Uh oh!

bors commented Nov 16, 2024

Uh oh!

jieyouxu commented Nov 16, 2024

Uh oh!

bors commented Nov 16, 2024

Uh oh!

This comment has been minimized.

bors commented Nov 16, 2024

Uh oh!

jieyouxu commented Nov 16, 2024

Uh oh!

jieyouxu commented Nov 16, 2024

Uh oh!

jieyouxu commented Nov 16, 2024

Uh oh!

jieyouxu commented Nov 16, 2024

Uh oh!

bors commented Nov 16, 2024

Uh oh!

bors commented Nov 16, 2024

Uh oh!

cuviper commented Nov 16, 2024

Uh oh!

bors commented Nov 16, 2024

Uh oh!

saethlin commented Nov 16, 2024

Uh oh!

Zalathar commented Nov 16, 2024

Uh oh!

rust-timer commented Nov 17, 2024

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

apiraino commented Nov 21, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

jieyouxu commented Nov 16, 2024•
edited
Loading