Skip to content

ci: use free runner in dist-i686-msvc - #133175

Merged
bors merged 1 commit into
rust-lang:masterfrom
marcoieni:dist-i686-msvc-free
Nov 20, 2024
Merged

ci: use free runner in dist-i686-msvc#133175
bors merged 1 commit into
rust-lang:masterfrom
marcoieni:dist-i686-msvc-free

Conversation

@marcoieni

@marcoienimarcoieni commented Nov 18, 2024

Copy link
Copy Markdown
Member

I already tried this in #132316 (comment) and I thought this would take too long. However, the slowness was due to llvm cache not being hit.
Instead, we need to compare timings with an llvm cache hit.
So now I'm trying again.

try-job: dist-i686-msvc

@rustbot

rustbot commented Nov 18, 2024

Copy link
Copy Markdown
Collaborator

r? @Kobzol

rustbot has assigned @Kobzol.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Nov 18, 2024
@marcoieni

marcoieni commented Nov 18, 2024

Copy link
Copy Markdown
MemberAuthor

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 18, 2024
@bors
Auto merge ofrust-lang#133175- MarcoIeni:dist-i686-msvc-free, r=<try>
d9c200f
ci: use free runner in dist-i686-msvc
try-job: dist-i686-msvc
@bors

bors commented Nov 18, 2024

Copy link
Copy Markdown
Collaborator

⌛ Trying commit 37ea202 with merge d9c200f...

@bors

bors commented Nov 18, 2024

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-actions
Build commit: d9c200f (d9c200fb6cca0329aad6583a402ccab3899b46c3)

@Kobzol

Kobzol commented Nov 18, 2024

Copy link
Copy Markdown
Member

@bors try

1 similar comment
@marcoieni

marcoieni commented Nov 18, 2024

Copy link
Copy Markdown
MemberAuthor

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 18, 2024
@bors
Auto merge ofrust-lang#133175- MarcoIeni:dist-i686-msvc-free, r=<try>
ff2ec6d
ci: use free runner in dist-i686-msvc
try-job: dist-i686-msvc
@bors

bors commented Nov 18, 2024

Copy link
Copy Markdown
Collaborator

⌛ Trying commit 37ea202 with merge ff2ec6d...

@marcoieni

marcoieni commented Nov 18, 2024

Copy link
Copy Markdown
MemberAuthor

What a committed team 😂

@bors

bors commented Nov 18, 2024

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-actions
Build commit: ff2ec6d (ff2ec6dc6341cee2ef3a8c8574b7e3c761705af1)

@marcoieni

marcoieni commented Nov 18, 2024

Copy link
Copy Markdown
MemberAuthor

Here's what happened in the bors try builds:

First build

image

Building llvm took 53 minutes.
image

Second build

image

Building llvm took 9 minutes
image

Outcome

To understand if timings are acceptable, we compare timings with the average time of an auto build.
We can assume that in the auto builds LLVM will be a cache hit most of the times, so imo we can merge this PR 👍

@marcoieni
marcoieni marked this pull request as ready for review November 18, 2024 21:05
@marcoienimarcoieni mentioned this pull request Nov 18, 2024
Merged
@Kobzol

Kobzol commented Nov 19, 2024

Copy link
Copy Markdown
Member

Yeah, looks good! Let's do this.

@bors r+

@bors

bors commented Nov 19, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit 37ea202 has been approved by Kobzol

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 19, 2024
@klensy

klensy commented Nov 19, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

There is no mention of actual time change after this pr.

I found few build time from before: 1.14, 1.20 (https://github.com/rust-lang-ci/rust/actions/runs/11862100462/job/33060812301), 1.26, so this degrades build times 1.5x?

@marcoieni

marcoieni commented Nov 19, 2024

Copy link
Copy Markdown
MemberAuthor

Hey, you are right, sorry!

This moves the build time from ~80 minutes to (apparently) 1h 53 minutes.

However, on average auto builds take more than 2h 30 minutes.

An auto build is done when the the slowest job finishes (which for now are often the macos ones).

So making this job slower has no impact on the auto builds velocity. 👍

@matthiaskrgrmatthiaskrgr mentioned this pull request Nov 19, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 19, 2024
@bors
Auto merge ofrust-lang#133219- matthiaskrgr:rollup-hnuq0zf, r=matth…
875df37
…iaskrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#123947 (Add vec_deque::Iter::as_slices and friends)
- rust-lang#125405 (Add std::thread::add_spawn_hook.)
- rust-lang#133175 (ci: use free runner in dist-i686-msvc)
- rust-lang#133183 (Mention std::fs::remove_dir_all in std::fs::remove_dir)
- rust-lang#133188 (Add `visit` methods to ast nodes that already have `walk`s on ast visitors)
- rust-lang#133201 (Remove `TokenKind::InvalidPrefix`)
- rust-lang#133207 (Default-enable `llvm_tools_enabled` when no `config.toml` is present)
- rust-lang#133213 (Correct the tier listing of `wasm32-wasip2`)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit c74e5a8 into rust-lang:masterNov 20, 2024
@rustbotrustbot added this to the 1.84.0 milestone Nov 20, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 20, 2024
@rust-timer
Unrolled build forrust-lang#133175
3be898d
Rollup merge of rust-lang#133175 - MarcoIeni:dist-i686-msvc-free, r=Kobzol
ci: use free runner in dist-i686-msvc
try-job: dist-i686-msvc
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@KobzolKobzol

Labels

A-testsuiteArea: The testsuite used to check the correctness of rustcS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.84.0

Development

Successfully merging this pull request may close these issues.

5 participants

@marcoieni@rustbot@bors@Kobzol@klensy