Skip to content

CI: use free runners for i686-gnu jobs - #133256

Merged
bors merged 1 commit into
rust-lang:masterfrom
marcoieni:use-linux-free-runners
Dec 6, 2024
Merged

CI: use free runners for i686-gnu jobs#133256
bors merged 1 commit into
rust-lang:masterfrom
marcoieni:use-linux-free-runners

Conversation

@marcoieni

@marcoienimarcoieni commented Nov 20, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Split the i686-gnu jobs in two to move them to free runners and reduce the use of large runners in CI.

try-job: i686-gnu-1
try-job: i686-gnu-2
try-job: i686-gnu-nopt-1
try-job: i686-gnu-nopt-2

@rustbot

rustbot commented Nov 20, 2024

Copy link
Copy Markdown
Collaborator

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Nov 20, 2024
@marcoieni

marcoieni commented Nov 20, 2024

Copy link
Copy Markdown
MemberAuthor

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 20, 2024
@bors
Auto merge ofrust-lang#133256- MarcoIeni:use-linux-free-runners, r=…
25f24b9
…<try>
CI: use free runners for 5 linux jobs
try-job: dist-arm-linux
try-job: i686-gnu
try-job: i686-gnu-nopt
try-job: x86_64-fuchsia
try-job: x86_64-gnu-distcheck
@bors

bors commented Nov 20, 2024

Copy link
Copy Markdown
Collaborator

⌛ Trying commit d7063fd with merge 25f24b9...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors

bors commented Nov 20, 2024

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-actions

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 20, 2024
@marcoieni

marcoieni commented Nov 20, 2024

Copy link
Copy Markdown
MemberAuthor

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 20, 2024
@bors
Auto merge ofrust-lang#133256- MarcoIeni:use-linux-free-runners, r=…
c1f0153
…<try>
CI: use free runners for 5 linux jobs
try-job: dist-arm-linux
try-job: i686-gnu
try-job: i686-gnu-nopt
try-job: x86_64-fuchsia
try-job: x86_64-gnu-distcheck
@bors

bors commented Nov 20, 2024

Copy link
Copy Markdown
Collaborator

⌛ Trying commit c50f770 with merge c1f0153...

@bors

bors commented Nov 20, 2024

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-actions

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@marcoieni

marcoieni commented Nov 21, 2024

Copy link
Copy Markdown
MemberAuthor

image

@marcoieni

marcoieni commented Nov 21, 2024

Copy link
Copy Markdown
MemberAuthor

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 21, 2024
@bors
Auto merge ofrust-lang#133256- MarcoIeni:use-linux-free-runners, r=…
7e36573
…<try>
CI: use free runners for 5 linux jobs
try-job: dist-arm-linux
try-job: i686-gnu
try-job: i686-gnu-nopt
try-job: x86_64-fuchsia
try-job: x86_64-gnu-distcheck
@bors

bors commented Nov 21, 2024

Copy link
Copy Markdown
Collaborator

⌛ Trying commit 3ada89a with merge 7e36573...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors

bors commented Nov 21, 2024

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-actions

@marcoieni

marcoieni commented Nov 21, 2024

Copy link
Copy Markdown
MemberAuthor

image

@marcoieni

marcoieni commented Nov 21, 2024

Copy link
Copy Markdown
MemberAuthor

@bors try

@bors

bors commented Nov 21, 2024

Copy link
Copy Markdown
Collaborator

⌛ Trying commit 535184d with merge 940450a...

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 21, 2024
@bors
Auto merge ofrust-lang#133256- MarcoIeni:use-linux-free-runners, r=…
940450a
…<try>
CI: use free runners for 5 linux jobs
try-job: dist-arm-linux
try-job: i686-gnu
try-job: i686-gnu-nopt
try-job: x86_64-fuchsia
try-job: x86_64-gnu-distcheck
@bors

bors commented Nov 21, 2024

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-actions
Build commit: 940450a (940450a274f0a885bed41898076b6a61c34ba7ad)

@marcoieni

marcoieni commented Nov 21, 2024

Copy link
Copy Markdown
MemberAuthor

They take too long, I'll try to split them
image

@marcoieni

marcoieni commented Nov 21, 2024•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Actually the dist-arm-linux job can't be split, because it's a dist job. So I need to remove it from this PR

EDIT: x86_64-gnu-distcheck is also hard to split because it only runs one task (the distcheck)

EDIT2: fuchsia doesn't seem it can be parallelized because it's just a build

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 2, 2024
@bors
Auto merge ofrust-lang#133256- MarcoIeni:use-linux-free-runners, r=…
d7bebc6
…<try>
CI: use free runners for i686-gnu jobs
try-job: i686-gnu-1
try-job: i686-gnu-2
try-job: i686-gnu-nopt-1
try-job: i686-gnu-nopt-2
@bors

bors commented Dec 2, 2024

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-actions
Build commit: d7bebc6 (d7bebc6fb7e4582344d8ba41abffc050c71a2e4e)

@marcoieni

marcoieni commented Dec 2, 2024

Copy link
Copy Markdown
MemberAuthor

I think this looks good.
image

@marcoieni
marcoieni requested a review from KobzolDecember 2, 2024 16:09
Kobzol
Kobzol reviewed Dec 2, 2024
View reviewed changes

@KobzolKobzol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a bit confusing that this environment variable is named SCRIPT, because that env. var. is actually used by non-Docker jobs. Normally, Docker jobs do not set this variable, as it is set inside Dockerfiles usually. The var. is read and executed by src/ci/run.sh.

I would perhaps rename the environment variable, to make it clearer that these are still Docker jobs. Maybe DOCKER_SCRIPT or something like that. Other than that LGTM.

Comment threadsrc/ci/github-actions/jobs.yml
@marcoieni
marcoieniforce-pushed the use-linux-free-runners branch from 1ffb7be to d555fafCompareDecember 3, 2024 07:16
@marcoieni
marcoieniforce-pushed the use-linux-free-runners branch from d555faf to b81391eCompareDecember 3, 2024 07:17
@marcoieni
marcoieni requested a review from KobzolDecember 3, 2024 07:18
@Kobzol

Kobzol commented Dec 3, 2024

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Dec 3, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit b81391e has been approved by Kobzol

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 3, 2024
fmease added a commit to fmease/rust that referenced this pull request Dec 4, 2024
@fmease
Rollup merge ofrust-lang#133256- MarcoIeni:use-linux-free-runners, …
ae59014
…r=Kobzol
CI: use free runners for i686-gnu jobs
try-job: i686-gnu-1
try-job: i686-gnu-2
try-job: i686-gnu-nopt-1
try-job: i686-gnu-nopt-2
@fmeasefmease mentioned this pull request Dec 4, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 5, 2024
@bors
Auto merge ofrust-lang#133878- fmease:rollup-ov1am8o, r=fmease
13c0180
Rollup of 6 pull requests
Successful merges:
- rust-lang#127565 (Teach rustc about the Xtensa VaListImpl)
- rust-lang#128004 (codegen `#[naked]` functions using global asm)
- rust-lang#133256 (CI: use free runners for i686-gnu jobs)
- rust-lang#133472 (Run TLS destructors for wasm32-wasip1-threads)
- rust-lang#133632 (CI: split x86_64-msvc job)
- rust-lang#133827 (CI: rfl: move job forward to Linux v6.13-rc1)
r? `@ghost`
`@rustbot` modify labels: rollup
fmease added a commit to fmease/rust that referenced this pull request Dec 5, 2024
@fmease
Rollup merge ofrust-lang#133256- MarcoIeni:use-linux-free-runners, …
405816a
…r=Kobzol
CI: use free runners for i686-gnu jobs
try-job: i686-gnu-1
try-job: i686-gnu-2
try-job: i686-gnu-nopt-1
try-job: i686-gnu-nopt-2
@fmeasefmease mentioned this pull request Dec 5, 2024
Closed
@marcoienimarcoieni mentioned this pull request Dec 5, 2024
Merged
jhpratt added a commit to jhpratt/rust that referenced this pull request Dec 5, 2024
@jhpratt
Rollup merge ofrust-lang#133256- MarcoIeni:use-linux-free-runners, …
4cc8473
…r=Kobzol
CI: use free runners for i686-gnu jobs
try-job: i686-gnu-1
try-job: i686-gnu-2
try-job: i686-gnu-nopt-1
try-job: i686-gnu-nopt-2
@jhprattjhpratt mentioned this pull request Dec 5, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 5, 2024
@bors
Auto merge ofrust-lang#133906- jhpratt:rollup-rj8matx, r=jhpratt
b4fab91
Rollup of 3 pull requests
Successful merges:
- rust-lang#133256 (CI: use free runners for i686-gnu jobs)
- rust-lang#133632 (CI: split x86_64-msvc job)
- rust-lang#133827 (CI: rfl: move job forward to Linux v6.13-rc1)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 5, 2024
@bors
Auto merge ofrust-lang#133906- jhpratt:rollup-rj8matx, r=jhpratt
ad1e478
Rollup of 3 pull requests
Successful merges:
- rust-lang#133256 (CI: use free runners for i686-gnu jobs)
- rust-lang#133632 (CI: split x86_64-msvc job)
- rust-lang#133827 (CI: rfl: move job forward to Linux v6.13-rc1)
r? `@ghost`
`@rustbot` modify labels: rollup
@GuillaumeGomezGuillaumeGomez mentioned this pull request Dec 5, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 5, 2024
@bors
Auto merge ofrust-lang#133940- GuillaumeGomez:rollup-nm1cz5j, r=Gui…
706141b
…llaumeGomez
Rollup of 8 pull requests
Successful merges:
- rust-lang#132155 (Always display first line of impl blocks even when collapsed)
- rust-lang#133256 (CI: use free runners for i686-gnu jobs)
- rust-lang#133607 (implement checks for tail calls)
- rust-lang#133821 (Replace black with ruff in `tidy`)
- rust-lang#133827 (CI: rfl: move job forward to Linux v6.13-rc1)
- rust-lang#133910 (Normalize target-cpus.rs stdout test for LLVM changes)
- rust-lang#133921 (Adapt codegen tests for NUW inference)
- rust-lang#133936 (Avoid fetching the anon const hir node that is already available)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 7416c33 into rust-lang:masterDec 6, 2024
@rustbotrustbot added this to the 1.85.0 milestone Dec 6, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 6, 2024
@rust-timer
Unrolled build forrust-lang#133256
f365012
Rollup merge of rust-lang#133256 - MarcoIeni:use-linux-free-runners, r=Kobzol
CI: use free runners for i686-gnu jobs
try-job: i686-gnu-1
try-job: i686-gnu-2
try-job: i686-gnu-nopt-1
try-job: i686-gnu-nopt-2
@marcoienimarcoieni mentioned this pull request Jan 14, 2025
Closed
10 tasks
@marcoienimarcoieni mentioned this pull request May 22, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KobzolKobzolAwaiting requested review from Kobzol

Assignees

@Mark-SimulacrumMark-Simulacrum

Labels

A-testsuiteArea: The testsuite used to check the correctness of rustcS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.85.0

Development

Successfully merging this pull request may close these issues.

6 participants

@marcoieni@rustbot@bors@rust-log-analyzer@Kobzol@Mark-Simulacrum