Skip to content

Simplify hir_typeck_pass_to_variadic_function - #133620

Merged
bors merged 1 commit into
rust-lang:masterfrom
oriongonza:simplify-hir_typeck_pass_to_variadic_function
Nov 30, 2024
Merged

Simplify hir_typeck_pass_to_variadic_function#133620
bors merged 1 commit into
rust-lang:masterfrom
oriongonza:simplify-hir_typeck_pass_to_variadic_function

Conversation

@oriongonza

@oriongonzaoriongonza commented Nov 29, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

r? @compiler-errors
This reworks a bit how the diagnostic is generated so that it does the same as #133538

The help is useless now so I removed it

@rustbot

rustbot commented Nov 29, 2024

Copy link
Copy Markdown
Collaborator

r? @pnkfelix

rustbot has assigned @pnkfelix.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 29, 2024
@rustbot

This comment was marked as off-topic.

Sign in to view
@oriongonzaoriongonza changed the title Simplify hir typeck pass to variadic-functionSimplify hir_typeck_pass_to_variadic_functionNov 29, 2024
@oriongonza
oriongonzaforce-pushed the simplify-hir_typeck_pass_to_variadic_function branch from abb588f to 04d4e0aCompareNovember 29, 2024 10:18
@bors

bors commented Nov 29, 2024

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #133619) made this pull request unmergeable. Please resolve the merge conflicts.

@jieyouxujieyouxu removed A-testsuite Area: The testsuite used to check the correctness of rustc T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) A-compiletest Area: The compiletest test runner labels Nov 29, 2024
@compiler-errors

compiler-errors commented Nov 29, 2024

Copy link
Copy Markdown
Contributor

I can approve after rebase

@compiler-errors

compiler-errors commented Nov 29, 2024

Copy link
Copy Markdown
Contributor

@rustbot author

@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 29, 2024
@oriongonza
oriongonzaforce-pushed the simplify-hir_typeck_pass_to_variadic_function branch from 04d4e0a to ce98bf3CompareNovember 29, 2024 19:49
@oriongonza

oriongonza commented Nov 29, 2024

Copy link
Copy Markdown
ContributorAuthor

@rustbot ready

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 29, 2024
@compiler-errors

compiler-errors commented Nov 29, 2024

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Nov 29, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit ce98bf3 has been approved by compiler-errors

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 29, 2024
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Nov 30, 2024
@jieyouxu
Rollup merge ofrust-lang#133620- dev-ardi:simplify-hir_typeck_pass_…
8666b3e
…to_variadic_function, r=compiler-errors
Simplify hir_typeck_pass_to_variadic_function
r? `@compiler-errors`
This reworks a bit how the diagnostic is generated so that it does the same as rust-lang#133538
The `help` is useless now so I removed it
This was referenced Nov 30, 2024
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 30, 2024
@bors
Auto merge ofrust-lang#133658- jieyouxu:rollup-rq7e0gk, r=jieyouxu
b980396
Rollup of 10 pull requests
Successful merges:
- rust-lang#116161 (Stabilize `extended_varargs_abi_support`)
- rust-lang#132750 ([AIX] handle libunwind native_libs)
- rust-lang#133488 (tests: Add regression test for self referential structs with cow as last field)
- rust-lang#133569 (Bump `ruzstd` to 0.7.3)
- rust-lang#133585 (Do not call `extern_crate` on current trait on crate mismatch errors)
- rust-lang#133587 (Fix target_feature handling in freg of LoongArch inline assembly)
- rust-lang#133599 (Add `+forced-atomics` feature to esp32s2 no_std target)
- rust-lang#133620 (Simplify hir_typeck_pass_to_variadic_function)
- rust-lang#133623 (Improve span handling in `parse_expr_bottom`.)
- rust-lang#133625 (custom MIR: add doc comment for debuginfo)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 30, 2024
@bors
Auto merge ofrust-lang#133658- jieyouxu:rollup-rq7e0gk, r=jieyouxu
e93e096
Rollup of 10 pull requests
Successful merges:
- rust-lang#116161 (Stabilize `extended_varargs_abi_support`)
- rust-lang#132750 ([AIX] handle libunwind native_libs)
- rust-lang#133488 (tests: Add regression test for self referential structs with cow as last field)
- rust-lang#133569 (Bump `ruzstd` to 0.7.3)
- rust-lang#133585 (Do not call `extern_crate` on current trait on crate mismatch errors)
- rust-lang#133587 (Fix target_feature handling in freg of LoongArch inline assembly)
- rust-lang#133599 (Add `+forced-atomics` feature to esp32s2 no_std target)
- rust-lang#133620 (Simplify hir_typeck_pass_to_variadic_function)
- rust-lang#133623 (Improve span handling in `parse_expr_bottom`.)
- rust-lang#133625 (custom MIR: add doc comment for debuginfo)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit c112195 into rust-lang:masterNov 30, 2024
@rustbotrustbot added this to the 1.85.0 milestone Nov 30, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 30, 2024
@rust-timer
Unrolled build forrust-lang#133620
1438902
Rollup merge of rust-lang#133620 - dev-ardi:simplify-hir_typeck_pass_to_variadic_function, r=compiler-errors
Simplify hir_typeck_pass_to_variadic_function
r? ``@compiler-errors``
This reworks a bit how the diagnostic is generated so that it does the same as rust-lang#133538
The `help` is useless now so I removed it
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@compiler-errorscompiler-errorscompiler-errors approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@compiler-errorscompiler-errors

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.85.0

Development

Successfully merging this pull request may close these issues.

6 participants

@oriongonza@rustbot@bors@compiler-errors@pnkfelix@jieyouxu