Skip to content

Fix const conditions for RPITITs - #133926

Merged
bors merged 1 commit into
rust-lang:masterfrom
compiler-errors:const-conditions
Dec 18, 2024
Merged

Fix const conditions for RPITITs#133926
bors merged 1 commit into
rust-lang:masterfrom
compiler-errors:const-conditions

Conversation

@compiler-errors

@compiler-errorscompiler-errors commented Dec 5, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes#133918

r? lcnr

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 5, 2024
@lcnr

lcnr commented Dec 17, 2024

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Dec 17, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit 50f6238 has been approved by lcnr

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 17, 2024
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Dec 17, 2024
@jieyouxu
Rollup merge ofrust-lang#133926- compiler-errors:const-conditions, …
b0b6b62
…r=lcnr
Fix const conditions for RPITITs
Fixesrust-lang#133918
r? lcnr
@jieyouxujieyouxu mentioned this pull request Dec 17, 2024
Closed
@jieyouxu

jieyouxu commented Dec 17, 2024

Copy link
Copy Markdown
Member

Maybe failed in rollup, e.g.:

 error[E0015]: cannot call non-const operator in constant functions
Error: --> /checkout/tests/ui/traits/const-traits/const-impl-trait.rs:12:5
|
LL | a == a
| ^^^^^^
|
= note: calls in constant functions are limited to constant functions, tuple structs and tuple variants

@bors r-

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 17, 2024
@jieyouxujieyouxu reopened this Dec 17, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@compiler-errors

compiler-errors commented Dec 18, 2024

Copy link
Copy Markdown
ContributorAuthor

@bors r=lcnr

@bors

bors commented Dec 18, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit 4977640 has been approved by lcnr

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 18, 2024
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Dec 18, 2024
@jieyouxu
Rollup merge ofrust-lang#133926- compiler-errors:const-conditions, …
c437b03
…r=lcnr
Fix const conditions for RPITITs
Fixesrust-lang#133918
r? lcnr
@jieyouxujieyouxu mentioned this pull request Dec 18, 2024
Closed
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Dec 18, 2024
@jieyouxu
Rollup merge ofrust-lang#133926- compiler-errors:const-conditions, …
5c3829f
…r=lcnr
Fix const conditions for RPITITs
Fixesrust-lang#133918
r? lcnr
@jieyouxujieyouxu mentioned this pull request Dec 18, 2024
Closed
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Dec 18, 2024
@jieyouxu
Rollup merge ofrust-lang#133926- compiler-errors:const-conditions, …
322962a
…r=lcnr
Fix const conditions for RPITITs
Fixesrust-lang#133918
r? lcnr
@jieyouxujieyouxu mentioned this pull request Dec 18, 2024
Closed
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Dec 18, 2024
@jieyouxu
Rollup merge ofrust-lang#133926- compiler-errors:const-conditions, …
df5e242
…r=lcnr
Fix const conditions for RPITITs
Fixesrust-lang#133918
r? lcnr
@jieyouxujieyouxu mentioned this pull request Dec 18, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 18, 2024
@bors
Auto merge ofrust-lang#134458- jieyouxu:rollup-9mxt9ed, r=jieyouxu
795994e
Rollup of 8 pull requests
Successful merges:
- rust-lang#133702 (Variants::Single: do not use invalid VariantIdx for uninhabited enums)
- rust-lang#133926 (Fix const conditions for RPITITs)
- rust-lang#134161 (Overhaul token cursors)
- rust-lang#134253 (Overhaul keyword handling)
- rust-lang#134394 (Clarify the match ergonomics 2024 migration lint's output)
- rust-lang#134420 (refactor: replace &PathBuf with &Path to enhance generality)
- rust-lang#134444 (Fix `x build --stage 1 std` when using cg_cranelift as the default backend)
- rust-lang#134452 (fix(LazyCell): documentation of get[_mut] was wrong)
r? `@ghost`
`@rustbot` modify labels: rollup
@jieyouxujieyouxu mentioned this pull request Dec 18, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 18, 2024
@bors
Auto merge ofrust-lang#134470- jieyouxu:rollup-kld7kmk, r=jieyouxu
a52085d
Rollup of 11 pull requests
Successful merges:
- rust-lang#130786 ( mir-opt: a sub-BB of a cleanup BB must also be a cleanup BB in `EarlyOtherwiseBranch`)
- rust-lang#133926 (Fix const conditions for RPITITs)
- rust-lang#134161 (Overhaul token cursors)
- rust-lang#134253 (Overhaul keyword handling)
- rust-lang#134394 (Clarify the match ergonomics 2024 migration lint's output)
- rust-lang#134399 (Do not do if ! else, use unnegated cond and swap the branches instead)
- rust-lang#134420 (refactor: replace &PathBuf with &Path to enhance generality)
- rust-lang#134436 (tests/assembly/asm: Remove uses of rustc_attrs and lang_items features by using minicore)
- rust-lang#134444 (Fix `x build --stage 1 std` when using cg_cranelift as the default backend)
- rust-lang#134452 (fix(LazyCell): documentation of get[_mut] was wrong)
- rust-lang#134460 (Merge some patterns together)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 81fccef into rust-lang:masterDec 18, 2024
@rustbotrustbot added this to the 1.85.0 milestone Dec 18, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 18, 2024
@rust-timer
Unrolled build forrust-lang#133926
e4d2251
Rollup merge of rust-lang#133926 - compiler-errors:const-conditions, r=lcnr
Fix const conditions for RPITITs
Fixesrust-lang#133918
r? lcnr
@fee1-deadfee1-dead mentioned this pull request Dec 30, 2024
Open
14 tasks
@fmeasefmease added the PG-const-traits Project group: Const traits label Nov 24, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@lcnrlcnr

Labels

PG-const-traitsProject group: Const traitsS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.85.0

7 participants

@compiler-errors@lcnr@bors@jieyouxu@rust-log-analyzer@fmease@rustbot