CI: use free runners for x86_64-gnu-llvm jobs by marcoieni · Pull Request #134124 · rust-lang/rust

marcoieni · 2024-12-10T12:15:20Z

Split the x86_64-gnu-llvm jobs in two to move them to free runners and reduce the use of large runners in CI.
r? @Kobzol

try-job: x86_64-gnu-llvm-19-1
try-job: x86_64-gnu-llvm-19-2
try-job: x86_64-gnu-llvm-19-3
try-job: x86_64-gnu-llvm-18-1
try-job: x86_64-gnu-llvm-18-2
try-job: x86_64-gnu-llvm-18-3

Kobzol · 2024-12-10T12:17:00Z

@bors try

CI: use free runners for x86_64-gnu-llvm jobs try-job: x86_64-gnu-llvm-19-1 try-job: x86_64-gnu-llvm-19-2 try-job: x86_64-gnu-llvm-18-1 try-job: x86_64-gnu-llvm-18-2

bors · 2024-12-10T12:18:11Z

⌛ Trying commit 577b5f3 with merge dda92c0...

bors · 2024-12-10T12:43:11Z

💔 Test failed - checks-actions

marcoieni · 2024-12-10T14:18:12Z

@bors try

CI: use free runners for x86_64-gnu-llvm jobs try-job: x86_64-gnu-llvm-19-1 try-job: x86_64-gnu-llvm-19-2 try-job: x86_64-gnu-llvm-18-1 try-job: x86_64-gnu-llvm-18-2

bors · 2024-12-10T14:19:25Z

⌛ Trying commit e67e9b4 with merge 3a90623...

bors · 2024-12-10T18:14:27Z

☀️ Try build successful - checks-actions
Build commit: 3a90623 (3a906231e57c11e9af1a025356a4d7d7acff0fd7)

Kobzol · 2024-12-10T18:16:04Z

@bors try

CI: use free runners for x86_64-gnu-llvm jobs try-job: x86_64-gnu-llvm-19-1 try-job: x86_64-gnu-llvm-19-2 try-job: x86_64-gnu-llvm-18-1 try-job: x86_64-gnu-llvm-18-2

bors · 2024-12-10T18:17:14Z

⌛ Trying commit e67e9b4 with merge 786e8ac...

bors · 2024-12-10T21:54:49Z

☀️ Try build successful - checks-actions
Build commit: 786e8ac (786e8ac3c40d1020fa839ccff8ef4070960ea800)

Kobzol · 2024-12-10T21:58:51Z

Too slow. Docker was cached, so that was not it. Probably in this case the build part is slower than the test part? We could use my/your infra analysis scripts to confirm.

marcoieni · 2024-12-11T09:31:28Z

we were repeating many thing among the two jobs, I created two script to easily test the job split. Once we are satisfied with this experiment, we can find a more "idiomatic" way to split the tasks among the two jobs 👍

marcoieni · 2024-12-11T09:31:35Z

@bors try

bors · 2024-12-11T09:32:47Z

⌛ Trying commit 4f0e781 with merge 11e24c3...

CI: use free runners for x86_64-gnu-llvm jobs try-job: x86_64-gnu-llvm-19-1 try-job: x86_64-gnu-llvm-19-2 try-job: x86_64-gnu-llvm-18-1 try-job: x86_64-gnu-llvm-18-2

marcoieni · 2024-12-12T20:30:31Z

@bors try

bors · 2024-12-12T20:31:45Z

⌛ Trying commit ac078a4 with merge b9306da...

CI: use free runners for x86_64-gnu-llvm jobs try-job: x86_64-gnu-llvm-19-1 try-job: x86_64-gnu-llvm-19-2 try-job: x86_64-gnu-llvm-19-3 try-job: x86_64-gnu-llvm-18-1 try-job: x86_64-gnu-llvm-18-2 try-job: x86_64-gnu-llvm-18-3

bors · 2024-12-12T22:57:59Z

☀️ Try build successful - checks-actions
Build commit: b9306da (b9306da077ca87a4647b94706d0ef3907619ea0f)

marcoieni · 2024-12-13T08:19:16Z

Looks good 👍

Kobzol · 2024-12-16T10:33:59Z

+
+set -ex
+
+/tmp/add_dummy_commit.sh


This should only be needed for the bootstrap self tests, but the way the skips are configured, these now probably run on both llvm[1/2/3]. Anyway, it doesn't hurt to run it everywhere.

Kobzol · 2024-12-16T10:37:24Z

I can't say that I'm happy about this 😆 But it is what it is.

Kobzol · 2024-12-16T10:37:28Z

@bors r+

bors · 2024-12-16T10:37:31Z

📌 Commit ac078a4 has been approved by Kobzol

It is now in the queue for this repository.

CI: use free runners for x86_64-gnu-llvm jobs try-job: x86_64-gnu-llvm-19-1 try-job: x86_64-gnu-llvm-19-2 try-job: x86_64-gnu-llvm-19-3 try-job: x86_64-gnu-llvm-18-1 try-job: x86_64-gnu-llvm-18-2 try-job: x86_64-gnu-llvm-18-3

…llaumeGomez Rollup of 9 pull requests Successful merges: - rust-lang#132056 (Stabilize `#[diagnostic::do_not_recommend]`) - rust-lang#134124 (CI: use free runners for x86_64-gnu-llvm jobs) - rust-lang#134197 (rustc_mir_build: Clarify that 'mirrored' does not mean 'flipped' or 'reversed') - rust-lang#134260 (Correctly handle comments in attributes in doctests source code) - rust-lang#134277 (rustdoc-search: handle `impl Into<X>` better) - rust-lang#134284 (Keep track of patterns that could have introduced a binding, but didn't) - rust-lang#134337 (reject unsound toggling of RISCV target features) - rust-lang#134385 (tests/ui/asm: Remove uses of rustc_attrs, lang_items, and decl_macro features by using minicore) - rust-lang#134386 (Some trait method vs impl method signature difference diagnostic cleanups) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#134124 (CI: use free runners for x86_64-gnu-llvm jobs) - rust-lang#134197 (rustc_mir_build: Clarify that 'mirrored' does not mean 'flipped' or 'reversed') - rust-lang#134260 (Correctly handle comments in attributes in doctests source code) - rust-lang#134277 (rustdoc-search: handle `impl Into<X>` better) - rust-lang#134284 (Keep track of patterns that could have introduced a binding, but didn't) - rust-lang#134337 (reject unsound toggling of RISCV target features) - rust-lang#134371 (Check for array lengths that aren't actually `usize`) - rust-lang#134385 (tests/ui/asm: Remove uses of rustc_attrs, lang_items, and decl_macro features by using minicore) - rust-lang#134386 (Some trait method vs impl method signature difference diagnostic cleanups) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#134124 - MarcoIeni:split-llvm-jobs, r=Kobzol CI: use free runners for x86_64-gnu-llvm jobs try-job: x86_64-gnu-llvm-19-1 try-job: x86_64-gnu-llvm-19-2 try-job: x86_64-gnu-llvm-19-3 try-job: x86_64-gnu-llvm-18-1 try-job: x86_64-gnu-llvm-18-2 try-job: x86_64-gnu-llvm-18-3

lqd · 2024-12-17T14:19:39Z

For future PRs, it would be nice to clean up the commit history before landing, thanks! 🙏

marcoieni · 2024-12-17T14:30:59Z

oh my god, sorry...I forgot 😵

Kobzol · 2024-12-17T15:00:45Z

Sorry, also missed this.

lqd · 2024-12-17T15:02:55Z

It's ok ^^

CI: use free runners for x86_64-gnu-llvm jobs
577b5f3

rustbot assigned Kobzol Dec 10, 2024

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Dec 10, 2024

marcoieni commented Dec 10, 2024
View reviewed changes

Comment threadsrc/ci/docker/scripts/x86_64-gnu-llvm.sh

This comment has been minimized.
Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 10, 2024

fix
e67e9b4

split better
4f0e781

This comment has been minimized.
Sign in to view

fix path
ac078a4

marcoieni marked this pull request as ready for review December 13, 2024 08:19

Kobzol reviewed Dec 16, 2024
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 16, 2024

GuillaumeGomez mentioned this pull request Dec 16, 2024
Rollup of 10 pull requests #134391
Closed

GuillaumeGomez mentioned this pull request Dec 16, 2024
Rollup of 10 pull requests #134392
Closed

GuillaumeGomez mentioned this pull request Dec 16, 2024
Rollup of 9 pull requests #134393
Closed

matthiaskrgr mentioned this pull request Dec 16, 2024
Rollup of 9 pull requests #134395
Merged

bors merged commit 0ff00b6 into rust-lang:masterDec 16, 2024

rustbot added this to the 1.85.0 milestone Dec 16, 2024

marcoieni mentioned this pull request Jan 14, 2025
Move CI large runners to free runners rust-lang/infra-team#189
Closed
10 tasks


		set -ex

		/tmp/add_dummy_commit.sh

Uh oh!

Uh oh!

Conversation

marcoieni commented Dec 10, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kobzol commented Dec 10, 2024

Uh oh!

bors commented Dec 10, 2024

Uh oh!

Uh oh!

This comment has been minimized.

bors commented Dec 10, 2024

Uh oh!

marcoieni commented Dec 10, 2024

Uh oh!

bors commented Dec 10, 2024

Uh oh!

bors commented Dec 10, 2024

Uh oh!

Kobzol commented Dec 10, 2024

Uh oh!

bors commented Dec 10, 2024

Uh oh!

bors commented Dec 10, 2024

Uh oh!

Kobzol commented Dec 10, 2024

Uh oh!

marcoieni commented Dec 11, 2024

Uh oh!

marcoieni commented Dec 11, 2024

Uh oh!

bors commented Dec 11, 2024

Uh oh!

This comment has been minimized.

This comment has been minimized.

marcoieni commented Dec 12, 2024

Uh oh!

bors commented Dec 12, 2024

Uh oh!

bors commented Dec 12, 2024

Uh oh!

marcoieni commented Dec 13, 2024

Uh oh!

KobzolDec 16, 2024

Choose a reason for hiding this comment

Uh oh!

Kobzol commented Dec 16, 2024

Uh oh!

Kobzol commented Dec 16, 2024

Uh oh!

bors commented Dec 16, 2024

Uh oh!

lqd commented Dec 17, 2024

Uh oh!

marcoieni commented Dec 17, 2024

Uh oh!

Kobzol commented Dec 17, 2024

Uh oh!

lqd commented Dec 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

marcoieni commented Dec 10, 2024•
edited
Loading