Uh oh!
There was an error while loading. Please reload this page.
Lint against manual impl Default that could have been derived - #134175
Closed
estebank wants to merge 26 commits into
Closed
Lint against manual impl Default that could have been derived#134175estebank wants to merge 26 commits into
impl Default that could have been derived#134175estebank wants to merge 26 commits into
Conversation
rustbot
commented
Dec 11, 2024
Collaborator
This comment has been minimized.
This comment has been minimized.
compiler-errors
commented
Dec 11, 2024
Contributor
This adds a new warn-by-default lint, so make sure it gets I-lang-nominated when it's ready |
This comment has been minimized.
This comment has been minimized.
estebankforce-pushed
the
manual-default-could-be-derive
branch
from
December 12, 2024 19:11
5d36626 to
ab57d60Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
estebank
commented
Dec 12, 2024
ContributorAuthor
The new |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
estebankforce-pushed
the
manual-default-could-be-derive
branch
from
December 12, 2024 23:34
5b4a086 to
0411790Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
estebankforce-pushed
the
manual-default-could-be-derive
branch
2 times, most recently
from
December 13, 2024 17:07
874b484 to
a861c8eCompare
This comment has been minimized.
This comment has been minimized.
estebankforce-pushed
the
manual-default-could-be-derive
branch
from
December 13, 2024 18:19
a861c8e to
4d2f468Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
estebankforce-pushed
the
manual-default-could-be-derive
branch
from
December 15, 2024 19:48
ffdc153 to
55a1857Compareestebankforce-pushed
the
manual-default-could-be-derive
branch
from
December 16, 2024 02:03
21ac4fd to
6fa30b6CompareMember
Let me know if this is ready for review / you want me to look at it, I'm going to mark it as waiting-on-author for the time being. |
estebank
commented
Dec 16, 2024
ContributorAuthor
@bors try |
bors
commented
Dec 16, 2024
Collaborator
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 16, 2024
…ive, r=<try>
Lint against manual `impl Default` that could have been `derive`d
```
error: `impl Default` that could be derived
--> $DIR/manual-default-impl-could-be-derived.rs:74:1
|
LL | / impl Default for G {
LL | | fn default() -> Self {
LL | | G {
LL | | f: F::Unit,
LL | | }
LL | | }
LL | | }
| |_^
|
help: you don't need to manually `impl Default`, you can derive it
|
LL ~ #[derive(Default)] struct G {
|
```
As part of rust-lang#132162/rust-lang/rfcs#3681 we want to lint when default fields values could preclude the need of a manual `impl Default`, but there are already cases where these manual impls could be derived. This PR introduces a new `default_could_be_derived` lint that makes a best effort check of the body of the `Default::default()` implementation to see if all the fields of a single expression in that body are either known to be `Default` already (like an explicit call to `Default::default()`, a `0` literal, or `Option::None` path) or are identified to be equivalent to the field's type's `Default` value (by opportunistically looking at the `Default::default()` body for that field's type).rust-log-analyzer
commented
Dec 16, 2024
Collaborator
The job Click to see the possible cause of the failure (guessed by this bot) |
bors
commented
Dec 16, 2024
Collaborator
💔 Test failed - checks-actions |
bors
commented
Dec 18, 2024
Collaborator
☔ The latest upstream changes (presumably #134243) made this pull request unmergeable. Please resolve the merge conflicts. |
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 23, 2024
Use `#[derive(Default)]` instead of manual `impl` when possible While working on rust-lang#134175 I noticed a few manual `Default` `impl`s that could be `derive`d instead. These likely predate the existence of the `#[default]` attribute for `enum`s.
rust-timer added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 23, 2024
Rollup merge of rust-lang#134363 - estebank:derive-default, r=SparrowLii Use `#[derive(Default)]` instead of manual `impl` when possible While working on rust-lang#134175 I noticed a few manual `Default` `impl`s that could be `derive`d instead. These likely predate the existence of the `#[default]` attribute for `enum`s.
Nadrieril
commented
Jan 15, 2025
Member
Analyzing the body of a user-written function in search for known patterns feels very much like clippy territory to me. In fact clippy's |
estebank
commented
Jan 15, 2025
ContributorAuthor
@Nadrieril yeah, I've filed a PR with some of the more advanced analysis to clippy, but not all of it. |
18 tasks
github-actionsBot
pushed a commit
to tautschnig/verify-rust-std
that referenced
this pull request
Mar 11, 2025
Use `#[derive(Default)]` instead of manual `impl` when possible While working on rust-lang#134175 I noticed a few manual `Default` `impl`s that could be `derive`d instead. These likely predate the existence of the `#[default]` attribute for `enum`s.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of #132162/rust-lang/rfcs#3681 we want to lint when default fields values could preclude the need of a manual
impl Default, but there are already cases where these manual impls could be derived. This PR introduces a newdefault_could_be_derivedlint that makes a best effort check of the body of theDefault::default()implementation to see if all the fields of a single expression in that body are either known to beDefaultalready (like an explicit call toDefault::default(), a0literal, orOption::Nonepath) or are identified to be equivalent to the field's type'sDefaultvalue (by opportunistically looking at theDefault::default()body for that field's type).